Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant duplicate message logging. #9967

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

We already log the duplicate at the point when we actually drop it.

Problem

Logs that look like this:

[1632511832.268209][33148:33148] CHIP:IN: Received a duplicate message with MessageCounter: 1366413728
[1632511832.268237][33148:33148] CHIP:IN: Received a duplicate message with MessageCounter:1366413728 on exchange 16911r

Change overview

Just keep the second of those messages.

Testing

No behavior changes.

@bzbarsky-apple
Copy link
Contributor Author

/rebase

We already log the duplicate at the point when we actually drop it.
@github-actions
Copy link

Size increase report for "esp32-example-build" from 45715cc

File Section File VM
chip-all-clusters-app.elf .flash.text -40 -40
chip-all-clusters-app.elf .flash.rodata -56 -56
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
[Unmapped],0,96
.flash.text,-40,-40
.flash.rodata,-56,-56
.debug_info,0,-68
.debug_loc,0,-124
.debug_line,0,-156


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 45715cc

File Section File VM
chip-shell.elf device_handles -12 -12
chip-shell.elf text -36 -36
chip-shell.elf rodata -56 -52
chip-lock.elf device_handles -12 -12
chip-lock.elf text -36 -36
chip-lock.elf rodata -48 -52
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
device_handles,-12,-12
text,-36,-36
.debug_ranges,0,-48
rodata,-52,-56
.debug_line,0,-137
.debug_loc,0,-164
.debug_info,0,-171

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
device_handles,-12,-12
text,-36,-36
.debug_ranges,0,-48
rodata,-52,-48
.debug_loc,0,-124
.debug_line,0,-137
.debug_info,0,-171


@bzbarsky-apple bzbarsky-apple merged commit e4d15a8 into project-chip:master Sep 27, 2021
@bzbarsky-apple bzbarsky-apple deleted the remove-extra-logging branch September 27, 2021 22:37
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Oct 15, 2021
We already log the duplicate at the point when we actually drop it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants