Remove redundant duplicate message logging. (project-chip#9967)

bzbarsky-apple · mkardous-silabs · commit d30d45d7b04c · 2021-10-15T11:28:18.000-04:00
We already log the duplicate at the point when we actually drop it.
diff --git a/src/transport/SessionManager.cpp b/src/transport/SessionManager.cpp
@@ -352,7 +352,6 @@ void SessionManager::MessageDispatch(const PacketHeader & packetHeader, const Tr
     CHIP_ERROR err = session->GetPeerMessageCounter().VerifyOrTrustFirst(packetHeader.GetMessageCounter());
     if (err == CHIP_ERROR_DUPLICATE_MESSAGE_RECEIVED)
     {
-        ChipLogDetail(Inet, "Received a duplicate message with MessageCounter: %" PRIu32, packetHeader.GetMessageCounter());
         isDuplicate = SessionManagerDelegate::DuplicateMessage::Yes;
         err         = CHIP_NO_ERROR;
     }
@@ -433,7 +432,6 @@ void SessionManager::SecureMessageDispatch(const PacketHeader & packetHeader, co
         err = state->GetSessionMessageCounter().GetPeerMessageCounter().Verify(packetHeader.GetMessageCounter());
         if (err == CHIP_ERROR_DUPLICATE_MESSAGE_RECEIVED)
         {
-            ChipLogDetail(Inet, "Received a duplicate message with MessageCounter: %" PRIu32, packetHeader.GetMessageCounter());
             isDuplicate = SessionManagerDelegate::DuplicateMessage::Yes;
             err         = CHIP_NO_ERROR;
         }

Original file line number	Diff line number	Diff line change
`@@ -352,7 +352,6 @@ void SessionManager::MessageDispatch(const PacketHeader & packetHeader, const Tr`
`352`	`352`	`CHIP_ERROR err = session->GetPeerMessageCounter().VerifyOrTrustFirst(packetHeader.GetMessageCounter());`
`353`	`353`	`if (err == CHIP_ERROR_DUPLICATE_MESSAGE_RECEIVED)`
`354`	`354`	`{`
`355`		`- ChipLogDetail(Inet, "Received a duplicate message with MessageCounter: %" PRIu32, packetHeader.GetMessageCounter());`
`356`	`355`	`isDuplicate = SessionManagerDelegate::DuplicateMessage::Yes;`
`357`	`356`	`err = CHIP_NO_ERROR;`
`358`	`357`	`}`
`@@ -433,7 +432,6 @@ void SessionManager::SecureMessageDispatch(const PacketHeader & packetHeader, co`
`433`	`432`	`err = state->GetSessionMessageCounter().GetPeerMessageCounter().Verify(packetHeader.GetMessageCounter());`
`434`	`433`	`if (err == CHIP_ERROR_DUPLICATE_MESSAGE_RECEIVED)`
`435`	`434`	`{`
`436`		`- ChipLogDetail(Inet, "Received a duplicate message with MessageCounter: %" PRIu32, packetHeader.GetMessageCounter());`
`437`	`435`	`isDuplicate = SessionManagerDelegate::DuplicateMessage::Yes;`
`438`	`436`	`err = CHIP_NO_ERROR;`
`439`	`437`	`}`