-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[im] Land ReadAttribute using Interaction Model protocol #7634
Merged
woody-apple
merged 10 commits into
project-chip:master
from
erjiaqing:feature/im-attribute-reading
Jun 28, 2021
Merged
[im] Land ReadAttribute using Interaction Model protocol #7634
woody-apple
merged 10 commits into
project-chip:master
from
erjiaqing:feature/im-attribute-reading
Jun 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
kedars,
LuDuda,
mspang,
pan-apple,
saurabhst and
woody-apple
June 15, 2021 04:25
erjiaqing
changed the title
[im] Land ReadAttribute over Interaction Model protocal
[im] Land ReadAttribute using Interaction Model protocol
Jun 15, 2021
yunhanw-google
approved these changes
Jun 15, 2021
erjiaqing
force-pushed
the
feature/im-attribute-reading
branch
4 times, most recently
from
June 15, 2021 09:16
24807c5
to
aae4384
Compare
erjiaqing
force-pushed
the
feature/im-attribute-reading
branch
from
June 15, 2021 14:51
aae4384
to
be29ca2
Compare
msandstedt
reviewed
Jun 15, 2021
msandstedt
reviewed
Jun 15, 2021
erjiaqing
force-pushed
the
feature/im-attribute-reading
branch
4 times, most recently
from
June 28, 2021 03:16
cadcc09
to
3fbd92c
Compare
8 tasks
erjiaqing
force-pushed
the
feature/im-attribute-reading
branch
from
June 28, 2021 03:50
3fbd92c
to
6ea072f
Compare
erjiaqing
force-pushed
the
feature/im-attribute-reading
branch
from
June 28, 2021 05:42
6ea072f
to
b3ee441
Compare
Size increase report for "gn_qpg6100-example-build" from 17dbc19
Full report output
|
Size increase report for "nrfconnect-example-build" from 17dbc19
Full report output
|
Size increase report for "esp32-example-build" from 17dbc19
Full report output
|
This was referenced Jun 28, 2021
bzbarsky-apple
approved these changes
Jun 28, 2021
woody-apple
approved these changes
Jun 28, 2021
Approving given feedback. We'll have to follow up with require tests here, and future fixes. |
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…p#7634) * [im] Implement cluster reading * Cleanup ember code for attribute reading * Disable CRMP for AttributeReading * Address comments * Revert changes to callback types. * Add TLVDataFilter for checking values in TLV * Fix python script for attribute reading * Address comments * Add secure session handle to SendReadRequest * Run codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing