Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[im] Land ReadAttribute using Interaction Model protocol #7634

Merged

Conversation

erjiaqing
Copy link
Contributor

@erjiaqing erjiaqing commented Jun 15, 2021

Problem

Change overview

  • Use interaction model for reading cluster attributes
  • For reviewers: the last commit (Run codegen) only contains changes from codegen, you can ignore it by manaully select other five commits in "Files changed" panel.

Testing

  • Local tested using chip-device-ctrl
  • Protocol shift, already covered by Darwin and Cirque tests

@erjiaqing erjiaqing changed the title [im] Land ReadAttribute over Interaction Model protocal [im] Land ReadAttribute using Interaction Model protocol Jun 15, 2021
@erjiaqing erjiaqing force-pushed the feature/im-attribute-reading branch 4 times, most recently from 24807c5 to aae4384 Compare June 15, 2021 09:16
@yufengwangca yufengwangca self-requested a review June 15, 2021 14:45
@erjiaqing erjiaqing force-pushed the feature/im-attribute-reading branch from aae4384 to be29ca2 Compare June 15, 2021 14:51
@erjiaqing erjiaqing force-pushed the feature/im-attribute-reading branch 4 times, most recently from cadcc09 to 3fbd92c Compare June 28, 2021 03:16
@erjiaqing erjiaqing force-pushed the feature/im-attribute-reading branch from 3fbd92c to 6ea072f Compare June 28, 2021 03:50
@erjiaqing erjiaqing requested a review from bzbarsky-apple June 28, 2021 04:06
@erjiaqing erjiaqing force-pushed the feature/im-attribute-reading branch from 6ea072f to b3ee441 Compare June 28, 2021 05:42
@github-actions
Copy link

Size increase report for "gn_qpg6100-example-build" from 17dbc19

File Section File VM
chip-qpg6100-lighting-example.out .bss 0 640
chip-qpg6100-lighting-example.out .text 424 424
chip-qpg6100-lighting-example.out .heap 0 -640
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_info,0,4794
.debug_line,0,1001
.bss,640,0
.debug_str,0,622
.debug_ranges,0,600
.debug_loc,0,599
.text,424,424
.symtab,0,256
.debug_abbrev,0,236
.strtab,0,166
.debug_frame,0,56
.debug_aranges,0,8
.shstrtab,0,2
[Unmapped],0,-424
.heap,-640,0

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 17dbc19

File Section File VM
chip-lock.elf text 708 708
chip-lock.elf bss 0 639
chip-lock.elf [LOAD #3 [RW]] 0 1
chip-lock.elf device_handles -4 -4
chip-lock.elf rodata -200 -204
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,5049
.debug_line,0,1046
.debug_ranges,0,736
text,708,708
bss,639,0
.debug_str,0,618
.debug_loc,0,490
.symtab,0,240
.debug_abbrev,0,221
.strtab,0,166
.debug_frame,0,56
.debug_aranges,0,8
.shstrtab,0,2
[LOAD #3 [RW]],1,0
device_handles,-4,-4
rodata,-204,-200

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "esp32-example-build" from 17dbc19

File Section File VM
chip-all-clusters-app.elf .dram0.bss 0 1384
chip-all-clusters-app.elf .flash.text 728 728
chip-all-clusters-app.elf .flash.rodata -216 -216
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,5072
.debug_line,0,2122
.debug_loc,0,1862
.dram0.bss,1384,0
.debug_ranges,0,768
.flash.text,728,728
.debug_str,0,618
.debug_abbrev,0,226
[Unmapped],0,216
.strtab,0,116
.symtab,0,48
.xt.prop._ZN4chip3app22InteractionModelEngineD2Ev,0,48
.debug_aranges,0,8
.flash.rodata,-216,-216


@woody-apple
Copy link
Contributor

Approving given feedback. We'll have to follow up with require tests here, and future fixes.

@woody-apple woody-apple merged commit f88fe0a into project-chip:master Jun 28, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
…p#7634)

* [im] Implement cluster reading

* Cleanup ember code for attribute reading

* Disable CRMP for AttributeReading

* Address comments

* Revert changes to callback types.

* Add TLVDataFilter for checking values in TLV

* Fix python script for attribute reading

* Address comments

* Add secure session handle to SendReadRequest

* Run codegen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate IM read interaction with ember
7 participants