We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This is still not making sense to me. If the caller does not care about the value, what do they care about? Just whether it exists?
But looking at the ReadSingleClusterData implemetations:
ReadSingleClusterData
TestCommandInteraction.cpp
apDataExists
apWriter
TestReportingEngine.cpp
chip_im_initiator.cpp
chip_im_responder.cpp
ember-compatibility-functions.cpp
And more to the point: is there ever a caller that actually passes null for apWriter? I don't obviously see one.
Originally posted by @bzbarsky-apple in #7634 (comment)
The text was updated successfully, but these errors were encountered:
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Sorry, something went wrong.
This is fixed now, since ReadSingleClusterData gets a AttributeReportIBs::Builder and hence always has a TLVWriter.
AttributeReportIBs::Builder
erjiaqing
No branches or pull requests
This is still not making sense to me. If the caller does not care about the value, what do they care about? Just whether it exists?
But looking at the
ReadSingleClusterData
implemetations:TestCommandInteraction.cpp
leavesapDataExists
unset ifapWriter
is null.TestReportingEngine.cpp
, same thing.chip_im_initiator.cpp
, same thing.chip_im_responder.cpp
, same thing.ember-compatibility-functions.cpp
seems to implement the "just set apDataExists" semantics, ok.And more to the point: is there ever a caller that actually passes null for apWriter? I don't obviously see one.
Originally posted by @bzbarsky-apple in #7634 (comment)
The text was updated successfully, but these errors were encountered: