Switch DataModel::Provider to a span-based list iterator - flash and ram savings, simpler interface #37033
+1,910
−1,925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y use it (so I can validate tests)
…y for expansion. This saves a tiny amount of flash (32 bytes)
… saves 8 bytes for struct. We still have a 20-byte padding which I am unsure how to get rid of
Co-authored-by: Boris Zbarsky <[email protected]>
…tedhomeip into list-metadata-prototype
…ullopt and wildcards
|
PR #37033: Size comparison from 4fd7215 to 12ad52c Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assumption here is that we always have sufficient heap (given that we have to handle sigma messages in the event loop and the metadata for things is generally reasonably small and can also be backed by static structures).
This is similar to #36889, however with a different approach (still using templates, however instead of pure iterators we have a concrete return list, which is likely to lead to simpler code because our existing design is often assuming flat lists).
Testing
Unit tests will be updated and generally integration tests should cover this quite well as well. No change in functionality is expected, only code layout.
New MetadataList class has extensive unit tests.