[DRAFT/TEST] Evaluate cost of flash if switching to a templated abstract iterator on DataModel::Provider #36889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll somewhat unclear how efficient these are or how AttributePathExpandIterator can even work with these
|
Review changes with |
|
PR #36889: Size comparison from b0d0614 to a3edec0 Full report (3 builds for cc32xx, stm32)
|
|
PR #36889: Size comparison from b0d0614 to d1a87c5 Increases above 0.2%:
Full report (9 builds for cc13x4_26x4, cc32xx, stm32, tizen)
|
|
PR #36889: Size comparison from b0d0614 to 27b9ca0 Increases above 0.2%:
Full report (25 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
|
PR #36889: Size comparison from b0d0614 to d0f3069 Increases above 0.2%:
Full report (23 builds for cc13x4_26x4, efr32, esp32, linux, nrfconnect, qpg, stm32, telink)
|
|
PR #36889: Size comparison from b0d0614 to 1ac6576 Increases above 0.2%:
Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
|
PR #36889: Size comparison from b0d0614 to 255d458 Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
changed the title
|
PR #36889: Size comparison from b0d0614 to 95a242f Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36889: Size comparison from b0d0614 to a813df9 Increases above 0.2%:
Full report (25 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
|
PR #36889: Size comparison from b0d0614 to 246fd32 Increases above 0.2%:
Full report (25 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
|
PR #36889: Size comparison from f05b65e to 85215fd Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36889: Size comparison from 388be5b to 3967e2f Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch is a lot of code, so implementing a small subset to see actual effect. Letting CI compute bloat on this.
Actual approach is still TBD as this incurs HEAP + vtable.
Mostly concerned about heap (a bit ... objects will be a few numbers/pointers, so small) and flash increase (vtable and template type explosion)