Make GetDeviceTypes pure virtual since we have an impl now

project-chip · Dec 18, 2024 · d1a87c5 · d1a87c5
1 parent aa7cc8f
commit d1a87c5
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/src/app/data-model-provider/MetadataTypes.h b/src/app/data-model-provider/MetadataTypes.h
@@ -207,10 +207,7 @@ class ProviderMetadataTree
     {
         return std::make_unique<NullMetadataIterator<EndpointId, EndpointInfo>>();
     }
-    virtual std::unique_ptr<ElementIterator<DeviceTypeEntry>> GetDeviceTypes(EndpointId endpointId)
-    {
-        return std::make_unique<NullElementIterator<DeviceTypeEntry>>();
-    }
+    virtual std::unique_ptr<ElementIterator<DeviceTypeEntry>> GetDeviceTypes(EndpointId endpointId) = 0;
     virtual std::unique_ptr<ElementIterator<SemanticTag>> GetSemanticTags(EndpointId endpointId)
     {
         return std::make_unique<NullElementIterator<SemanticTag>>();

diff --git a/src/app/tests/test-interaction-model-api.h b/src/app/tests/test-interaction-model-api.h
@@ -129,6 +129,12 @@ class TestImCustomDataModel : public DataModel::Provider
     ConcreteCommandPath FirstGeneratedCommand(const ConcreteClusterPath & cluster) override;
     ConcreteCommandPath NextGeneratedCommand(const ConcreteCommandPath & before) override;
     void Temporary_ReportAttributeChanged(const AttributePathParams & path) override {}
+
+    // NULL implementations
+    std::unique_ptr<DataModel::ElementIterator<DataModel::DeviceTypeEntry>> GetDeviceTypes(EndpointId endpointId) override
+    {
+        return std::make_unique<DataModel::NullElementIterator<DataModel::DeviceTypeEntry>>();
+    }
 };
 
 } // namespace app

diff --git a/src/controller/tests/data_model/DataModelFixtures.h b/src/controller/tests/data_model/DataModelFixtures.h
@@ -141,6 +141,12 @@ class CustomDataModel : public DataModel::Provider
     ConcreteCommandPath FirstGeneratedCommand(const ConcreteClusterPath & cluster) override;
     ConcreteCommandPath NextGeneratedCommand(const ConcreteCommandPath & before) override;
     void Temporary_ReportAttributeChanged(const AttributePathParams & path) override {}
+
+    // NULL implementations
+    std::unique_ptr<DataModel::ElementIterator<DataModel::DeviceTypeEntry>> GetDeviceTypes(EndpointId endpointId) override
+    {
+        return std::make_unique<DataModel::NullElementIterator<DataModel::DeviceTypeEntry>>();
+    }
 };
 
 } // namespace DataModelTests