[SVE][ICD] Bump MaxICDMonitoringEntrySize to reasonable size #35737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #35737: Size comparison from 8750c55 to c06123b Full report (22 builds for cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248 and
hicklin
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
mkardous-silabs
approved these changes
Sep 23, 2024
tcarmelveilleux
approved these changes
Sep 23, 2024
bzbarsky-apple
requested changes
Sep 23, 2024
|
PR #35737: Size comparison from 8750c55 to 4b4578c Full report (22 builds for cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
|
yunhanw-google
force-pushed
the
feature/fix_icd_monitor_entry_size
branch
from
40ac3d1 to
a5d18f8
Compare
bzbarsky-apple
approved these changes
Sep 23, 2024
|
PR #35737: Size comparison from 1597be7 to a5d18f8 Full report (20 builds for cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
|
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #35737: Size comparison from 1597be7 to 380b633 Full report (3 builds for cc32xx, stm32)
|
|
PR #35737: Size comparison from 1597be7 to 28a34fc Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…-chip#35737) * Fix icd monitor entry size * Restyled by whitespace * Restyled by clang-format * port test from pr 35734 * update documentation * Update src/app/icd/server/ICDMonitoringTable.h Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous MaxICDMonitoringEntrySize 60 cannot handle the "full width" node ID, for example, 0xffff000000000000 so that registerClient with the above nodeId would fail with too small buffer size error where size is 63, which is larger than 60
in this PR, we use EstimateStructOverhead *3/2 to calculate size.
we need slack of at least 50% to make sure we can grow and then if there is a firmware upgrade/downgrade, that it doesn't brick
fixes #35735