Update ICDMonitoringTable.h

yunhanw-google · web-flow · commit 40ac3d150ffb · 2024-09-23T15:03:37.000-07:00
diff --git a/src/app/icd/server/ICDMonitoringTable.h b/src/app/icd/server/ICDMonitoringTable.h
@@ -41,7 +41,7 @@ static constexpr size_t MaxICDMonitoringEntrySize()
                                        sizeof(Crypto::Symmetric128BitsKeyByteArray) /*aes_key_handle*/,
                                        sizeof(Crypto::Symmetric128BitsKeyByteArray) /*hmac_key_handle*/,
                                        sizeof(uint8_t) /*client_type*/) *
-        3 / 2;
+        3 / 2; // Expect to have at least 50% to make sure we can grow and then if there is a firmware upgrade/downgrade, it doesn't brick
 }
 
 inline constexpr size_t kICDMonitoringBufferSize = MaxICDMonitoringEntrySize();

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ static constexpr size_t MaxICDMonitoringEntrySize()`
`41`	`41`	`sizeof(Crypto::Symmetric128BitsKeyByteArray) /aes_key_handle/,`
`42`	`42`	`sizeof(Crypto::Symmetric128BitsKeyByteArray) /hmac_key_handle/,`
`43`	`43`	`sizeof(uint8_t) /client_type/) *`
`44`		`- 3 / 2;`
	`44`	`+ 3 / 2; // Expect to have at least 50% to make sure we can grow and then if there is a firmware upgrade/downgrade, it doesn't brick`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`inline constexpr size_t kICDMonitoringBufferSize = MaxICDMonitoringEntrySize();`