-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Replaced automatable PICS in SEAR tests #35231
base: master
Are you sure you want to change the base?
Changes from 8 commits
cfa0fcf
5ad2b47
32cd0ad
b830540
b253b36
c2829af
5b83c7a
b8903bc
c17f287
ea856f9
1fa489a
c74e2da
ed064c2
5156b82
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,7 +72,7 @@ async def read_progress(self, step): | |
return progress | ||
|
||
def TC_SEAR_1_6(self) -> list[str]: | ||
return ["SEAR.S", "SEAR.S.A0005", "SEAR.S.A0000", "SEAR.S.A0002", "SEAR.S.M.HAS_MANUAL_OPERATING_STATE_CONTROL"] | ||
return ["SEAR.S", "SEAR.S.M.HAS_MANUAL_OPERATING_STATE_CONTROL"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually, let's just leave this test as-is for now. The top level pics we can deal with separately and this will mess up the TH There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you, |
||
|
||
@async_test_body | ||
async def test_TC_SEAR_1_6(self): | ||
|
@@ -85,6 +85,22 @@ async def test_TC_SEAR_1_6(self): | |
asserts.fail("The --app-pid flag must be set when PICS_SDK_CI_ONLY is set") | ||
self.app_pipe = self.app_pipe + str(app_pid) | ||
|
||
attributes = Clusters.ServiceArea.Attributes | ||
attribute_list = await self.read_sear_attribute_expect_success( | ||
endpoint=self.endpoint, attribute=Clusters.ServiceArea.Attributes.AttributeList) | ||
SupportedAreas = attributes.SupportedAreas.attribute_id | ||
SelectedAreas = attributes.SelectedAreas.attribute_id | ||
Progress = attributes.Progress.attribute_id | ||
|
||
if SupportedAreas not in attribute_list: | ||
asserts.fail("Supported areas attribute required in attribute list to run test") | ||
|
||
if SelectedAreas not in attribute_list: | ||
asserts.fail("Selected areas attribute required in attribute list to run test") | ||
|
||
if Progress not in attribute_list: | ||
asserts.fail("Progress attribute required in attribute list to run test") | ||
|
||
self.print_step(1, "Commissioning, already done") | ||
|
||
# Ensure that the device is in the correct state | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here - let's leave the top level PICS as-is for now and we'll deal with the top level PICS separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been updated to leave the top level PICS as-is.