Remove RemovedOn attribute from ECOINFO cluster #34988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 8 of 31 files. Overall, the semantic diff is 51% smaller than the GitHub diff. File Information
|
github-actions
bot
added
examples
darwin
controller
app
tests
matter-1.4-te2-script-change
tehampson
commented
Aug 14, 2024
examples/fabric-bridge-app/fabric-bridge-common/src/BridgedDeviceManager.cpp
Show resolved
Hide resolved
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex and
harsha-rajendran
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
tehampson
commented
Aug 14, 2024
examples/fabric-bridge-app/fabric-bridge-common/src/BridgedDeviceManager.cpp
Show resolved
Hide resolved
|
PR #34988: Size comparison from e1f29bd to 46c5df7 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Aug 14, 2024
|
PR #34988: Size comparison from baba33d to ca5f38a Full report (41 builds for bl602, bl702, bl702l, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
tehampson
added
the
skip-protocol-compatibility
|
PR #34988: Size comparison from baba33d to 2224eaa Increases above 0.2%:
Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
It is now merged in https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10298 |
PeterC1965
pushed a commit
to PeterC1965/connectedhomeip
that referenced
this pull request
Aug 28, 2024
* Remove RemovedOn attribute from ECOINFO cluster * Restyled by autopep8 * Remove artifact that were only initially used to debug script locally * Move attr IDs after RemovedOn removal * Empty-Commit --------- Co-authored-by: Restyled.io <[email protected]>
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
* Remove RemovedOn attribute from ECOINFO cluster * Restyled by autopep8 * Remove artifact that were only initially used to debug script locally * Move attr IDs after RemovedOn removal * Empty-Commit --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is conflicting spec behavior for what is supposed to happen when a device is removed. Spec issue filed https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/10234
This is a provisional cluster, as such it is allowed to change in ways that break compatibility