Skip to content

Commit

Permalink
Move attr IDs after RemovedOn removal
Browse files Browse the repository at this point in the history
  • Loading branch information
tehampson committed Aug 20, 2024
1 parent e41d6d6 commit ca5f38a
Show file tree
Hide file tree
Showing 11 changed files with 28 additions and 29 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,11 @@ limitations under the License.
<server init="false" tick="false">true</server>
<!-- cluster revision -->
<globalAttribute code="0xFFFD" side="either" value="1"/>
<!-- RemovedOn with code 0x0000 is deprecated -->
<attribute code="0x0001" side="server" define="DEVICE_DIRECTORY" type="array" entryType="EcosystemDeviceStruct" length="256" minLength="1">
<attribute code="0x0000" side="server" define="DEVICE_DIRECTORY" type="array" entryType="EcosystemDeviceStruct" length="256" minLength="1">
<description>DeviceDirectory</description>
<access op="read" privilege="manage"/>
</attribute>
<attribute code="0x0002" side="server" define="LOCATION_DIRECTORY" type="array" entryType="EcosystemLocationStruct" length="64" minLength="1">
<attribute code="0x0001" side="server" define="LOCATION_DIRECTORY" type="array" entryType="EcosystemLocationStruct" length="64" minLength="1">
<description>LocationDirectory</description>
<access op="read" privilege="manage"/>
</attribute>
Expand Down
4 changes: 2 additions & 2 deletions src/controller/data_model/controller-clusters.matter
Original file line number Diff line number Diff line change
Expand Up @@ -9395,8 +9395,8 @@ provisional cluster EcosystemInformation = 1872 {
fabric_idx fabricIndex = 254;
}

readonly attribute access(read: manage) EcosystemDeviceStruct deviceDirectory[] = 1;
readonly attribute access(read: manage) EcosystemLocationStruct locationDirectory[] = 2;
readonly attribute access(read: manage) EcosystemDeviceStruct deviceDirectory[] = 0;
readonly attribute access(read: manage) EcosystemLocationStruct locationDirectory[] = 1;
readonly attribute command_id generatedCommandList[] = 65528;
readonly attribute command_id acceptedCommandList[] = 65529;
readonly attribute event_id eventList[] = 65530;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60768,8 +60768,8 @@ public void onSuccess(byte[] tlv) {
public static class EcosystemInformationCluster extends BaseChipCluster {
public static final long CLUSTER_ID = 1872L;

private static final long DEVICE_DIRECTORY_ATTRIBUTE_ID = 1L;
private static final long LOCATION_DIRECTORY_ATTRIBUTE_ID = 2L;
private static final long DEVICE_DIRECTORY_ATTRIBUTE_ID = 0L;
private static final long LOCATION_DIRECTORY_ATTRIBUTE_ID = 1L;
private static final long GENERATED_COMMAND_LIST_ATTRIBUTE_ID = 65528L;
private static final long ACCEPTED_COMMAND_LIST_ATTRIBUTE_ID = 65529L;
private static final long EVENT_LIST_ATTRIBUTE_ID = 65530L;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17237,8 +17237,8 @@ public long getID() {
}

public enum Attribute {
DeviceDirectory(1L),
LocationDirectory(2L),
DeviceDirectory(0L),
LocationDirectory(1L),
GeneratedCommandList(65528L),
AcceptedCommandList(65529L),
EventList(65530L),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class EcosystemInformationCluster(
}

suspend fun readDeviceDirectoryAttribute(): DeviceDirectoryAttribute {
val ATTRIBUTE_ID: UInt = 1u
val ATTRIBUTE_ID: UInt = 0u

val attributePath =
AttributePath(endpointId = endpointId, clusterId = CLUSTER_ID, attributeId = ATTRIBUTE_ID)
Expand Down Expand Up @@ -144,7 +144,7 @@ class EcosystemInformationCluster(
minInterval: Int,
maxInterval: Int,
): Flow<DeviceDirectoryAttributeSubscriptionState> {
val ATTRIBUTE_ID: UInt = 1u
val ATTRIBUTE_ID: UInt = 0u
val attributePaths =
listOf(
AttributePath(endpointId = endpointId, clusterId = CLUSTER_ID, attributeId = ATTRIBUTE_ID)
Expand Down Expand Up @@ -202,7 +202,7 @@ class EcosystemInformationCluster(
}

suspend fun readLocationDirectoryAttribute(): LocationDirectoryAttribute {
val ATTRIBUTE_ID: UInt = 2u
val ATTRIBUTE_ID: UInt = 1u

val attributePath =
AttributePath(endpointId = endpointId, clusterId = CLUSTER_ID, attributeId = ATTRIBUTE_ID)
Expand Down Expand Up @@ -243,7 +243,7 @@ class EcosystemInformationCluster(
minInterval: Int,
maxInterval: Int,
): Flow<LocationDirectoryAttributeSubscriptionState> {
val ATTRIBUTE_ID: UInt = 2u
val ATTRIBUTE_ID: UInt = 1u
val attributePaths =
listOf(
AttributePath(endpointId = endpointId, clusterId = CLUSTER_ID, attributeId = ATTRIBUTE_ID)
Expand Down
8 changes: 4 additions & 4 deletions src/controller/python/chip/clusters/CHIPClusters.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions src/controller/python/chip/clusters/Objects.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/darwin/Framework/CHIP/zap-generated/MTRClusterConstants.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions zzz_generated/chip-tool/zap-generated/cluster/Commands.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit ca5f38a

Please sign in to comment.