Allow CommandSender request to be built using DataModel::EncodableToTLV #33782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #33782: Size comparison from 88ebdf7 to 3f2bba4 Increases above 0.2%:
Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kiel-apple
pullapprove
bot
requested review from
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
andy31415
reviewed
Jun 6, 2024
andy31415
approved these changes
Jun 6, 2024
|
PR #33782: Size comparison from 88ebdf7 to 65d9dca Increases above 0.2%:
Full report (11 builds for cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
|
PR #33782: Size comparison from 88ebdf7 to 02da318 Increases above 0.2%:
Full report (48 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, esp32, linux, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #33782: Size comparison from 88ebdf7 to 3080f08 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33782: Size comparison from 88ebdf7 to b094a31 Full report (4 builds for mbed, nrfconnect)
|
bzbarsky-apple
approved these changes
Jun 10, 2024
Alami-Amine
pushed a commit
to Alami-Amine/connectedhomeip
that referenced
this pull request
Jun 12, 2024
…LV (project-chip#33782) Allow CommandSender request to be built using DataModel::EncodableToTLV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new AddRequestData API so that clients don't need to call raw CommandSender APIs, and we can move towards removing access to TLVWriter.
The newly AddRequestData does bypass check that time invoke does in fact provide a timeout, the reality is that things outside of SDK heavily use the raw CommandSender APIs (PrepareCommand/FinishCommand) to build their own requests bypassing this check already. We still allow clients to call the older API for building the request.