KVS: Add error check for offset size (#9954)

rgoliver · pull[bot] · commit 1282766836cd · 2021-10-29T13:56:04.000Z
Check the offset size isn't bigger then the read size and return
error.
diff --git a/src/platform/Linux/KeyValueStoreManagerImpl.cpp b/src/platform/Linux/KeyValueStoreManagerImpl.cpp
@@ -56,6 +56,10 @@ CHIP_ERROR KeyValueStoreManagerImpl::_Get(const char * key, void * value, size_t
     {
         return err;
     }
+    else if (offset_bytes > read_size)
+    {
+        return CHIP_ERROR_INVALID_ARGUMENT;
+    }
 
     Platform::ScopedMemoryBuffer<uint8_t> buf;
     VerifyOrReturnError(buf.Alloc(read_size), CHIP_ERROR_NO_MEMORY);

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,10 @@ CHIP_ERROR KeyValueStoreManagerImpl::_Get(const char * key, void * value, size_t`
`56`	`56`	`{`
`57`	`57`	`return err;`
`58`	`58`	`}`
	`59`	`+ else if (offset_bytes > read_size)`
	`60`	`+ {`
	`61`	`+ return CHIP_ERROR_INVALID_ARGUMENT;`
	`62`	`+ }`
`59`	`63`
`60`	`64`	`Platform::ScopedMemoryBuffer<uint8_t> buf;`
`61`	`65`	`VerifyOrReturnError(buf.Alloc(read_size), CHIP_ERROR_NO_MEMORY);`