-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs][Wifi] Fixed LED0 issue by doing led init after lcd init. #29793
Merged
mergify
merged 3 commits into
project-chip:master
from
arun-silabs:bugfix/LED0_fix_for_all_apps
Oct 17, 2023
Merged
[Silabs][Wifi] Fixed LED0 issue by doing led init after lcd init. #29793
mergify
merged 3 commits into
project-chip:master
from
arun-silabs:bugfix/LED0_fix_for_all_apps
Oct 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arun-silabs
changed the title
Fixed LED0 issue by doing led init after lcd init.
[Silabs][Wifi] Fixed LED0 issue by doing led init after lcd init.
Oct 16, 2023
jepenven-silabs
approved these changes
Oct 16, 2023
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
October 16, 2023 15:28
pullapprove
bot
requested review from
mlepage-google,
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
robszewczyk,
saurabhst,
sharadb-amazon,
tcarmelveilleux,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
October 16, 2023 15:28
jmartinez-silabs
approved these changes
Oct 16, 2023
PR #29793: Size comparison from ed30384 to 17b8166 Decreases (9 builds for esp32, linux, nrfconnect, psoc6, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 16, 2023
PR #29793: Size comparison from 73b400d to 7afbeef Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…oject-chip#29793) * Fixed LED0 issue by doing led init after lcd init. * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : LED0 is not working in all apps.
Fix : Calling LED init after LCD init so that LED configurations are reflected in application.
Note : This is a temporary fix from our end, permanent fix has to come from wifi-sdk platform team.