Skip to content

Commit 1550932

Browse files
bzbarsky-applepull[bot]
authored andcommitted
Increase the test waits for timed interaction tests. (#12558)
The tests are failing intermittently because the client starts the wait when it _sends_ the message and the server starts its timer when it _receives_ the message. So if the message takes >5ms to be delivered initially, the test ends up with an unexpectedly successful command. The right fix for this would be for the client to start its delay when it receives the status response, but that requires more hooks into the IM state machine than we have (and probably than we want). For now, just increase the timeout used by the client to make it very unlikely that that much time passes before the timer on the server expires.
1 parent 89cbcd9 commit 1550932

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/app/tests/suites/TestClusterComplexTypes.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ tests:
6363
timedInteractionTimeoutMs: 1
6464
# Try to ensure that we are unresponsive for long enough that the timeout
6565
# expires.
66-
busyWaitMs: 5
66+
busyWaitMs: 100
6767
response:
6868
error: UNSUPPORTED_ACCESS
6969

@@ -81,6 +81,6 @@ tests:
8181
timedInteractionTimeoutMs: 1
8282
# Try to ensure that we are unresponsive for long enough that the timeout
8383
# expires.
84-
busyWaitMs: 5
84+
busyWaitMs: 100
8585
response:
8686
error: UNSUPPORTED_ACCESS

zzz_generated/chip-tool/zap-generated/test/Commands.h

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)