-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chiptool.py] Add show_adapter_logs option to chiptool.py #28258
Merged
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:ChipToolPy_ShowAdapterLogs
Jul 26, 2023
Merged
[chiptool.py] Add show_adapter_logs option to chiptool.py #28258
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:ChipToolPy_ShowAdapterLogs
Jul 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
July 25, 2023 07:48
pullapprove
bot
requested review from
woody-apple,
younghak-hwang and
yufengwangca
July 25, 2023 07:49
vivien-apple
force-pushed
the
ChipToolPy_ShowAdapterLogs
branch
from
July 25, 2023 07:49
9f97df5
to
f3ddd28
Compare
vivien-apple
changed the title
Chip tool py show adapter logs
[chiptool.py] Add show_adapter_logs option to chiptool.py
Jul 25, 2023
PR #28258: Size comparison from 3efdd36 to f3ddd28 Increases (11 builds for bl602, bl702, cyw30739, esp32, psoc6, telink)
Decreases (7 builds for bl602, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
ChipToolPy_ShowAdapterLogs
branch
from
July 25, 2023 09:57
f3ddd28
to
ceb3087
Compare
vivien-apple
force-pushed
the
ChipToolPy_ShowAdapterLogs
branch
from
July 25, 2023 09:59
ceb3087
to
f2dadff
Compare
PR #28258: Size comparison from 3efdd36 to f2dadff Increases (10 builds for bl602, bl702l, cyw30739, esp32, telink)
Decreases (10 builds for bl602, bl702, cc32xx, efr32, nrfconnect, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jul 25, 2023
bzbarsky-apple
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using
scripts/tests/yaml/chiptool.py
it may be useful to see all the logs from the underlying runtime (in this casechip-tool
).I have found myself hacking the code a few times to display those all the time. Instead of doing that this PR exposes the
show_adapter_logs
option tochip-tool.py
so it can be done without changing the code.