Log error on bad packets instead of silent return (#20126)

* Log error on bad packets instead of silent return * update message text * fix typo
project-chip · Aug 30, 2023 · 4427059 · 4427059
1 parent a2886c0
commit 4427059
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/transport/SessionManager.cpp b/src/transport/SessionManager.cpp
@@ -439,7 +439,12 @@ void SessionManager::OnMessageReceived(const PeerAddress & peerAddress, System::
     CHIP_TRACE_PREPARED_MESSAGE_RECEIVED(&peerAddress, &msg);
     PacketHeader packetHeader;
 
-    ReturnOnFailure(packetHeader.DecodeAndConsume(msg));
+    CHIP_ERROR err = packetHeader.DecodeAndConsume(msg);
+    if (err != CHIP_NO_ERROR)
+    {
+        ChipLogError(Inet, "Failed to decode packet header: %" CHIP_ERROR_FORMAT, err.Format());
+        return;
+    }
 
     if (packetHeader.IsEncrypted())
     {