Remove Deleted ConcentrationMeasurement Clusters
#28053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis and
gjc13
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
Damian-Nordic
approved these changes
Jul 19, 2023
woody-apple
approved these changes
Jul 19, 2023
p0fi
changed the title
ConcentrationMeasurement] Remove Deleted ClustersConcentrationMeasurement Clusters
p0fi
approved these changes
Jul 19, 2023
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Jul 21, 2023
* Remove unused clusters from XML * Regenerating codegen * Removing duplicate PICS * Removing generated files that are no longer generated * Remove clusters from ZAP's list * Updated controller zap file * Removed deleted clusters from import list * Restyled by autopep8 * Restyled by isort * Fixing formatting on python multi-line list * Restyled by isort * Fixing formatting on python multi-line list --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following discussion on https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7234, the previously provisional clusters will be removed from the Spec.
This amounts to:
This PR removes them from the SDK.
Links
Fixes #27662