Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Previously Provisionally Aliased Concentration Measurement Clusters From the SDK #27662

Closed
mhazley opened this issue Jul 6, 2023 · 2 comments · Fixed by #28053
Closed
Assignees
Labels
app-clusters Application cluster work Spec XML align SDK XML does not match the spec (including naming, etc) spec Mismatch between spec and implementation v1.2
Milestone

Comments

@mhazley
Copy link
Contributor

mhazley commented Jul 6, 2023

Description

Following discussion on https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7234, the previously provisional clusters will be removed from the Spec, so this issue is to ensure they are removed from the SDK.

This amounts to:

  • Ethylene,
  • Ethylene Oxide,
  • Hydrogen,
  • Hydrogen Sulfide,
  • Nitric Oxide,
  • Oxygen,
  • Sulfur Dioxide,
  • Dissolved Oxygen,
  • Bromate,
  • Chloramines,
  • Chlorine,
  • Fecal coliform & E. Coli,
  • Fluoride,
  • Haloacetic Acids,
  • Total Trihalomethanes,
  • Total Coliform Bacteria,
  • Turbidity,
  • Copper,
  • Lead,
  • Manganese,
  • Sulfate,
  • Bromodichloromethane,
  • Bromoform,
  • Chlorodibromomethane,
  • Chloroform
  • Sodium
@mhazley mhazley added app-clusters Application cluster work v1.2 labels Jul 6, 2023
@mhazley mhazley added this to the 1.2 milestone Jul 6, 2023
@mhazley mhazley self-assigned this Jul 6, 2023
@woody-apple woody-apple added the spec Mismatch between spec and implementation label Jul 6, 2023
@woody-apple
Copy link
Contributor

@mhazley Trying to move folks to using issue templates, should we propose a new template so we can auto add labels, and such?

@bzbarsky-apple bzbarsky-apple added the Spec XML align SDK XML does not match the spec (including naming, etc) label Jul 6, 2023
@mhazley
Copy link
Contributor Author

mhazley commented Jul 7, 2023

@woody-apple yes, apologies. Grab me on slack when you're online.

This was referenced Jul 7, 2023
This was referenced Jul 7, 2023
@p0fi p0fi changed the title Remove previously provisionally aliased concentration measurement clusters from the SDK Remove Previously Provisionally Aliased Concentration Measurement Clusters From the SDK Jul 7, 2023
@mhazley mhazley moved this from Todo to In Review in [Enhancements] Spec/XML Alignment Jul 19, 2023
@mhazley mhazley moved this from Todo to In Review in [Feature] Air Quality Jul 19, 2023
@mergify mergify bot closed this as completed in #28053 Jul 20, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in [Feature] Air Quality Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-clusters Application cluster work Spec XML align SDK XML does not match the spec (including naming, etc) spec Mismatch between spec and implementation v1.2
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants