Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherrypick] Improve lifetime management of CASESession async work helper. (#27659) #27835

Closed

Conversation

shubhamdp
Copy link
Contributor

Cherry picking 8c288b4 (PR #27659)

…t-chip#27659)

* Improve lifetime management of CASESession async work helper.

As things stood, there were some codepaths (currently not really reached; it
would require scheduling of SendSigma3c to fail and then for someone to
InvokeBackgroundWorkWatchdog on the CASESession) where we could destroy the
object while we were working with references to its members.

Fixes project-chip#27541

* Address review comment.
@mergify
Copy link

mergify bot commented Jul 10, 2023

⚠️ The sha of the head commit of this PR conflicts with #27837. Mergify cannot evaluate rules on this PR. ⚠️

@shubhamdp shubhamdp deleted the cherrypick-27659 branch July 11, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants