Improve lifetime management of CASESession async work helper. #27659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As things stood, there were some codepaths (currently not really reached; it would require scheduling of SendSigma3c to fail and then for someone to InvokeBackgroundWorkWatchdog on the CASESession) where we could destroy the object while we were working with references to its members. Fixes project-chip#27541
bzbarsky-apple
force-pushed
the
CASE-ownership-clearer
branch
from
082ed1d to
0d9b285
Compare
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
pullapprove
bot
requested review from
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
|
PR #27659: Size comparison from 0d1f9c3 to 0d9b285 Increases (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for psoc6)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jul 6, 2023
bzbarsky-apple
force-pushed
the
CASE-ownership-clearer
branch
from
b109997 to
4bff921
Compare
bzbarsky-apple
force-pushed
the
CASE-ownership-clearer
branch
from
4bff921 to
2b74f96
Compare
|
PR #27659: Size comparison from 53e06c7 to 2b74f96 Increases (56 builds for bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (9 builds for bl602, bl702, bl702l, psoc6)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
shubhamdp
pushed a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Jul 10, 2023
…t-chip#27659) * Improve lifetime management of CASESession async work helper. As things stood, there were some codepaths (currently not really reached; it would require scheduling of SendSigma3c to fail and then for someone to InvokeBackgroundWorkWatchdog on the CASESession) where we could destroy the object while we were working with references to its members. Fixes project-chip#27541 * Address review comment.
This was referenced Jul 10, 2023
dhrishi
pushed a commit
that referenced
this pull request
Jul 11, 2023
#27837) * Improve lifetime management of CASESession async work helper. As things stood, there were some codepaths (currently not really reached; it would require scheduling of SendSigma3c to fail and then for someone to InvokeBackgroundWorkWatchdog on the CASESession) where we could destroy the object while we were working with references to its members. Fixes #27541 * Address review comment. Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As things stood, there were some codepaths (currently not really reached; it would require scheduling of SendSigma3c to fail and then for someone to InvokeBackgroundWorkWatchdog on the CASESession) where we could destroy the object while we were working with references to its members.
Fixes #27541