Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enable TAPI_VERIFY_MODE=Pedantic." #27428

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

woody-apple
Copy link
Contributor

Reverts #27424

Testing to see if this resolves #27427

@woody-apple
Copy link
Contributor Author

woody-apple commented Jun 23, 2023

Hopefully #27426 fixes this (but doesn't look like it at first glance)

@github-actions
Copy link

github-actions bot commented Jun 23, 2023

PR #27428: Size comparison from 23644a5 to 8ddfac7

Decreases (2 builds for bl602, bl702)
platform target config section 23644a5 8ddfac7 change % change
bl602 lighting-app bl602+rpc .text 1083056 1083054 -2 -0.0
bl702 lighting-app bl702+rpc .debug_info 46797390 46797389 -1 -0.0
.text 1019936 1019934 -2 -0.0
Full report (12 builds for bl602, bl702, linux, mbed, nrfconnect, qpg)
platform target config section 23644a5 8ddfac7 change % change
bl602 lighting-app bl602 (read/write) 1366494 1366494 0 0.0
.bss 83942 83942 0 0.0
.data 9608 9608 0 0.0
.text 1050916 1050916 0 0.0
bl602+rpc (read/write) 1414178 1414178 0 0.0
.bss 91990 91990 0 0.0
.data 10008 10008 0 0.0
.text 1083056 1083054 -2 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1175211 1175211 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 77781 77781 0 0.0
.bss_psram 24656 24656 0 0.0
.comment 48 48 0 0.0
.data 3592 3592 0 0.0
.debug_abbrev 1545845 1545845 0 0.0
.debug_aranges 149976 149976 0 0.0
.debug_frame 552036 552036 0 0.0
.debug_info 41613026 41613026 0 0.0
.debug_line 5583553 5583553 0 0.0
.debug_loc 3800882 3800882 0 0.0
.debug_ranges 395256 395256 0 0.0
.debug_str 4350605 4350605 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 105408 105408 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 582415 582415 0 0.0
.symtab 174192 174192 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
946054 946054 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1273323 1273323 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 85829 85829 0 0.0
.bss_psram 25072 25072 0 0.0
.comment 48 48 0 0.0
.data 4144 4144 0 0.0
.debug_abbrev 1711094 1711094 0 0.0
.debug_aranges 158448 158448 0 0.0
.debug_frame 580668 580668 0 0.0
.debug_info 46797390 46797389 -1 -0.0
.debug_line 6009861 6009861 0 0.0
.debug_loc 4006153 4006153 0 0.0
.debug_ranges 420928 420928 0 0.0
.debug_str 4779233 4779233 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120048 120048 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 644984 644984 0 0.0
.symtab 192992 192992 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1019936 1019934 -2 -0.0
linux chip-tool-ipv6only arm64 (read only) 15740096 15740096 0 0.0
(read/write) 816760 816760 0 0.0
.bss 34392 34392 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 756864 756864 0 0.0
.dynamic 560 560 0 0.0
.got 17232 17232 0 0.0
.init 24 24 0 0.0
.init_array 240 240 0 0.0
.rodata 672552 672552 0 0.0
.text 13135300 13135300 0 0.0
thermostat-no-ble arm64 (read only) 2615868 2615868 0 0.0
(read/write) 143128 143128 0 0.0
.bss 52360 52360 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 560 560 0 0.0
.got 5520 5520 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 130496 130496 0 0.0
.text 2219508 2219508 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2499088 2499088 0 0.0
.bss 216312 216312 0 0.0
.data 5144 5144 0 0.0
.text 1461772 1461772 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1213484 1213484 0 0.0
bss 155045 155045 0 0.0
rodata 138144 138144 0 0.0
text 841152 841152 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1316260 1316260 0 0.0
bss 138371 138371 0 0.0
rodata 133432 133432 0 0.0
text 753748 753748 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1151148 1151148 0 0.0
bss 153541 153541 0 0.0
rodata 111408 111408 0 0.0
text 807160 807160 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1172376 1172376 0 0.0
.bss 99960 99960 0 0.0
.data 788 788 0 0.0
.text 619216 619216 0 0.0
lock-app qpg6105+debug (read/write) 1129992 1129992 0 0.0
.bss 94816 94816 0 0.0
.data 792 792 0 0.0
.text 576836 576836 0 0.0

@bzbarsky-apple
Copy link
Contributor

Hopefully #27426 fixes this

It won't. Unrelated issue.

@woody-apple woody-apple merged commit 70afb7d into master Jun 23, 2023
@woody-apple woody-apple deleted the revert-27424-pedantic-TAPI branch June 23, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Build] Darwin build failed
2 participants