-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TSan failure on Darwin. #27426
Merged
Merged
Fix TSan failure on Darwin. #27426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mlepage-google
June 23, 2023 03:01
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple and
xylophone21
June 23, 2023 03:01
jtung-apple
approved these changes
Jun 23, 2023
Fast-tracking platform-specific change with platform owner review. |
PR #27426: Size comparison from 23644a5 to 2f0985c Increases (2 builds for cc32xx, psoc6)
Decreases (7 builds for bl602, bl702, esp32, nrfconnect, psoc6)
Full report (30 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
woody-apple
approved these changes
Jun 23, 2023
Looks like this hit: #27427 |
woody-apple
force-pushed
the
fix-tsan-fail
branch
from
June 23, 2023 04:59
2f0985c
to
e8c4c20
Compare
PR #27426: Size comparison from 70afb7d to e8c4c20 Increases (5 builds for esp32, k32w, nrfconnect, psoc6)
Decreases (1 build for cc32xx)
Full report (30 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
We could end up logging after Matter stack shutdown and when a different stack was being configured, which would cause a thread race. Also fixes a situation where we could try to resubscribe to things after our MTRDevice has been invalidated. Fixes project-chip#27425
bzbarsky-apple
force-pushed
the
fix-tsan-fail
branch
from
June 23, 2023 06:35
e8c4c20
to
a0f8623
Compare
PR #27426: Size comparison from 875c577 to a0f8623 Increases (8 builds for bl702, cc32xx, esp32, psoc6, telink)
Decreases (12 builds for bl602, bl702, esp32, nrfconnect, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could end up logging after Matter stack shutdown and when a different stack was being configured, which would cause a thread race.
Also fixes a situation where we could try to resubscribe to things after our MTRDevice has been invalidated.
Fixes #27425