-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_idl] Add min_value/max_value/min_length supports when parsing… #27314
Merged
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:MatterIdlParser_AddMinValueMaxValueMinLength
Jun 20, 2023
Merged
[matter_idl] Add min_value/max_value/min_length supports when parsing… #27314
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:MatterIdlParser_AddMinValueMaxValueMinLength
Jun 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no and
ksperling-apple
June 19, 2023 09:19
pullapprove
bot
requested review from
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
June 19, 2023 09:19
PR #27314: Size comparison from f5c4621 to 23c12ed Increases (17 builds for bl602, bl702, cyw30739, nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for cc32xx, esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Jun 19, 2023
woody-apple
approved these changes
Jun 20, 2023
vivien-apple
force-pushed
the
MatterIdlParser_AddMinValueMaxValueMinLength
branch
from
June 20, 2023 09:34
23c12ed
to
0b5771f
Compare
PR #27314: Size comparison from 9a5b909 to 0b5771f Increases (6 builds for bl602, bl702, psoc6, qpg, telink)
Decreases (10 builds for bl602, esp32, nrfconnect, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Jun 20, 2023
return sized_type.is_signed | ||
|
||
|
||
def GetDataTypeSizeInBits(data_type: DataType) -> int: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return type is incorrect here: returning none implies Optional[int]
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jun 20, 2023
…value of GetDataTypeSizeInBits from int to Optional[int]
andy31415
pushed a commit
that referenced
this pull request
Jun 20, 2023
…DataTypeSizeInBits from int to Optional[int] (#27357)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Using
matter_idl
XML parser there is no mechanism to retrieve themin
,max
,minLength
attribute specifiers.