[BUG] Linux Test Harness Certification Declaration encoding error #26812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original payload:Updated payloadAfter removing the extra byte |
pullapprove
bot
requested review from
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
ksperling-apple
bzbarsky-apple
approved these changes
May 24, 2023
yufengwangca
approved these changes
May 25, 2023
jmartinez-silabs
approved these changes
May 25, 2023
|
PR #26812: Size comparison from 5d459ce to 6345eed Increases (1 build for nrfconnect)
Decreases (7 builds for bl602, bl702, efr32, esp32, linux, nrfconnect)
Full report (34 builds for bl602, bl702, cc32xx, efr32, esp32, k32w, linux, mbed, nrfconnect, qpg)
|
|
PR #26812: Size comparison from 9f43988 to c55139b Increases (12 builds for bl602, bl702, cyw30739, psoc6, telink)
Decreases (10 builds for efr32, esp32, linux, nrfconnect, qpg, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
May 25, 2023
andy31415
reviewed
May 25, 2023
|
PR #26812: Size comparison from a0fe129 to 084b17d Increases (4 builds for bl602, cc32xx, esp32)
Decreases (7 builds for bl702, cyw30739, efr32, esp32, linux, psoc6)
Full report (50 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
During internal QA testing related to commissioning the [chip-certification-tool (TH v 2.8.1 - 1.1 Release Build)](https://github.com/CHIP-Specifications/chip-certification-tool/releases/tag/v2.8.1-official) a failure occurred while attempting to verify the Certification Declaration payload using the latest releases of Bouncy Castle. > **11.17.5.5. Attestation Information** > > The certification_declaration field SHALL be the DER-encoded octet string representation of a CMS-formatted certification declaration, as described in Section 6.3, “Certification Declaration”. The [specific exception](https://github.com/bcgit/bc-java/blob/876bd0cf02811282707ddd38e4f0f9212a9f4d1f/core/src/main/java/org/bouncycastle/asn1/ASN1Primitive.java#L46-L49) is thrown while attempting to decode the DER-encoded octet string, due to unexpected bytes remaining after attempting to decode the packet. After extracting the Certification Declaration payload and attempting to perform manual validation using openssl, it was double-confirmed that the payload contained an encoding error. Finally, the Certification Declaration payload was confirmed to have an extra byte originating from the hardcoded test payload. After the extra byte is removed, the payload decoding is successful.
|
PR #26812: Size comparison from 76ccf9d to f2642c0 Increases (7 builds for bl602, bl702, psoc6, qpg, telink)
Decreases (13 builds for cc13x2_26x2, cc32xx, cyw30739, efr32, linux, psoc6, telink)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
requested changes
May 25, 2023
|
PR #26812: Size comparison from 76ccf9d to e6c9e8a Increases (7 builds for bl602, psoc6, telink)
Decreases (17 builds for bl702, cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, telink)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
May 25, 2023
|
PR #26812: Size comparison from 76ccf9d to 322c4ac Increases (23 builds for bl602, bl702, linux, psoc6, qpg, telink)
Decreases (12 builds for bl702, cyw30739, efr32, esp32, linux, telink)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
swan-amazon
deleted the
linux-test-harness-certification-declaration-encoding-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26811
During internal QA testing related to commissioning the chip-certification-tool (TH v 2.8.1 - 1.1 Release Build) a failure occurred while attempting to verify the Certification Declaration payload using the latest releases of Bouncy Castle.
The specific exception is thrown while attempting to decode the DER-encoded octet string, due to unexpected bytes remaining after attempting to decode the packet. After extracting the Certification Declaration payload and attempting to perform manual validation using openssl, it was double-confirmed that the payload contained an encoding error.
Finally, the Certification Declaration payload was confirmed to have an extra byte originating from the hardcoded test payload. After the extra byte is removed, the payload decoding is successful.