-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[BUG] Linux Test Harness Certification Declaration encoding error (#2…
…6812) * [BUG] Linux Test Harness Certification Declaration encoding error During internal QA testing related to commissioning the [chip-certification-tool (TH v 2.8.1 - 1.1 Release Build)](https://github.com/CHIP-Specifications/chip-certification-tool/releases/tag/v2.8.1-official) a failure occurred while attempting to verify the Certification Declaration payload using the latest releases of Bouncy Castle. > **11.17.5.5. Attestation Information** > > The certification_declaration field SHALL be the DER-encoded octet string representation of a CMS-formatted certification declaration, as described in Section 6.3, “Certification Declaration”. The [specific exception](https://github.com/bcgit/bc-java/blob/876bd0cf02811282707ddd38e4f0f9212a9f4d1f/core/src/main/java/org/bouncycastle/asn1/ASN1Primitive.java#L46-L49) is thrown while attempting to decode the DER-encoded octet string, due to unexpected bytes remaining after attempting to decode the packet. After extracting the Certification Declaration payload and attempting to perform manual validation using openssl, it was double-confirmed that the payload contained an encoding error. Finally, the Certification Declaration payload was confirmed to have an extra byte originating from the hardcoded test payload. After the extra byte is removed, the payload decoding is successful. * Reverted changes to generated files * Switched from sizeof to ArraySize.
- Loading branch information
1 parent
37003a3
commit caf29e5
Showing
18 changed files
with
398 additions
and
368 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.