[Tizen] Implement DiagnosticDataProvider interface #26060

hyunuktak · 2023-04-12T04:36:47Z

Problem

DiagnosticDataProvider is not implemented on Tizen platform.

Change overview

Added mandatory attributes for Diagnostic cluster on Tizen.

Testing

chip-tool example.

github-actions · 2023-04-12T04:52:33Z

PR #26060: Size comparison from d85124e to 13f3f05

Increases (1 build for cc32xx)

platform	target	config	section	`d85124e`	`13f3f05`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20303347	20303348	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`d85124e`	`13f3f05`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	642953	642953	0
			(read/write)	203848	203848	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197248	197248	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	933129	933129	0
			.debug_aranges	87616	87616	0
			.debug_frame	301352	301352	0
			.debug_info	20303347	20303348	1
			.debug_line	2679969	2679969	0
			.debug_loc	2824782	2824782	0
			.debug_ranges	286208	286208	0
			.debug_str	`3039567`	`3039567`	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	104353	104353	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	377533	377533	0
			.symtab	256800	256800	0
			.text	536480	536480	0

src/platform/Tizen/ConfigurationManagerImpl.cpp

src/platform/Tizen/ConnectivityManagerImpl.h

src/platform/Tizen/ConnectivityUtils.cpp

src/platform/Tizen/DiagnosticDataProviderImpl.cpp

src/platform/Tizen/ConnectivityManagerImpl.cpp

src/platform/Tizen/DiagnosticDataProviderImpl.cpp

github-actions · 2023-04-13T06:39:16Z

PR #26060: Size comparison from 76eaffc to 61d50db

Increases (1 build for cc32xx)

platform	target	config	section	`76eaffc`	`61d50db`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20326060	20326061	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`76eaffc`	`61d50db`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	643081	643081	0
			(read/write)	203848	203848	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197248	197248	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	933224	933224	0
			.debug_aranges	87760	87760	0
			.debug_frame	302028	302028	0
			.debug_info	20326060	20326061	1
			.debug_line	`2687403`	`2687403`	0
			.debug_loc	2838361	2838361	0
			.debug_ranges	288040	288040	0
			.debug_str	3042379	3042379	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	104393	104393	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	377626	377626	0
			.symtab	256832	256832	0
			.text	536568	536568	0

src/platform/Tizen/WiFiManager.cpp

src/platform/Tizen/ConnectivityManagerImpl.cpp

github-actions · 2023-04-14T00:57:02Z

PR #26060: Size comparison from 5568b70 to 4fcbb0e

Full report (3 builds for cc32xx, qpg)

platform	target	config	section	`5568b70`	`4fcbb0e`
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	643081	643081
			(read/write)	203848	203848
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197248	197248
			.comment	194	194
			.data	1480	1480
			.debug_abbrev	933224	933224
			.debug_aranges	87760	87760
			.debug_frame	302028	302028
			.debug_info	20326062	20326062
			.debug_line	`2687403`	`2687403`
			.debug_loc	2838361	2838361
			.debug_ranges	288040	288040
			.debug_str	3042379	3042379
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	104393	104393
			.shstrtab	232	232
			.stab	204	204
			.stabstr	441	441
			.stack	2048	2048
			.strtab	377626	377626
			.symtab	256832	256832
			.text	536568	536568
qpg	lighting-app	qpg6105+debug	(read/write)	1154828	1154828
			.bss	97404	97404
			.data	836	836
			.text	601924	601924
	lock-app	qpg6105+debug	(read/write)	1124908	1124908
			.bss	92548	92548
			.data	840	840
			.text	572008	572008

src/platform/Tizen/ConnectivityManagerImpl.cpp

github-actions · 2023-04-20T01:53:51Z

PR #26060: Size comparison from e2341d8 to f7e8e5f

Increases (1 build for nrfconnect)

platform	target	config	section	`e2341d8`	`f7e8e5f`	change	% change
nrfconnect	all-clusters-app	nrf7002dk_nrf5340_cpuapp	text	775784	775788	4	0.0

Full report (4 builds for mbed, nrfconnect)

platform	target	config	section	`e2341d8`	`f7e8e5f`	change
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0
			(read/write)	`2466336`	`2466336`	0
			.bss	215960	215960	0
			.data	5888	5888	0
			.text	1428980	1428980	0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read only)	4	4	0
			(read/write)	`1173892`	`1173892`	0
			bss	155557	155557	0
			rodata	132740	132740	0
			text	804832	804832	0
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read only)	4	4	0
			(read/write)	1119140	1119140	0
			bss	154713	154713	0
			rodata	109556	109556	0
			text	774228	774228	0
	all-clusters-app	nrf7002dk_nrf5340_cpuapp	(read only)	4	4	0
			(read/write)	1433952	1433952	0
			bss	135297	135297	0
			rodata	228784	228784	0
			text	775784	775788	4

Signed-off-by: hyunuk.tak <[email protected]>

github-actions · 2023-04-21T01:31:49Z

PR #26060: Size comparison from 1177ce8 to 2ba1e8a

Increases (2 builds for bl702)

platform	target	config	section	`1177ce8`	`2ba1e8a`	change
bl702	lighting-app	bl702	.debug_info	40745661	40745662	1
			.text	959516	959518	2
		bl702+rpc	.debug_info	45237657	45237658	1
			.text	1032438	1032440	2

Decreases (2 builds for cc32xx, qpg)

platform	target	config	section	`1177ce8`	`2ba1e8a`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20330829	20330828	-1	-0.0
qpg	lighting-app	qpg6105+debug	(read/write)	1166568	1166560	-8	-0.0
			.text	613668	613660	-8	-0.0

Full report (11 builds for bl602, bl702, cc32xx, mbed, nrfconnect, qpg)

platform	target	config	section	`1177ce8`	`2ba1e8a`	change	% change
bl602	lighting-app	bl602	(read/write)	1350526	1350526	0	0.0
			.bss	87862	87862	0	0.0
			.data	9648	9648	0	0.0
			.text	1031686	1031686	0	0.0
		bl602+rpc	(read/write)	1396514	1396514	0	0.0
			.bss	95910	95910	0	0.0
			.data	10040	10040	0	0.0
			.text	1062772	1062772	0	0.0
bl702	lighting-app	bl702		0	0	0	0.0
			(read only)	3358	3358	0	0.0
			(read/write)	`1179543`	`1179543`	0	0.0
			.bleromro	6342	6342	0	0.0
			.bleromrw	124	124	0	0.0
			.boot2	328	328	0	0.0
			.bss	67577	67577	0	0.0
			.bss_psram	24368	24368	0	0.0
			.comment	48	48	0	0.0
			.data	3952	3952	0	0.0
			.debug_abbrev	1549370	1549370	0	0.0
			.debug_aranges	134672	134672	0	0.0
			.debug_frame	495172	495172	0	0.0
			.debug_info	40745661	40745662	1	0.0
			.debug_line	5309220	5309220	0	0.0
			.debug_loc	3444130	3444130	0	0.0
			.debug_ranges	376400	376400	0	0.0
			.debug_str	3596774	3596774	0	0.0
			.hbn	536	536	0	0.0
			.hbn_noinit	260	260	0	0.0
			.init	342	342	0	0.0
			.init_array	140	140	0	0.0
			.psram	0	0	0	0.0
			.riscv.attributes	47	47	0	0.0
			.rodata	106048	106048	0	0.0
			.rsvd	4	4	0	0.0
			.sha_ocram	72	72	0	0.0
			.shstrtab	304	304	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	573725	573725	0	0.0
			.symtab	174288	174288	0	0.0
			.tcm_data	28	28	0	0.0
			.tcmcode	3358	3358	0	0.0
			.text	959516	959518	2	0.0
		bl702+rpc		0	0	0	0.0
			(read only)	3358	3358	0	0.0
			(read/write)	1267643	1267643	0	0.0
			.bleromro	6342	6342	0	0.0
			.bleromrw	124	124	0	0.0
			.boot2	328	328	0	0.0
			.bss	75609	75609	0	0.0
			.bss_psram	24768	24768	0	0.0
			.comment	48	48	0	0.0
			.data	4504	4504	0	0.0
			.debug_abbrev	1699986	1699986	0	0.0
			.debug_aranges	142880	142880	0	0.0
			.debug_frame	523004	523004	0	0.0
			.debug_info	45237657	45237658	1	0.0
			.debug_line	5716367	5716367	0	0.0
			.debug_loc	3644588	3644588	0	0.0
			.debug_ranges	401376	401376	0	0.0
			.debug_str	4020996	4020996	0	0.0
			.hbn	536	536	0	0.0
			.hbn_noinit	260	260	0	0.0
			.init	342	342	0	0.0
			.init_array	156	156	0	0.0
			.psram	0	0	0	0.0
			.riscv.attributes	47	47	0	0.0
			.rodata	119904	119904	0	0.0
			.rsvd	4	4	0	0.0
			.sha_ocram	72	72	0	0.0
			.shstrtab	304	304	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	634727	634727	0	0.0
			.symtab	192688	192688	0	0.0
			.tcm_data	28	28	0	0.0
			.tcmcode	3358	3358	0	0.0
			.text	1032438	1032440	2	0.0
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	643249	643249	0	0.0
			(read/write)	203848	203848	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197248	197248	0	0.0
			.comment	194	194	0	0.0
			.data	1480	1480	0	0.0
			.debug_abbrev	933224	933224	0	0.0
			.debug_aranges	87792	87792	0	0.0
			.debug_frame	302140	302140	0	0.0
			.debug_info	20330829	20330828	-1	-0.0
			.debug_line	`2687904`	`2687904`	0	0.0
			.debug_loc	`2838960`	`2838960`	0	0.0
			.debug_ranges	288072	288072	0	0.0
			.debug_str	3042335	3042335	0	0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	104401	104401	0	0.0
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	377963	377963	0	0.0
			.symtab	256976	256976	0	0.0
			.text	536728	536728	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2466336`	`2466336`	0	0.0
			.bss	215960	215960	0	0.0
			.data	5888	5888	0	0.0
			.text	1428980	1428980	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read only)	4	4	0	0.0
			(read/write)	`1173892`	`1173892`	0	0.0
			bss	155557	155557	0	0.0
			rodata	132740	132740	0	0.0
			text	804836	804836	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read only)	4	4	0	0.0
			(read/write)	1119140	1119140	0	0.0
			bss	154713	154713	0	0.0
			rodata	109556	109556	0	0.0
			text	774228	774228	0	0.0
	all-clusters-app	nrf7002dk_nrf5340_cpuapp	(read only)	4	4	0	0.0
			(read/write)	1433952	1433952	0	0.0
			bss	135297	135297	0	0.0
			rodata	228784	228784	0	0.0
			text	775788	775788	0	0.0
qpg	lighting-app	qpg6105+debug	(read/write)	1166568	1166560	-8	-0.0
			.bss	99308	99308	0	0.0
			.data	856	856	0	0.0
			.text	613668	613660	-8	-0.0
	lock-app	qpg6105+debug	(read/write)	1136688	1136688	0	0.0
			.bss	94452	94452	0	0.0
			.data	860	860	0	0.0
			.text	583784	583784	0	0.0

github-actions bot added platform tizen For Tizen platform labels Apr 12, 2023

pullapprove bot added the review - pending label Apr 12, 2023

arkq requested changes Apr 12, 2023

View reviewed changes

bzbarsky-apple reviewed Apr 12, 2023

View reviewed changes

github-actions bot added the linux label Apr 13, 2023

hyunuktak force-pushed the ddp-dev branch from bda2f1e to 61d50db Compare April 13, 2023 06:27

bzbarsky-apple reviewed Apr 13, 2023

View reviewed changes

src/platform/Tizen/WiFiManager.cpp Show resolved Hide resolved

src/platform/Tizen/ConnectivityManagerImpl.cpp Outdated Show resolved Hide resolved

hyunuktak force-pushed the ddp-dev branch from 61d50db to 4fcbb0e Compare April 14, 2023 00:34

bzbarsky-apple reviewed Apr 14, 2023

View reviewed changes

src/platform/Tizen/ConnectivityManagerImpl.cpp Outdated Show resolved Hide resolved

bzbarsky-apple reviewed Apr 19, 2023

View reviewed changes

src/platform/Tizen/ConnectivityManagerImpl.cpp Outdated Show resolved Hide resolved

hyunuktak force-pushed the ddp-dev branch from 165e0eb to 1aac5f1 Compare April 19, 2023 00:50

bzbarsky-apple approved these changes Apr 19, 2023

View reviewed changes

arkq approved these changes Apr 19, 2023

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Apr 19, 2023

hyunuktak force-pushed the ddp-dev branch from 1aac5f1 to f7e8e5f Compare April 20, 2023 01:31

hyunuktak and others added 7 commits April 21, 2023 09:54

[Tizen] Implement DiagnosticDataProvider interface

1413605

Restyled by clang-format

0491cf3

Apply some comments

58ca56e

Allocate memory for the bssid to WiFiMgr

cebd53f

Signed-off-by: hyunuk.tak <[email protected]>

Change to MutableByteSpan. But leave it as not implementation now.

6a586fc

Restyled by clang-format

91c26a1

Copy into the caller provided buffer

2ba1e8a

hyunuktak force-pushed the ddp-dev branch from f7e8e5f to 2ba1e8a Compare April 21, 2023 00:59

andy31415 enabled auto-merge (squash) April 21, 2023 01:43

andy31415 merged commit f3f7ecd into project-chip:master Apr 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tizen] Implement DiagnosticDataProvider interface #26060

[Tizen] Implement DiagnosticDataProvider interface #26060

hyunuktak commented Apr 12, 2023

github-actions bot commented Apr 12, 2023

github-actions bot commented Apr 13, 2023

github-actions bot commented Apr 14, 2023

github-actions bot commented Apr 20, 2023

github-actions bot commented Apr 21, 2023

[Tizen] Implement DiagnosticDataProvider interface #26060

[Tizen] Implement DiagnosticDataProvider interface #26060

Conversation

hyunuktak commented Apr 12, 2023

Problem

Change overview

Testing

github-actions bot commented Apr 12, 2023

github-actions bot commented Apr 13, 2023

github-actions bot commented Apr 14, 2023

github-actions bot commented Apr 20, 2023

github-actions bot commented Apr 21, 2023