Copy into the caller provided buffer

Author: hyunuktak

src/platform/Tizen/ConnectivityManagerImpl.cpp

@@ -255,11 +255,15 @@ bool ConnectivityManagerImpl::IsWiFiManagementStarted()
 
 CHIP_ERROR ConnectivityManagerImpl::GetWiFiBssId(MutableByteSpan & value)
 {
+    constexpr size_t bssIdSize = 6;
+    VerifyOrReturnError(value.size() >= bssIdSize, CHIP_ERROR_BUFFER_TOO_SMALL);
+
     uint8_t * bssId = nullptr;
     CHIP_ERROR err  = Internal::WiFiMgr().GetBssId(bssId);
     ReturnErrorOnFailure(err);
 
-    value = MutableByteSpan(bssId, 6);
+    memcpy(value.data(), bssId, bssIdSize);
+    value.reduce_size(bssIdSize);
 
     return CHIP_NO_ERROR;
 }

src/platform/Tizen/DiagnosticDataProviderImpl.cpp

@@ -487,17 +487,10 @@ CHIP_ERROR DiagnosticDataProviderImpl::ResetEthNetworkDiagnosticsCounts()
 }
 
 #if CHIP_DEVICE_CONFIG_ENABLE_WIFI
-/*
 CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiBssId(MutableByteSpan & bssId)
 {
     return ConnectivityMgrImpl().GetWiFiBssId(bssId);
 }
-*/
-
-CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiBssId(ByteSpan & bssId)
-{
-    return CHIP_ERROR_NOT_IMPLEMENTED;
-}
 
 CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiSecurityType(app::Clusters::WiFiNetworkDiagnostics::SecurityTypeEnum & securityType)
 {

src/platform/Tizen/DiagnosticDataProviderImpl.h

@@ -68,13 +68,7 @@ class DiagnosticDataProviderImpl : public DiagnosticDataProvider
     CHIP_ERROR ResetEthNetworkDiagnosticsCounts() override;
 
 #if CHIP_DEVICE_CONFIG_ENABLE_WIFI
-    /*
-    CHIP_ERROR chip::DeviceLayer::DiagnosticDataProvider::GetWiFiBssId(ByteSpan & value)
-    The API signature is broken. it has to change from ByteSpan to MutableByteSpan.
-    After this is changed, it will be changed to next API and added.
     CHIP_ERROR GetWiFiBssId(MutableByteSpan & bssId) override;
-    */
-    CHIP_ERROR GetWiFiBssId(ByteSpan & bssId) override;
     CHIP_ERROR GetWiFiSecurityType(app::Clusters::WiFiNetworkDiagnostics::SecurityTypeEnum & securityType) override;
     CHIP_ERROR GetWiFiVersion(app::Clusters::WiFiNetworkDiagnostics::WiFiVersionEnum & wiFiVersion) override;
     CHIP_ERROR GetWiFiChannelNumber(uint16_t & channelNumber) override;