-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring python yaml test parser of octet string inline with what javascript codegen is doing #23670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old parsing had issue since str.encode for utf-8 character would be improperly convert. For example `\xff` would become `b'\xc3\xbf'` when we wanted it to be `b'\xff`. Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda and
mrjerryjohns
November 17, 2022 19:57
pullapprove
bot
requested review from
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
November 17, 2022 19:57
andy31415
reviewed
Nov 17, 2022
andy31415
reviewed
Nov 17, 2022
andy31415
reviewed
Nov 17, 2022
andy31415
reviewed
Nov 17, 2022
andy31415
reviewed
Nov 17, 2022
andy31415
approved these changes
Nov 17, 2022
PR #23670: Size comparison from b568009 to f707749 Increases (1 build for nrfconnect)
Decreases (2 builds for bl602, bl702)
Full report (9 builds for bl602, bl702, mbed, nrfconnect, qpg)
|
PR #23670: Size comparison from b568009 to be21caf Increases (5 builds for bl602, bl702, cc13x2_26x2, nrfconnect, telink)
Decreases (1 build for cc13x2_26x2)
Full report (37 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
PR #23670: Size comparison from b568009 to fc8e123 Increases (9 builds for bl702, esp32, nrfconnect, psoc6, telink)
Decreases (1 build for esp32)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
approved these changes
Nov 17, 2022
PR #23670: Size comparison from b568009 to 7d6bb83 Increases (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for cc13x2_26x2, esp32)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old parsing had issue since str.encode for utf-8 character would be improperly convert. For example
\xff
would becomeb'\xc3\xbf'
when we wanted it to beb'\xff
.Co-authored-by: Tennessee Carmel-Veilleux [email protected]
Tested inside chip-repl with the following commands (with all-cluster app running on separate terminal already commissioned):