Skip to content

Commit

Permalink
Address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
tehampson committed Nov 18, 2022
1 parent fc8e123 commit 7d6bb83
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/controller/python/chip/yaml/format_converter.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def convert_yaml_octet_string_to_bytes(s: str) -> bytes:

# Step 2: convert non-hex-prefixed to bytes
# TODO(#23669): This does not properly support utf8 octet strings. We mimic
# javascript codegen behavior. Behavior or javascript is:
# javascript codegen behavior. Behavior of javascript is:
# * Octet string character >= u+0200 errors out.
# * Any character greater than 0xFF has the upper bytes chopped off.
as_bytes = [ord(c) for c in s]
Expand Down

0 comments on commit 7d6bb83

Please sign in to comment.