Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Obsolete TODOs in the AddTrustedRootCertificate and AddNOC Commands #21060

Conversation

emargolis
Copy link
Contributor

Problem

Recently the spec was updated not to allow separate provisioning of Root and NOC certificates.
In the current implementation AddTrustedRootCertificate and AddNOC commands can only be invoked one after another.
The check for fabric collision will be performed after AddNOC command.

Change overview

Removed obsolete TODOs

Testing

Existing tests

@github-actions
Copy link

github-actions bot commented Jul 21, 2022

PR #21060: Size comparison from 5665d38 to 4660837

Increases (1 build for k32w)
platform target config section 5665d38 4660837 change % change
k32w light k32w061+release (read/write) 660768 660784 16 0.0
.text 583308 583324 16 0.0
Decreases (2 builds for bl602, cyw30739)
platform target config section 5665d38 4660837 change % change
bl602 lighting-app bl602 (read/write) 1380802 1380794 -8 -0.0
.text 1050936 1050932 -4 -0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 587966 587958 -8 -0.0
.app_xip_area 461628 461620 -8 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 5665d38 4660837 change % change
bl602 lighting-app bl602 (read/write) 1380802 1380794 -8 -0.0
.bss 117474 117474 0 0.0
.data 4480 4480 0 0.0
.text 1050936 1050932 -4 -0.0
bl602+rpc (read/write) 1426202 1426202 0 0.0
.bss 124922 124922 0 0.0
.data 4600 4600 0 0.0
.text 1082588 1082588 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668327 668327 0 0.0
(read/write) 183016 183016 0 0.0
.bss 74236 74236 0 0.0
.data 3356 3356 0 0.0
.rodata 88311 88311 0 0.0
.text 579700 579700 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633943 633943 0 0.0
(read/write) 157804 157804 0 0.0
.bss 73532 73532 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77551 0 0.0
.text 556068 556068 0 0.0
lock-ftd LP_CC2652R7 (read only) 671555 671555 0 0.0
(read/write) 169964 169964 0 0.0
.bss 71300 71300 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76443 0 0.0
.text 594632 594632 0 0.0
lock-mtd LP_CC2652R7 (read only) 653839 653839 0 0.0
(read/write) 183368 183368 0 0.0
.bss 66988 66988 0 0.0
.data 3280 3280 0 0.0
.rodata 101183 101183 0 0.0
.text 552176 552176 0 0.0
pump-app LP_CC2652R7 (read only) 680579 680579 0 0.0
(read/write) 161796 161796 0 0.0
.bss 71388 71388 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 88811 0 0.0
.text 591284 591284 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666355 666355 0 0.0
(read/write) 176140 176140 0 0.0
.bss 71508 71508 0 0.0
.data 3276 3276 0 0.0
.rodata 84667 84667 0 0.0
.text 581208 581208 0 0.0
shell LP_CC2652R7 (read only) 660810 660810 0 0.0
(read/write) 186036 186036 0 0.0
.bss 76540 76540 0 0.0
.data 3360 3360 0 0.0
.rodata 85090 85090 0 0.0
.text 575404 575404 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 582050 582050 0 0.0
.app_xip_area 460440 460440 0 0.0
.bss 64404 64404 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587966 587958 -8 -0.0
.app_xip_area 461628 461620 -8 -0.0
.bss 69132 69132 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585430 585430 0 0.0
.app_xip_area 464668 464668 0 0.0
.bss 63612 63612 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1086760 1086760 0 0.0
.bss 133220 133220 0 0.0
.data 2048 2048 0 0.0
.text 951472 951472 0 0.0
BRD4161A+rpc (read/write) 1141036 1141036 0 0.0
.bss 149892 149892 0 0.0
.data 2260 2260 0 0.0
.text 988860 988860 0 0.0
BRD4161A+rs911x (read/write) 972716 972716 0 0.0
.bss 161664 161664 0 0.0
.data 2048 2048 0 0.0
.text 808984 808984 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128224 1128224 0 0.0
.bss 144304 144304 0 0.0
.data 2056 2056 0 0.0
.text 981844 981844 0 0.0
window-app BRD4161A (read/write) 1080236 1080236 0 0.0
.bss 134692 134692 0 0.0
.data 2076 2076 0 0.0
.text 943448 943448 0 0.0
esp32 all-clusters-app c3devkit (read only) 1021930 1021930 0 0.0
(read/write) 1486282 1486282 0 0.0
.dram0.bss 70232 70232 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216008 216008 0 0.0
.flash.text 1021930 1021930 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075691 1075691 0 0.0
(read/write) 488304 488304 0 0.0
.dram0.bss 75752 75752 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246412 246412 0 0.0
.flash.text 1070307 1070307 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660768 660784 16 0.0
.bss 69668 69668 0 0.0
.data 1992 1992 0 0.0
.text 583308 583324 16 0.0
lock k32w061+release (read/write) 687788 687788 0 0.0
.bss 70140 70140 0 0.0
.data 2004 2004 0 0.0
.text 609844 609844 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9774108 9774108 0 0.0
(read/write) 679441 679441 0 0.0
.bss 32833 32833 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 624824 624824 0 0.0
.dynamic 560 560 0 0.0
.got 13552 13552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 457340 457340 0 0.0
.text 7732372 7732372 0 0.0
thermostat-no-ble arm64 (read only) 2341476 2341476 0 0.0
(read/write) 141265 141265 0 0.0
.bss 55233 55233 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75616 75616 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139420 139420 0 0.0
.text 1965248 1965248 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449032 2449032 0 0.0
.bss 214444 214444 0 0.0
.data 5872 5872 0 0.0
.text 1411676 1411676 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176383 1176383 0 0.0
bss 143068 143068 0 0.0
rodata 142200 142200 0 0.0
text 812248 812248 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156447 1156447 0 0.0
bss 142304 142304 0 0.0
rodata 133744 133744 0 0.0
text 801564 801564 0 0.0
p6 all-clusters-app default (read only) 881632 881632 0 0.0
(read/write) 1686428 1686428 0 0.0
.bss 149064 149064 0 0.0
.data 2648 2648 0 0.0
.text 1526328 1526328 0 0.0
all-clusters-minimal-app default (read only) 882352 882352 0 0.0
(read/write) 1630540 1630540 0 0.0
.bss 148344 148344 0 0.0
.data 2648 2648 0 0.0
.text 1471160 1471160 0 0.0
light-app default (read only) 890656 890656 0 0.0
(read/write) 1550780 1550780 0 0.0
.bss 140248 140248 0 0.0
.data 2440 2440 0 0.0
.text 1399704 1399704 0 0.0
lock-app default (read only) 886184 886184 0 0.0
(read/write) 1588372 1588372 0 0.0
.bss 144704 144704 0 0.0
.data 2456 2456 0 0.0
.text 1432824 1432824 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798852 798852 0 0.0
bss 70744 70744 0 0.0
noinit 40416 40416 0 0.0
text 566824 566824 0 0.0
lighting-app tlsr9518adk80d (read/write) 818900 818900 0 0.0
bss 71588 71588 0 0.0
noinit 40416 40416 0 0.0
text 583368 583368 0 0.0

Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking TODO removals

@woody-apple woody-apple enabled auto-merge (squash) July 21, 2022 17:43
@woody-apple woody-apple merged commit b87244d into project-chip:master Jul 21, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants