Skip to content

Commit 4660837

Browse files
committed
Remove Obsolete TODOs in the AddTrustedRootCertificate and AddNOC Commands.
1 parent 94f8974 commit 4660837

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

src/app/clusters/operational-credentials-server/operational-credentials-server.cpp

-5
Original file line numberDiff line numberDiff line change
@@ -668,9 +668,6 @@ bool emberAfOperationalCredentialsClusterAddNOCCallback(app::CommandHandler * co
668668
// Flush acks before really slow work
669669
commandObj->FlushAcksRightAwayOnSlowCommand();
670670

671-
// TODO: Add support for calling AddNOC without a prior AddTrustedRootCertificate if
672-
// the root properly matches an existing one.
673-
674671
// We can't possibly have a matching root based on the fact that we don't have
675672
// a shared root store. Therefore we would later fail path validation due to
676673
// missing root. Let's early-bail with InvalidNOC.
@@ -1197,8 +1194,6 @@ bool emberAfOperationalCredentialsClusterAddTrustedRootCertificateCallback(
11971194
// Flush acks before really slow work
11981195
commandObj->FlushAcksRightAwayOnSlowCommand();
11991196

1200-
// TODO(#17208): Handle checking for byte-to-byte match with existing fabrics before allowing the add
1201-
12021197
err = ValidateChipRCAC(rootCertificate);
12031198
VerifyOrExit(err == CHIP_NO_ERROR, finalStatus = Status::InvalidCommand);
12041199

0 commit comments

Comments
 (0)