Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenThread] Do not re-add existing services #19803

Merged
merged 2 commits into from
Jun 22, 2022
Merged

[OpenThread] Do not re-add existing services #19803

merged 2 commits into from
Jun 22, 2022

Conversation

Damian-Nordic
Copy link
Contributor

Problem

Currently, when a single DNS-SD service is updated, all services are removed and re-added. This approach is
acceptable in the case of mDNS-based implementations, but in the case of SRP it generates unnecessary traffic to the
SRP server. Also, it may generate SRP updates bigger than MTU which has only been addressed in OpenThread recently and
may result in SRP update parsing errors when using older OpenThread versions and the SRP server does not support IPv6 reassembly.

Change overview

Detect if a service is re-added with the same port, subtypes and TXT entries and do nothing in such a case.
Reduce the size of SRP debug logs to compensate flash increase in debug builds.

Testing

Tested on nRF Connect Lock that adding 5 fabrics and opening a commissionable window succeeds.
Verified using nRF sniffer for 15.4 that only modified services are sent in an SRP update.

@Damian-Nordic
[OpenThread] Do not re-add existing services
2b10cad 
Currently, when a single DNS-SD service is updated, all
services are removed and re-added. This approach is
acceptable in the case of mDNS-based implementations, but
in the case of SRP it generates unnecessary traffic to the
SRP server. Also, it may generate SRP updates bigger than
MTU which has only been addressed in OpenThread recently and
may result in SRP update parsing errors when using older
OpenThread versions.
@github-actions
Copy link

github-actions bot commented Jun 21, 2022 •
edited
Loading

PR #19803: Size comparison from 2ac3ee7 to 2b10cad

Increases (22 builds for cc13x2_26x2, cyw30739, k32w, nrfconnect, telink)
platform target config section 2ac3ee7 2b10cad change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 191296 191328 32 0.0
.text 572168 572384 216 0.0
all-clusters-minimal-app LP_CC2652R7 .text 557328 557552 224 0.0
lock-ftd LP_CC2652R7 (read/write) 150444 150476 32 0.0
.text 590884 591100 216 0.0
lock-mtd LP_CC2652R7 .text 540396 540612 216 0.0
pump-app LP_CC2652R7 (read/write) 170396 170484 88 0.1
.text 583724 583940 216 0.0
pump-controller-app LP_CC2652R7 (read/write) 184616 184712 96 0.1
.text 573776 573984 208 0.0
shell LP_CC2652R7 (read/write) 157364 157404 40 0.0
.text 579024 579232 208 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 612766 612974 208 0.0
.app_xip_area 469432 469640 208 0.0
lock cyw930739m2evb_01 (read/write) 610122 610330 208 0.0
.app_xip_area 466612 466820 208 0.0
k32w light k32w061+release (read/write) 658940 659460 520 0.1
.text 582392 582912 520 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 822552 822776 224 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 794772 794996 224 0.0
lighting-app nrf52840dk_nrf52840 text 813628 813856 228 0.0
nrf52840dk_nrf52840+rpc text 790376 790600 224 0.0
nrf52840dongle_nrf52840 text 742140 742364 224 0.0
nrf5340dk_nrf5340_cpuapp text 726368 726592 224 0.0
lock-app nrf52840dk_nrf52840 text 760020 760244 224 0.0
nrf5340dk_nrf5340_cpuapp text 672808 673032 224 0.0
pump-app nrf52840dk_nrf52840 text 743340 743560 220 0.0
pump-controller-app nrf52840dk_nrf52840 text 734724 734948 224 0.0
telink light-switch-app tlsr9518adk80d text 559674 559906 232 0.0
lighting-app tlsr9518adk80d text 576134 576366 232 0.0
Decreases (22 builds for cc13x2_26x2, cyw30739, k32w, mbed, nrfconnect, telink)
platform target config section 2ac3ee7 2b10cad change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 659567 659535 -32 -0.0
.rodata 87087 86839 -248 -0.3
all-clusters-minimal-app LP_CC2652R7 (read only) 648055 648031 -24 -0.0
.rodata 90407 90159 -248 -0.3
lock-ftd LP_CC2652R7 (read only) 690531 690499 -32 -0.0
.rodata 99163 98915 -248 -0.3
lock-mtd LP_CC2652R7 (read only) 639931 639907 -24 -0.0
.rodata 99043 98803 -240 -0.2
pump-app LP_CC2652R7 (read only) 671467 671379 -88 -0.0
.rodata 87259 86955 -304 -0.3
pump-controller-app LP_CC2652R7 (read only) 657359 657263 -96 -0.0
.rodata 83103 82799 -304 -0.4
shell LP_CC2652R7 (read only) 688994 688954 -40 -0.0
.rodata 109658 109410 -248 -0.2
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 616130 616050 -80 -0.0
.app_xip_area 473684 473604 -80 -0.0
k32w lock k32w061+release (read/write) 720916 720836 -80 -0.0
.text 643920 643840 -80 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2438104 2438040 -64 -0.0
.text 1400748 1400684 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1198747 1198671 -76 -0.0
rodata 155676 155376 -300 -0.2
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1146703 1146631 -72 -0.0
rodata 132200 131904 -296 -0.2
lighting-app nrf52840dk_nrf52840 (read/write) 1158271 1158195 -76 -0.0
rodata 122616 122316 -300 -0.2
nrf52840dk_nrf52840+rpc (read/write) 1127567 1127491 -76 -0.0
rodata 114232 113932 -300 -0.3
nrf52840dongle_nrf52840 (read/write) 1065431 1065355 -76 -0.0
rodata 91760 91460 -300 -0.3
nrf5340dk_nrf5340_cpuapp (read/write) 1061978 1061906 -72 -0.0
rodata 115024 114728 -296 -0.3
lock-app nrf52840dk_nrf52840 (read/write) 1111359 1111287 -72 -0.0
rodata 139344 139048 -296 -0.2
nrf5340dk_nrf5340_cpuapp (read/write) 1015222 1015150 -72 -0.0
rodata 131812 131516 -296 -0.2
pump-app nrf52840dk_nrf52840 (read/write) 1071239 1071167 -72 -0.0
rodata 116000 115704 -296 -0.3
pump-controller-app nrf52840dk_nrf52840 (read/write) 1059287 1059211 -76 -0.0
rodata 112784 112484 -300 -0.3
telink light-switch-app tlsr9518adk80d (read/write) 789088 789032 -56 -0.0
lighting-app tlsr9518adk80d (read/write) 808792 808736 -56 -0.0
Full report (42 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2ac3ee7 2b10cad change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 659567 659535 -32 -0.0
(read/write) 191296 191328 32 0.0
.bss 73756 73756 0 0.0
.data 3356 3356 0 0.0
.rodata 87087 86839 -248 -0.3
.text 572168 572384 216 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 648055 648031 -24 -0.0
(read/write) 157316 157316 0 0.0
.bss 73044 73044 0 0.0
.data 3356 3356 0 0.0
.rodata 90407 90159 -248 -0.3
.text 557328 557552 224 0.0
lock-ftd LP_CC2652R7 (read only) 690531 690499 -32 -0.0
(read/write) 150444 150476 32 0.0
.bss 70756 70756 0 0.0
.data 3280 3280 0 0.0
.rodata 99163 98915 -248 -0.3
.text 590884 591100 216 0.0
lock-mtd LP_CC2652R7 (read only) 639931 639907 -24 -0.0
(read/write) 143888 143888 0 0.0
.bss 66492 66492 0 0.0
.data 3280 3280 0 0.0
.rodata 99043 98803 -240 -0.2
.text 540396 540612 216 0.0
pump-app LP_CC2652R7 (read only) 671467 671379 -88 -0.0
(read/write) 170396 170484 88 0.1
.bss 70876 70876 0 0.0
.data 3280 3280 0 0.0
.rodata 87259 86955 -304 -0.3
.text 583724 583940 216 0.0
pump-controller-app LP_CC2652R7 (read only) 657359 657263 -96 -0.0
(read/write) 184616 184712 96 0.1
.bss 70988 70988 0 0.0
.data 3276 3276 0 0.0
.rodata 83103 82799 -304 -0.4
.text 573776 573984 208 0.0
shell LP_CC2652R7 (read only) 688994 688954 -40 -0.0
(read/write) 157364 157404 40 0.0
.bss 76052 76052 0 0.0
.data 3360 3360 0 0.0
.rodata 109658 109410 -248 -0.2
.text 579024 579232 208 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 612766 612974 208 0.0
.app_xip_area 469432 469640 208 0.0
.bss 86288 86288 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 610122 610330 208 0.0
.app_xip_area 466612 466820 208 0.0
.bss 86464 86464 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 616130 616050 -80 -0.0
.app_xip_area 473684 473604 -80 -0.0
.bss 85456 85456 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 658940 659460 520 0.1
.bss 68756 68756 0 0.0
.data 1992 1992 0 0.0
.text 582392 582912 520 0.1
lock k32w061+release (read/write) 720916 720836 -80 -0.0
.bss 69196 69196 0 0.0
.data 2000 2000 0 0.0
.text 643920 643840 -80 -0.0
linux all-clusters-app debug (read only) 2931385 2931385 0 0.0
(read/write) 188656 188656 0 0.0
.bss 95744 95744 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84664 84664 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 260029 260029 0 0.0
.text 2494914 2494914 0 0.0
all-clusters-minimal-app debug (read only) 2785097 2785097 0 0.0
(read/write) 180560 180560 0 0.0
.bss 95072 95072 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77304 77304 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 261565 261565 0 0.0
.text 2349266 2349266 0 0.0
bridge-app debug+rpc (read only) 2287665 2287665 0 0.0
(read/write) 159424 159424 0 0.0
.bss 83136 83136 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66728 66728 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 194848 194848 0 0.0
.text 1931730 1931730 0 0.0
chip-tool debug (read only) 10141773 10141773 0 0.0
(read/write) 609544 609544 0 0.0
.bss 24352 24352 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 577808 577808 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 509301 509301 0 0.0
.text 8226741 8226741 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9882612 9882612 0 0.0
(read/write) 674225 674225 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 613208 613208 0 0.0
.dynamic 528 528 0 0.0
.got 13416 13416 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472324 472324 0 0.0
.text 7873860 7873860 0 0.0
lighting-app debug+rpc (read only) 2520433 2520433 0 0.0
(read/write) 163448 163448 0 0.0
.bss 83616 83616 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71896 71896 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 210632 210632 0 0.0
.text 2140098 2140098 0 0.0
lock-app debug (read only) 2459113 2459113 0 0.0
(read/write) 158096 158096 0 0.0
.bss 82016 82016 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68568 68568 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 224328 224328 0 0.0
.text 2070482 2070482 0 0.0
ota-provider-app debug (read only) 2296993 2296993 0 0.0
(read/write) 152232 152232 0 0.0
.bss 81696 81696 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 200504 200504 0 0.0
.text 1934338 1934338 0 0.0
ota-requestor-app debug (read only) 2412705 2412705 0 0.0
(read/write) 158976 158976 0 0.0
.bss 84000 84000 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 66936 66936 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 204192 204192 0 0.0
.text 2038130 2038130 0 0.0
shell debug (read only) 2604865 2604865 0 0.0
(read/write) 219288 219288 0 0.0
.bss 134504 134504 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77808 77808 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 230290 230290 0 0.0
.text 2214818 2214818 0 0.0
thermostat-no-ble arm64 (read only) 2571580 2571580 0 0.0
(read/write) 192193 192193 0 0.0
.bss 99489 99489 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 82928 82928 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 163340 163340 0 0.0
.text 2169120 2169120 0 0.0
tv-app debug (read only) 3068849 3068849 0 0.0
(read/write) 289352 289352 0 0.0
.bss 199240 199240 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 79016 79016 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 246176 246176 0 0.0
.text 2635810 2635810 0 0.0
tv-casting-app debug (read only) 5534513 5534513 0 0.0
(read/write) 195664 195664 0 0.0
.bss 84424 84424 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 102576 102576 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 340137 340137 0 0.0
.text 4918146 4918146 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2438104 2438040 -64 -0.0
.bss 208204 208204 0 0.0
.data 5864 5864 0 0.0
.text 1400748 1400684 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1198747 1198671 -76 -0.0
bss 141598 141598 0 0.0
rodata 155676 155376 -300 -0.2
text 822552 822776 224 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1146703 1146631 -72 -0.0
bss 140850 140850 0 0.0
rodata 132200 131904 -296 -0.2
text 794772 794996 224 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1158271 1158195 -76 -0.0
bss 143177 143177 0 0.0
rodata 122616 122316 -300 -0.2
text 813628 813856 228 0.0
nrf52840dk_nrf52840+rpc (read/write) 1127567 1127491 -76 -0.0
bss 143622 143622 0 0.0
rodata 114232 113932 -300 -0.3
text 790376 790600 224 0.0
nrf52840dongle_nrf52840 (read/write) 1065431 1065355 -76 -0.0
bss 150408 150408 0 0.0
rodata 91760 91460 -300 -0.3
text 742140 742364 224 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1061978 1061906 -72 -0.0
bss 139548 139548 0 0.0
rodata 115024 114728 -296 -0.3
text 726368 726592 224 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1111359 1111287 -72 -0.0
bss 133125 133125 0 0.0
rodata 139344 139048 -296 -0.2
text 760020 760244 224 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1015222 1015150 -72 -0.0
bss 129528 129528 0 0.0
rodata 131812 131516 -296 -0.2
text 672808 673032 224 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1071239 1071167 -72 -0.0
bss 133072 133072 0 0.0
rodata 116000 115704 -296 -0.3
text 743340 743560 220 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1059287 1059211 -76 -0.0
bss 132867 132867 0 0.0
rodata 112784 112484 -300 -0.3
text 734724 734948 224 0.0
p6 all-clusters-app default (read/write) 2553928 2553928 0 0.0
.bss 143384 143384 0 0.0
.data 2776 2776 0 0.0
.text 1512192 1512192 0 0.0
all-clusters-minimal-app default (read/write) 2499776 2499776 0 0.0
.bss 142664 142664 0 0.0
.data 2776 2776 0 0.0
.text 1458040 1458040 0 0.0
light-app default (read/write) 2430520 2430520 0 0.0
.bss 134744 134744 0 0.0
.data 2592 2592 0 0.0
.text 1388784 1388784 0 0.0
lock-app default (read/write) 2451216 2451216 0 0.0
.bss 134568 134568 0 0.0
.data 2600 2600 0 0.0
.text 1409480 1409480 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 789088 789032 -56 -0.0
bss 69892 69892 0 0.0
noinit 40416 40416 0 0.0
text 559674 559906 232 0.0
lighting-app tlsr9518adk80d (read/write) 808792 808736 -56 -0.0
bss 70140 70140 0 0.0
noinit 40416 40416 0 0.0
text 576134 576366 232 0.0

@Damian-Nordic @jmeg-sfy
Add parentheses
a257ca4 
Co-authored-by: Jonathan Mégevand <[email protected]>
@github-actions
Copy link

github-actions bot commented Jun 21, 2022 •
edited
Loading

PR #19803: Size comparison from 2ac3ee7 to a257ca4

Increases (22 builds for cc13x2_26x2, cyw30739, k32w, nrfconnect, telink)
platform target config section 2ac3ee7 a257ca4 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 191296 191328 32 0.0
.text 572168 572384 216 0.0
all-clusters-minimal-app LP_CC2652R7 .text 557328 557552 224 0.0
lock-ftd LP_CC2652R7 (read/write) 150444 150476 32 0.0
.text 590884 591100 216 0.0
lock-mtd LP_CC2652R7 .text 540396 540612 216 0.0
pump-app LP_CC2652R7 (read/write) 170396 170484 88 0.1
.text 583724 583940 216 0.0
pump-controller-app LP_CC2652R7 (read/write) 184616 184712 96 0.1
.text 573776 573984 208 0.0
shell LP_CC2652R7 (read/write) 157364 157412 48 0.0
.text 579024 579224 200 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 612766 612966 200 0.0
.app_xip_area 469432 469632 200 0.0
lock cyw930739m2evb_01 (read/write) 610122 610330 208 0.0
.app_xip_area 466612 466820 208 0.0
k32w light k32w061+release (read/write) 658940 659460 520 0.1
.text 582392 582912 520 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 822552 822776 224 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 794772 794996 224 0.0
lighting-app nrf52840dk_nrf52840 text 813628 813856 228 0.0
nrf52840dk_nrf52840+rpc text 790376 790600 224 0.0
nrf52840dongle_nrf52840 text 742140 742360 220 0.0
nrf5340dk_nrf5340_cpuapp text 726368 726592 224 0.0
lock-app nrf52840dk_nrf52840 text 760020 760244 224 0.0
nrf5340dk_nrf5340_cpuapp text 672808 673032 224 0.0
pump-app nrf52840dk_nrf52840 text 743340 743564 224 0.0
pump-controller-app nrf52840dk_nrf52840 text 734724 734948 224 0.0
telink light-switch-app tlsr9518adk80d text 559674 559908 234 0.0
lighting-app tlsr9518adk80d text 576134 576366 232 0.0
Decreases (21 builds for cc13x2_26x2, cyw30739, k32w, nrfconnect, telink)
platform target config section 2ac3ee7 a257ca4 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 659567 659535 -32 -0.0
.rodata 87087 86839 -248 -0.3
all-clusters-minimal-app LP_CC2652R7 (read only) 648055 648031 -24 -0.0
.rodata 90407 90159 -248 -0.3
lock-ftd LP_CC2652R7 (read only) 690531 690499 -32 -0.0
.rodata 99163 98915 -248 -0.3
lock-mtd LP_CC2652R7 (read only) 639931 639907 -24 -0.0
.rodata 99043 98803 -240 -0.2
pump-app LP_CC2652R7 (read only) 671467 671379 -88 -0.0
.rodata 87259 86955 -304 -0.3
pump-controller-app LP_CC2652R7 (read only) 657359 657263 -96 -0.0
.rodata 83103 82799 -304 -0.4
shell LP_CC2652R7 (read only) 688994 688946 -48 -0.0
.rodata 109658 109410 -248 -0.2
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 616130 616042 -88 -0.0
.app_xip_area 473684 473596 -88 -0.0
k32w lock k32w061+release (read/write) 720916 720836 -80 -0.0
.text 643920 643840 -80 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1198747 1198671 -76 -0.0
rodata 155676 155376 -300 -0.2
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1146703 1146631 -72 -0.0
rodata 132200 131904 -296 -0.2
lighting-app nrf52840dk_nrf52840 (read/write) 1158271 1158195 -76 -0.0
rodata 122616 122316 -300 -0.2
nrf52840dk_nrf52840+rpc (read/write) 1127567 1127491 -76 -0.0
rodata 114232 113932 -300 -0.3
nrf52840dongle_nrf52840 (read/write) 1065431 1065355 -76 -0.0
rodata 91760 91460 -300 -0.3
nrf5340dk_nrf5340_cpuapp (read/write) 1061978 1061906 -72 -0.0
rodata 115024 114728 -296 -0.3
lock-app nrf52840dk_nrf52840 (read/write) 1111359 1111287 -72 -0.0
rodata 139344 139048 -296 -0.2
nrf5340dk_nrf5340_cpuapp (read/write) 1015222 1015150 -72 -0.0
rodata 131812 131516 -296 -0.2
pump-app nrf52840dk_nrf52840 (read/write) 1071239 1071167 -72 -0.0
rodata 116000 115704 -296 -0.3
pump-controller-app nrf52840dk_nrf52840 (read/write) 1059287 1059211 -76 -0.0
rodata 112784 112484 -300 -0.3
telink light-switch-app tlsr9518adk80d (read/write) 789088 789032 -56 -0.0
lighting-app tlsr9518adk80d (read/write) 808792 808736 -56 -0.0
Full report (42 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2ac3ee7 a257ca4 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 659567 659535 -32 -0.0
(read/write) 191296 191328 32 0.0
.bss 73756 73756 0 0.0
.data 3356 3356 0 0.0
.rodata 87087 86839 -248 -0.3
.text 572168 572384 216 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 648055 648031 -24 -0.0
(read/write) 157316 157316 0 0.0
.bss 73044 73044 0 0.0
.data 3356 3356 0 0.0
.rodata 90407 90159 -248 -0.3
.text 557328 557552 224 0.0
lock-ftd LP_CC2652R7 (read only) 690531 690499 -32 -0.0
(read/write) 150444 150476 32 0.0
.bss 70756 70756 0 0.0
.data 3280 3280 0 0.0
.rodata 99163 98915 -248 -0.3
.text 590884 591100 216 0.0
lock-mtd LP_CC2652R7 (read only) 639931 639907 -24 -0.0
(read/write) 143888 143888 0 0.0
.bss 66492 66492 0 0.0
.data 3280 3280 0 0.0
.rodata 99043 98803 -240 -0.2
.text 540396 540612 216 0.0
pump-app LP_CC2652R7 (read only) 671467 671379 -88 -0.0
(read/write) 170396 170484 88 0.1
.bss 70876 70876 0 0.0
.data 3280 3280 0 0.0
.rodata 87259 86955 -304 -0.3
.text 583724 583940 216 0.0
pump-controller-app LP_CC2652R7 (read only) 657359 657263 -96 -0.0
(read/write) 184616 184712 96 0.1
.bss 70988 70988 0 0.0
.data 3276 3276 0 0.0
.rodata 83103 82799 -304 -0.4
.text 573776 573984 208 0.0
shell LP_CC2652R7 (read only) 688994 688946 -48 -0.0
(read/write) 157364 157412 48 0.0
.bss 76052 76052 0 0.0
.data 3360 3360 0 0.0
.rodata 109658 109410 -248 -0.2
.text 579024 579224 200 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 612766 612966 200 0.0
.app_xip_area 469432 469632 200 0.0
.bss 86288 86288 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 610122 610330 208 0.0
.app_xip_area 466612 466820 208 0.0
.bss 86464 86464 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 616130 616042 -88 -0.0
.app_xip_area 473684 473596 -88 -0.0
.bss 85456 85456 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 658940 659460 520 0.1
.bss 68756 68756 0 0.0
.data 1992 1992 0 0.0
.text 582392 582912 520 0.1
lock k32w061+release (read/write) 720916 720836 -80 -0.0
.bss 69196 69196 0 0.0
.data 2000 2000 0 0.0
.text 643920 643840 -80 -0.0
linux all-clusters-app debug (read only) 2931385 2931385 0 0.0
(read/write) 188656 188656 0 0.0
.bss 95744 95744 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84664 84664 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 260029 260029 0 0.0
.text 2494914 2494914 0 0.0
all-clusters-minimal-app debug (read only) 2785097 2785097 0 0.0
(read/write) 180560 180560 0 0.0
.bss 95072 95072 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77304 77304 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 261565 261565 0 0.0
.text 2349266 2349266 0 0.0
bridge-app debug+rpc (read only) 2287665 2287665 0 0.0
(read/write) 159424 159424 0 0.0
.bss 83136 83136 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66728 66728 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 194848 194848 0 0.0
.text 1931730 1931730 0 0.0
chip-tool debug (read only) 10141773 10141773 0 0.0
(read/write) 609544 609544 0 0.0
.bss 24352 24352 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 577808 577808 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 509301 509301 0 0.0
.text 8226741 8226741 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9882612 9882612 0 0.0
(read/write) 674225 674225 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 613208 613208 0 0.0
.dynamic 528 528 0 0.0
.got 13416 13416 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472324 472324 0 0.0
.text 7873860 7873860 0 0.0
lighting-app debug+rpc (read only) 2520433 2520433 0 0.0
(read/write) 163448 163448 0 0.0
.bss 83616 83616 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71896 71896 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 210632 210632 0 0.0
.text 2140098 2140098 0 0.0
lock-app debug (read only) 2459113 2459113 0 0.0
(read/write) 158096 158096 0 0.0
.bss 82016 82016 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68568 68568 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 224328 224328 0 0.0
.text 2070482 2070482 0 0.0
ota-provider-app debug (read only) 2296993 2296993 0 0.0
(read/write) 152232 152232 0 0.0
.bss 81696 81696 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 200504 200504 0 0.0
.text 1934338 1934338 0 0.0
ota-requestor-app debug (read only) 2412705 2412705 0 0.0
(read/write) 158976 158976 0 0.0
.bss 84000 84000 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 66936 66936 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 204192 204192 0 0.0
.text 2038130 2038130 0 0.0
shell debug (read only) 2604865 2604865 0 0.0
(read/write) 219288 219288 0 0.0
.bss 134504 134504 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77808 77808 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 230290 230290 0 0.0
.text 2214818 2214818 0 0.0
thermostat-no-ble arm64 (read only) 2571580 2571580 0 0.0
(read/write) 192193 192193 0 0.0
.bss 99489 99489 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 82928 82928 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 163340 163340 0 0.0
.text 2169120 2169120 0 0.0
tv-app debug (read only) 3068849 3068849 0 0.0
(read/write) 289352 289352 0 0.0
.bss 199240 199240 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 79016 79016 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 246176 246176 0 0.0
.text 2635810 2635810 0 0.0
tv-casting-app debug (read only) 5534513 5534513 0 0.0
(read/write) 195664 195664 0 0.0
.bss 84424 84424 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 102576 102576 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 340137 340137 0 0.0
.text 4918146 4918146 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2438104 2438104 0 0.0
.bss 208204 208204 0 0.0
.data 5864 5864 0 0.0
.text 1400748 1400748 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1198747 1198671 -76 -0.0
bss 141598 141598 0 0.0
rodata 155676 155376 -300 -0.2
text 822552 822776 224 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1146703 1146631 -72 -0.0
bss 140850 140850 0 0.0
rodata 132200 131904 -296 -0.2
text 794772 794996 224 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1158271 1158195 -76 -0.0
bss 143177 143177 0 0.0
rodata 122616 122316 -300 -0.2
text 813628 813856 228 0.0
nrf52840dk_nrf52840+rpc (read/write) 1127567 1127491 -76 -0.0
bss 143622 143622 0 0.0
rodata 114232 113932 -300 -0.3
text 790376 790600 224 0.0
nrf52840dongle_nrf52840 (read/write) 1065431 1065355 -76 -0.0
bss 150408 150408 0 0.0
rodata 91760 91460 -300 -0.3
text 742140 742360 220 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1061978 1061906 -72 -0.0
bss 139548 139548 0 0.0
rodata 115024 114728 -296 -0.3
text 726368 726592 224 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1111359 1111287 -72 -0.0
bss 133125 133125 0 0.0
rodata 139344 139048 -296 -0.2
text 760020 760244 224 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1015222 1015150 -72 -0.0
bss 129528 129528 0 0.0
rodata 131812 131516 -296 -0.2
text 672808 673032 224 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1071239 1071167 -72 -0.0
bss 133072 133072 0 0.0
rodata 116000 115704 -296 -0.3
text 743340 743564 224 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1059287 1059211 -76 -0.0
bss 132867 132867 0 0.0
rodata 112784 112484 -300 -0.3
text 734724 734948 224 0.0
p6 all-clusters-app default (read/write) 2553928 2553928 0 0.0
.bss 143384 143384 0 0.0
.data 2776 2776 0 0.0
.text 1512192 1512192 0 0.0
all-clusters-minimal-app default (read/write) 2499776 2499776 0 0.0
.bss 142664 142664 0 0.0
.data 2776 2776 0 0.0
.text 1458040 1458040 0 0.0
light-app default (read/write) 2430520 2430520 0 0.0
.bss 134744 134744 0 0.0
.data 2592 2592 0 0.0
.text 1388784 1388784 0 0.0
lock-app default (read/write) 2451216 2451216 0 0.0
.bss 134568 134568 0 0.0
.data 2600 2600 0 0.0
.text 1409480 1409480 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 789088 789032 -56 -0.0
bss 69892 69892 0 0.0
noinit 40416 40416 0 0.0
text 559674 559908 234 0.0
lighting-app tlsr9518adk80d (read/write) 808792 808736 -56 -0.0
bss 70140 70140 0 0.0
noinit 40416 40416 0 0.0
text 576134 576366 232 0.0

@tcarmelveilleux tcarmelveilleux merged commit b99df91 into project-chip:master Jun 22, 2022
@Damian-Nordic Damian-Nordic mentioned this pull request Jun 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@LuDuda LuDuda Awaiting requested review from LuDuda

@rgoliver rgoliver Awaiting requested review from rgoliver

@msandstedt msandstedt Awaiting requested review from msandstedt

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@saurabhst saurabhst Awaiting requested review from saurabhst

@tecimovic tecimovic Awaiting requested review from tecimovic

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
nrf connect openthread platform review - approved zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Damian-Nordic @tcarmelveilleux @andy31415 @LuDuda @msandstedt @saurabhst @woody-apple @jmeg-sfy