Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework Thread attachement event and unify implementation #19474

Merged
merged 3 commits into from
Jun 11, 2022
Merged

Rework Thread attachement event and unify implementation #19474

merged 3 commits into from
Jun 11, 2022

Conversation

jmartinez-silabs
Copy link
Member

Problem

GenericThreadStackManagerImpl_OpenThread, when CHIP_SYSTEM_CONFIG_USE_OPEN_THREAD_ENDPOINT is defined, is posting the connectivity establish event on the wrong condition causing the system to consider the thread attachment complete too soon and also causing multi-event posting.

Change overview

  • Base the thread attachment establishment complet on the Thread device role and not the ipv6 interface up. The event can only be posted once per establishment state based on the Thread roles (Disable and Detached = Not attached. Child, Router and Leader= Attached).
  • There was also no reason to gate that logic behind CHIP_SYSTEM_CONFIG_USE_OPEN_THREAD_ENDPOINT
  • Unify the use of the GenericThreadStackManagerImpl_OpenThread _OnPlatformEvent

I didn't want to mess in the ThreadStackManager Implementation of some platforms I don't know much about and that I can't test (Telink and Tizen), but the dev representing those platforms can now use the generic _OnPlatformEvent correctly.

Linux and WebOs are separate as they use ot-br-possix apis.

Testing

Build and commission the EFR32 lighting-app

@github-actions
Copy link

github-actions bot commented Jun 10, 2022 •
edited
Loading

PR #19474: Size comparison from 287e47a to e9cfb22

Increases (12 builds for cc13x2_26x2, cyw30739, k32w)
platform target config section 287e47a e9cfb22 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 656295 656319 24 0.0
.text 569472 569496 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644779 644795 16 0.0
.text 554440 554456 16 0.0
lock-ftd LP_CC2652R7 (read only) 687651 687683 32 0.0
.text 588324 588356 32 0.0
lock-mtd LP_CC2652R7 (read only) 637059 637083 24 0.0
.text 537844 537868 24 0.0
pump-app LP_CC2652R7 (read only) 669011 669043 32 0.0
.text 581572 581604 32 0.0
pump-controller-app LP_CC2652R7 (read only) 659575 659607 32 0.0
.text 574236 574268 32 0.0
shell LP_CC2652R7 (read only) 686422 686438 16 0.0
.text 576528 576544 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 606450 606482 32 0.0
.app_xip_area 464964 464988 24 0.0
.bss 84416 84424 8 0.0
lock cyw930739m2evb_01 (read/write) 603550 603582 32 0.0
.app_xip_area 461920 461944 24 0.0
.bss 84592 84600 8 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611270 611294 24 0.0
.app_xip_area 470712 470728 16 0.0
.bss 83600 83608 8 0.0
k32w light k32w061+release .bss 69732 69740 8 0.0
lock k32w061+release .bss 70164 70172 8 0.0
Decreases (22 builds for cc13x2_26x2, efr32, k32w, nrfconnect, telink)
platform target config section 287e47a e9cfb22 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 194584 194560 -24 -0.0
lock-ftd LP_CC2652R7 (read/write) 154300 154268 -32 -0.0
pump-app LP_CC2652R7 (read/write) 173852 173820 -32 -0.0
pump-controller-app LP_CC2652R7 (read/write) 183392 183360 -32 -0.0
shell LP_CC2652R7 (read/write) 159952 159936 -16 -0.0
efr32 lighting-app BRD4161A (read only) 919200 919168 -32 -0.0
.text 919192 919160 -32 -0.0
BRD4161A+rpc (read only) 953380 953348 -32 -0.0
.text 953372 953340 -32 -0.0
window-app BRD4161A (read only) 904256 904224 -32 -0.0
.text 904248 904216 -32 -0.0
k32w light k32w061+release (read/write) 657232 657224 -8 -0.0
.text 579672 579656 -16 -0.0
lock k32w061+release (read/write) 718820 718812 -8 -0.0
.text 640856 640840 -16 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1195719 1195687 -32 -0.0
text 819852 819824 -28 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143351 1143319 -32 -0.0
text 791928 791904 -24 -0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1156919 1156903 -16 -0.0
text 811500 811476 -24 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1124999 1124967 -32 -0.0
text 787276 787252 -24 -0.0
nrf52840dongle_nrf52840 (read/write) 1063955 1063939 -16 -0.0
text 740016 740000 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1060594 1060578 -16 -0.0
text 724232 724216 -16 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 1108695 1108663 -32 -0.0
text 756864 756840 -24 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1012622 1012606 -16 -0.0
text 669656 669636 -20 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 1069903 1069887 -16 -0.0
text 741244 741220 -24 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1062487 1062471 -16 -0.0
text 735232 735208 -24 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 786648 786608 -40 -0.0
text 556600 556560 -40 -0.0
lighting-app tlsr9518adk80d (read/write) 806668 806636 -32 -0.0
text 573320 573282 -38 -0.0
Full report (49 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 287e47a e9cfb22 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 656295 656319 24 0.0
(read/write) 194584 194560 -24 -0.0
.bss 73772 73772 0 0.0
.data 3416 3416 0 0.0
.rodata 86511 86511 0 0.0
.text 569472 569496 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644779 644795 16 0.0
(read/write) 157268 157268 0 0.0
.bss 72996 72996 0 0.0
.data 3356 3356 0 0.0
.rodata 90019 90019 0 0.0
.text 554440 554456 16 0.0
lock-ftd LP_CC2652R7 (read only) 687651 687683 32 0.0
(read/write) 154300 154268 -32 -0.0
.bss 71732 71732 0 0.0
.data 3280 3280 0 0.0
.rodata 98843 98843 0 0.0
.text 588324 588356 32 0.0
lock-mtd LP_CC2652R7 (read only) 637059 637083 24 0.0
(read/write) 144864 144864 0 0.0
.bss 67468 67468 0 0.0
.data 3280 3280 0 0.0
.rodata 98723 98723 0 0.0
.text 537844 537868 24 0.0
pump-app LP_CC2652R7 (read only) 669011 669043 32 0.0
(read/write) 173852 173820 -32 -0.0
.bss 71876 71876 0 0.0
.data 3316 3316 0 0.0
.rodata 86955 86955 0 0.0
.text 581572 581604 32 0.0
pump-controller-app LP_CC2652R7 (read only) 659575 659607 32 0.0
(read/write) 183392 183360 -32 -0.0
.bss 71980 71980 0 0.0
.data 3276 3276 0 0.0
.rodata 84855 84855 0 0.0
.text 574236 574268 32 0.0
shell LP_CC2652R7 (read only) 686422 686438 16 0.0
(read/write) 159952 159936 -16 -0.0
.bss 76068 76068 0 0.0
.data 3420 3420 0 0.0
.rodata 109582 109582 0 0.0
.text 576528 576544 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 606450 606482 32 0.0
.app_xip_area 464964 464988 24 0.0
.bss 84416 84424 8 0.0
.data 756 756 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 603550 603582 32 0.0
.app_xip_area 461920 461944 24 0.0
.bss 84592 84600 8 0.0
.data 724 724 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611270 611294 24 0.0
.app_xip_area 470712 470728 16 0.0
.bss 83600 83608 8 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919200 919168 -32 -0.0
(read/write) 133424 133424 0 0.0
.bss 131312 131312 0 0.0
.data 2112 2112 0 0.0
.text 919192 919160 -32 -0.0
BRD4161A+rpc (read only) 953380 953348 -32 -0.0
(read/write) 150116 150116 0 0.0
.bss 147800 147800 0 0.0
.data 2316 2316 0 0.0
.text 953372 953340 -32 -0.0
BRD4161A+rs911x (read only) 794276 794276 0 0.0
(read/write) 129708 129708 0 0.0
.bss 127588 127588 0 0.0
.data 2120 2120 0 0.0
.text 794268 794268 0 0.0
lock-app BRD4161A+wf200 (read only) 962636 962636 0 0.0
(read/write) 130052 130052 0 0.0
.bss 127964 127964 0 0.0
.data 2088 2088 0 0.0
.text 962628 962628 0 0.0
window-app BRD4161A (read only) 904256 904224 -32 -0.0
(read/write) 133504 133504 0 0.0
.bss 131392 131392 0 0.0
.data 2108 2108 0 0.0
.text 904248 904216 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 1010926 1010926 0 0.0
(read/write) 1482754 1482754 0 0.0
.dram0.bss 69400 69400 0 0.0
.dram0.data 14696 14696 0 0.0
.flash.rodata 213216 213216 0 0.0
.flash.text 1010926 1010926 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1065355 1065355 0 0.0
(read/write) 484864 484864 0 0.0
.dram0.bss 74920 74920 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 243724 243724 0 0.0
.flash.text 1059971 1059971 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657232 657224 -8 -0.0
.bss 69732 69740 8 0.0
.data 2028 2028 0 0.0
.text 579672 579656 -16 -0.0
lock k32w061+release (read/write) 718820 718812 -8 -0.0
.bss 70164 70172 8 0.0
.data 2000 2000 0 0.0
.text 640856 640840 -16 -0.0
linux all-clusters-app debug (read only) 2907801 2907801 0 0.0
(read/write) 188240 188240 0 0.0
.bss 95776 95776 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84200 84200 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 257341 257341 0 0.0
.text 2475410 2475410 0 0.0
all-clusters-minimal-app debug (read only) 2769345 2769345 0 0.0
(read/write) 179856 179856 0 0.0
.bss 94944 94944 0 0.0
.data 1920 1920 0 0.0
.data.rel.ro 76824 76824 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258685 258685 0 0.0
.text 2337618 2337618 0 0.0
bridge-app debug+rpc (read only) 2247705 2247705 0 0.0
(read/write) 158688 158688 0 0.0
.bss 82944 82944 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 66200 66200 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 191104 191104 0 0.0
.text 1896690 1896690 0 0.0
chip-tool debug (read only) 9816405 9816405 0 0.0
(read/write) 623496 623496 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590696 590696 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 506869 506869 0 0.0
.text 7868917 7868917 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9564036 9564036 0 0.0
(read/write) 689841 689841 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626128 626128 0 0.0
.dynamic 528 528 0 0.0
.got 15056 15056 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468756 468756 0 0.0
.text 7519188 7519188 0 0.0
lighting-app debug+rpc (read only) 2497617 2497617 0 0.0
(read/write) 163384 163384 0 0.0
.bss 84288 84288 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71128 71128 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 207176 207176 0 0.0
.text 2122322 2122322 0 0.0
lock-app debug (read only) 2443617 2443617 0 0.0
(read/write) 158456 158456 0 0.0
.bss 82944 82944 0 0.0
.data 1552 1552 0 0.0
.data.rel.ro 68088 68088 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 221256 221256 0 0.0
.text 2059234 2059234 0 0.0
ota-provider-app debug (read only) 2281881 2281881 0 0.0
(read/write) 152656 152656 0 0.0
.bss 82624 82624 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 62424 62424 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 197400 197400 0 0.0
.text 1923362 1923362 0 0.0
ota-requestor-app debug (read only) 2329409 2329409 0 0.0
(read/write) 155440 155440 0 0.0
.bss 83328 83328 0 0.0
.data 1976 1976 0 0.0
.data.rel.ro 64344 64344 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 199552 199552 0 0.0
.text 1964898 1964898 0 0.0
shell debug (read only) 2599753 2599753 0 0.0
(read/write) 219384 219384 0 0.0
.bss 134568 134568 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 77664 77664 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229842 229842 0 0.0
.text 2210690 2210690 0 0.0
thermostat-no-ble arm64 (read only) 2557804 2557804 0 0.0
(read/write) 191329 191329 0 0.0
.bss 99361 99361 0 0.0
.data 1560 1560 0 0.0
.data.rel.ro 82336 82336 0 0.0
.dynamic 528 528 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161316 161316 0 0.0
.text 2158976 2158976 0 0.0
tv-app debug (read only) 3051249 3051249 0 0.0
(read/write) 289800 289800 0 0.0
.bss 200200 200200 0 0.0
.data 4688 4688 0 0.0
.data.rel.ro 78472 78472 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 242784 242784 0 0.0
.text 2622754 2622754 0 0.0
tv-casting-app debug (read only) 5350353 5350353 0 0.0
(read/write) 232248 232248 0 0.0
.bss 88072 88072 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 135472 135472 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 342432 342432 0 0.0
.text 4656722 4656722 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2433320 2433320 0 0.0
.bss 208980 208980 0 0.0
.data 5896 5896 0 0.0
.text 1395964 1395964 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1195719 1195687 -32 -0.0
bss 141583 141583 0 0.0
rodata 155296 155296 0 0.0
text 819852 819824 -28 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143351 1143319 -32 -0.0
bss 140800 140800 0 0.0
rodata 131808 131808 0 0.0
text 791928 791904 -24 -0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1156919 1156903 -16 -0.0
bss 144157 144157 0 0.0
rodata 122336 122336 0 0.0
text 811500 811476 -24 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1124999 1124967 -32 -0.0
bss 144398 144398 0 0.0
rodata 113928 113928 0 0.0
text 787276 787252 -24 -0.0
nrf52840dongle_nrf52840 (read/write) 1063955 1063939 -16 -0.0
bss 151388 151388 0 0.0
rodata 91484 91484 0 0.0
text 740016 740000 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1060594 1060578 -16 -0.0
bss 140528 140528 0 0.0
rodata 114744 114744 0 0.0
text 724232 724216 -16 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 1108695 1108663 -32 -0.0
bss 134085 134085 0 0.0
rodata 138936 138936 0 0.0
text 756864 756840 -24 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1012622 1012606 -16 -0.0
bss 130488 130488 0 0.0
rodata 131404 131404 0 0.0
text 669656 669636 -20 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 1069903 1069887 -16 -0.0
bss 134068 134068 0 0.0
rodata 115704 115704 0 0.0
text 741244 741220 -24 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1062487 1062471 -16 -0.0
bss 133845 133845 0 0.0
rodata 114576 114576 0 0.0
text 735232 735208 -24 -0.0
p6 all-clusters-app default (read/write) 2549208 2549208 0 0.0
.bss 143408 143408 0 0.0
.data 2832 2832 0 0.0
.text 1507472 1507472 0 0.0
all-clusters-minimal-app default (read/write) 2494008 2494008 0 0.0
.bss 142616 142616 0 0.0
.data 2776 2776 0 0.0
.text 1452272 1452272 0 0.0
light-app default (read/write) 2425440 2425440 0 0.0
.bss 135728 135728 0 0.0
.data 2624 2624 0 0.0
.text 1383704 1383704 0 0.0
lock-app default (read/write) 2445848 2445848 0 0.0
.bss 135552 135552 0 0.0
.data 2600 2600 0 0.0
.text 1404112 1404112 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786648 786608 -40 -0.0
bss 70860 70860 0 0.0
noinit 40416 40416 0 0.0
text 556600 556560 -40 -0.0
lighting-app tlsr9518adk80d (read/write) 806668 806636 -32 -0.0
bss 71120 71120 0 0.0
noinit 40416 40416 0 0.0
text 573320 573282 -38 -0.0

LuDuda
LuDuda approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 LGTM

@restyled-io restyled-io bot mentioned this pull request Jun 11, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jun 11, 2022 •
edited
Loading

PR #19474: Size comparison from 287e47a to db2d8e1

Increases above 0.2%:

platform target config section 287e47a db2d8e1 change % change
linux all-clusters-app debug (read only) 2907801 2919449 11648 0.4
.data.rel.ro 84200 84520 320 0.4
.rodata 257341 258269 928 0.4
.text 2475410 2485554 10144 0.4
thermostat-no-ble arm64 .got 5048 5080 32 0.6
Increases (49 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 287e47a db2d8e1 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 656295 656375 80 0.0
.bss 73772 73780 8 0.0
.rodata 86511 86527 16 0.0
.text 569472 569536 64 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644779 644867 88 0.0
(read/write) 157268 157276 8 0.0
.bss 72996 73004 8 0.0
.rodata 90019 90035 16 0.0
.text 554440 554512 72 0.0
lock-ftd LP_CC2652R7 (read only) 687651 687739 88 0.0
.bss 71732 71740 8 0.0
.rodata 98843 98859 16 0.0
.text 588324 588396 72 0.0
lock-mtd LP_CC2652R7 (read only) 637059 637139 80 0.0
(read/write) 144864 144872 8 0.0
.bss 67468 67476 8 0.0
.rodata 98723 98739 16 0.0
.text 537844 537908 64 0.0
pump-app LP_CC2652R7 (read only) 669011 669107 96 0.0
.bss 71876 71884 8 0.0
.rodata 86955 86979 24 0.0
.text 581572 581644 72 0.0
pump-controller-app LP_CC2652R7 (read only) 659575 659687 112 0.0
.bss 71980 71988 8 0.0
.rodata 84855 84879 24 0.0
.text 574236 574324 88 0.0
shell LP_CC2652R7 (read only) 686422 686494 72 0.0
.bss 76068 76076 8 0.0
.rodata 109582 109598 16 0.0
.text 576528 576584 56 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 606450 606602 152 0.0
.app_xip_area 464964 465100 136 0.0
.bss 84416 84432 16 0.0
lock cyw930739m2evb_01 (read/write) 603550 603702 152 0.0
.app_xip_area 461920 462056 136 0.0
.bss 84592 84608 16 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611270 611414 144 0.0
.app_xip_area 470712 470840 128 0.0
.bss 83600 83616 16 0.0
efr32 lighting-app BRD4161A (read only) 919200 919280 80 0.0
(read/write) 133424 133432 8 0.0
.bss 131312 131320 8 0.0
.text 919192 919272 80 0.0
BRD4161A+rpc (read only) 953380 953460 80 0.0
(read/write) 150116 150124 8 0.0
.bss 147800 147808 8 0.0
.text 953372 953452 80 0.0
BRD4161A+rs911x (read only) 794276 794396 120 0.0
(read/write) 129708 129716 8 0.0
.bss 127588 127596 8 0.0
.text 794268 794388 120 0.0
lock-app BRD4161A+wf200 (read only) 962636 962700 64 0.0
(read/write) 130052 130060 8 0.0
.bss 127964 127972 8 0.0
.text 962628 962692 64 0.0
window-app BRD4161A (read only) 904256 904336 80 0.0
(read/write) 133504 133512 8 0.0
.bss 131392 131400 8 0.0
.text 904248 904328 80 0.0
esp32 all-clusters-app c3devkit (read only) 1010926 1011022 96 0.0
(read/write) 1482754 1482794 40 0.0
.dram0.bss 69400 69416 16 0.0
.flash.rodata 213216 213240 24 0.0
.flash.text 1010926 1011022 96 0.0
m5stack (read only) 1065355 1065471 116 0.0
(read/write) 484864 484896 32 0.0
.dram0.bss 74920 74936 16 0.0
.flash.rodata 243724 243740 16 0.0
.flash.text 1059971 1060087 116 0.0
k32w light k32w061+release (read/write) 657232 657280 48 0.0
.bss 69732 69748 16 0.0
.text 579672 579704 32 0.0
lock k32w061+release (read/write) 718820 718892 72 0.0
.bss 70164 70180 16 0.0
.text 640856 640912 56 0.0
linux all-clusters-app debug (read only) 2907801 2919449 11648 0.4
(read/write) 188240 188560 320 0.2
.data.rel.ro 84200 84520 320 0.4
.rodata 257341 258269 928 0.4
.text 2475410 2485554 10144 0.4
all-clusters-minimal-app debug (read only) 2769345 2769785 440 0.0
(read/write) 179856 179888 32 0.0
.data.rel.ro 76824 76872 48 0.1
.text 2337618 2337986 368 0.0
bridge-app debug+rpc (read only) 2247705 2248145 440 0.0
(read/write) 158688 158752 64 0.0
.bss 82944 82976 32 0.0
.data.rel.ro 66200 66232 32 0.0
.text 1896690 1897058 368 0.0
chip-tool debug (read only) 9816405 9816789 384 0.0
.text 7868917 7869301 384 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9564036 9564452 416 0.0
.text 7519188 7519604 416 0.0
lighting-app debug+rpc (read only) 2497617 2498073 456 0.0
(read/write) 163384 163416 32 0.0
.data.rel.ro 71128 71176 48 0.1
.text 2122322 2122706 384 0.0
lock-app debug (read only) 2443617 2444073 456 0.0
(read/write) 158456 158488 32 0.0
.data.rel.ro 68088 68120 32 0.0
.text 2059234 2059618 384 0.0
ota-provider-app debug (read only) 2281881 2282321 440 0.0
(read/write) 152656 152688 32 0.0
.data.rel.ro 62424 62456 32 0.1
.text 1923362 1923730 368 0.0
ota-requestor-app debug (read only) 2329409 2329849 440 0.0
(read/write) 155440 155504 64 0.0
.data.rel.ro 64344 64392 48 0.1
.text 1964898 1965266 368 0.0
shell debug (read only) 2599753 2600209 456 0.0
(read/write) 219384 219416 32 0.0
.data.rel.ro 77664 77704 40 0.1
.text 2210690 2211074 384 0.0
thermostat-no-ble arm64 (read only) 2557804 2558364 560 0.0
(read/write) 191329 191409 80 0.0
.bss 99361 99377 16 0.0
.data.rel.ro 82336 82376 40 0.0
.got 5048 5080 32 0.6
.text 2158976 2159376 400 0.0
tv-app debug (read only) 3051249 3051705 456 0.0
(read/write) 289800 289864 64 0.0
.data.rel.ro 78472 78528 56 0.1
.text 2622754 2623138 384 0.0
tv-casting-app debug (read only) 5350353 5350793 440 0.0
(read/write) 232248 232312 64 0.0
.data.rel.ro 135472 135528 56 0.0
.text 4656722 4657090 368 0.0
mbed lock-app CY8CPROTO_062_4343W+release .bss 208980 208988 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1195719 1195803 84 0.0
bss 141583 141591 8 0.0
rodata 155296 155316 20 0.0
text 819852 819920 68 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143351 1143563 212 0.0
bss 140800 140808 8 0.0
rodata 131808 131828 20 0.0
text 791928 791996 68 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1156919 1157019 100 0.0
bss 144157 144165 8 0.0
rodata 122336 122356 20 0.0
text 811500 811572 72 0.0
nrf52840dk_nrf52840+rpc (read/write) 1124999 1125083 84 0.0
bss 144398 144406 8 0.0
rodata 113928 113948 20 0.0
text 787276 787344 68 0.0
nrf52840dongle_nrf52840 (read/write) 1063955 1064055 100 0.0
bss 151388 151396 8 0.0
rodata 91484 91504 20 0.0
text 740016 740088 72 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1060594 1060678 84 0.0
bss 140528 140536 8 0.0
rodata 114744 114764 20 0.0
text 724232 724300 68 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1108695 1108779 84 0.0
bss 134085 134093 8 0.0
rodata 138936 138956 20 0.0
text 756864 756932 68 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1012622 1012706 84 0.0
bss 130488 130496 8 0.0
rodata 131404 131424 20 0.0
text 669656 669720 64 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1069903 1070003 100 0.0
bss 134068 134076 8 0.0
rodata 115704 115724 20 0.0
text 741244 741312 68 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1062487 1062571 84 0.0
bss 133845 133853 8 0.0
rodata 114576 114596 20 0.0
text 735232 735300 68 0.0
p6 all-clusters-app default (read/write) 2549208 2549376 168 0.0
.bss 143408 143416 8 0.0
.text 1507472 1507640 168 0.0
all-clusters-minimal-app default (read/write) 2494008 2494176 168 0.0
.bss 142616 142624 8 0.0
.text 1452272 1452440 168 0.0
light-app default (read/write) 2425440 2425608 168 0.0
.bss 135728 135736 8 0.0
.text 1383704 1383872 168 0.0
lock-app default (read/write) 2445848 2446016 168 0.0
.bss 135552 135560 8 0.0
.text 1404112 1404280 168 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786648 786756 108 0.0
bss 70860 70876 16 0.0
text 556600 556672 72 0.0
lighting-app tlsr9518adk80d (read/write) 806668 806768 100 0.0
bss 71120 71128 8 0.0
text 573320 573386 66 0.0
Decreases (6 builds for cc13x2_26x2, mbed)
platform target config section 287e47a db2d8e1 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 194584 194512 -72 -0.0
lock-ftd LP_CC2652R7 (read/write) 154300 154220 -80 -0.1
pump-app LP_CC2652R7 (read/write) 173852 173764 -88 -0.1
pump-controller-app LP_CC2652R7 (read/write) 183392 183288 -104 -0.1
shell LP_CC2652R7 (read/write) 159952 159888 -64 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2433320 2432808 -512 -0.0
.data 5896 5888 -8 -0.1
.text 1395964 1395452 -512 -0.0
Full report (49 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 287e47a db2d8e1 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 656295 656375 80 0.0
(read/write) 194584 194512 -72 -0.0
.bss 73772 73780 8 0.0
.data 3416 3416 0 0.0
.rodata 86511 86527 16 0.0
.text 569472 569536 64 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644779 644867 88 0.0
(read/write) 157268 157276 8 0.0
.bss 72996 73004 8 0.0
.data 3356 3356 0 0.0
.rodata 90019 90035 16 0.0
.text 554440 554512 72 0.0
lock-ftd LP_CC2652R7 (read only) 687651 687739 88 0.0
(read/write) 154300 154220 -80 -0.1
.bss 71732 71740 8 0.0
.data 3280 3280 0 0.0
.rodata 98843 98859 16 0.0
.text 588324 588396 72 0.0
lock-mtd LP_CC2652R7 (read only) 637059 637139 80 0.0
(read/write) 144864 144872 8 0.0
.bss 67468 67476 8 0.0
.data 3280 3280 0 0.0
.rodata 98723 98739 16 0.0
.text 537844 537908 64 0.0
pump-app LP_CC2652R7 (read only) 669011 669107 96 0.0
(read/write) 173852 173764 -88 -0.1
.bss 71876 71884 8 0.0
.data 3316 3316 0 0.0
.rodata 86955 86979 24 0.0
.text 581572 581644 72 0.0
pump-controller-app LP_CC2652R7 (read only) 659575 659687 112 0.0
(read/write) 183392 183288 -104 -0.1
.bss 71980 71988 8 0.0
.data 3276 3276 0 0.0
.rodata 84855 84879 24 0.0
.text 574236 574324 88 0.0
shell LP_CC2652R7 (read only) 686422 686494 72 0.0
(read/write) 159952 159888 -64 -0.0
.bss 76068 76076 8 0.0
.data 3420 3420 0 0.0
.rodata 109582 109598 16 0.0
.text 576528 576584 56 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 606450 606602 152 0.0
.app_xip_area 464964 465100 136 0.0
.bss 84416 84432 16 0.0
.data 756 756 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 603550 603702 152 0.0
.app_xip_area 461920 462056 136 0.0
.bss 84592 84608 16 0.0
.data 724 724 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611270 611414 144 0.0
.app_xip_area 470712 470840 128 0.0
.bss 83600 83616 16 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919200 919280 80 0.0
(read/write) 133424 133432 8 0.0
.bss 131312 131320 8 0.0
.data 2112 2112 0 0.0
.text 919192 919272 80 0.0
BRD4161A+rpc (read only) 953380 953460 80 0.0
(read/write) 150116 150124 8 0.0
.bss 147800 147808 8 0.0
.data 2316 2316 0 0.0
.text 953372 953452 80 0.0
BRD4161A+rs911x (read only) 794276 794396 120 0.0
(read/write) 129708 129716 8 0.0
.bss 127588 127596 8 0.0
.data 2120 2120 0 0.0
.text 794268 794388 120 0.0
lock-app BRD4161A+wf200 (read only) 962636 962700 64 0.0
(read/write) 130052 130060 8 0.0
.bss 127964 127972 8 0.0
.data 2088 2088 0 0.0
.text 962628 962692 64 0.0
window-app BRD4161A (read only) 904256 904336 80 0.0
(read/write) 133504 133512 8 0.0
.bss 131392 131400 8 0.0
.data 2108 2108 0 0.0
.text 904248 904328 80 0.0
esp32 all-clusters-app c3devkit (read only) 1010926 1011022 96 0.0
(read/write) 1482754 1482794 40 0.0
.dram0.bss 69400 69416 16 0.0
.dram0.data 14696 14696 0 0.0
.flash.rodata 213216 213240 24 0.0
.flash.text 1010926 1011022 96 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1065355 1065471 116 0.0
(read/write) 484864 484896 32 0.0
.dram0.bss 74920 74936 16 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 243724 243740 16 0.0
.flash.text 1059971 1060087 116 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657232 657280 48 0.0
.bss 69732 69748 16 0.0
.data 2028 2028 0 0.0
.text 579672 579704 32 0.0
lock k32w061+release (read/write) 718820 718892 72 0.0
.bss 70164 70180 16 0.0
.data 2000 2000 0 0.0
.text 640856 640912 56 0.0
linux all-clusters-app debug (read only) 2907801 2919449 11648 0.4
(read/write) 188240 188560 320 0.2
.bss 95776 95776 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84200 84520 320 0.4
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 257341 258269 928 0.4
.text 2475410 2485554 10144 0.4
all-clusters-minimal-app debug (read only) 2769345 2769785 440 0.0
(read/write) 179856 179888 32 0.0
.bss 94944 94944 0 0.0
.data 1920 1920 0 0.0
.data.rel.ro 76824 76872 48 0.1
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258685 258685 0 0.0
.text 2337618 2337986 368 0.0
bridge-app debug+rpc (read only) 2247705 2248145 440 0.0
(read/write) 158688 158752 64 0.0
.bss 82944 82976 32 0.0
.data 3760 3760 0 0.0
.data.rel.ro 66200 66232 32 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 191104 191104 0 0.0
.text 1896690 1897058 368 0.0
chip-tool debug (read only) 9816405 9816789 384 0.0
(read/write) 623496 623496 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590696 590696 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 506869 506869 0 0.0
.text 7868917 7869301 384 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9564036 9564452 416 0.0
(read/write) 689841 689841 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626128 626128 0 0.0
.dynamic 528 528 0 0.0
.got 15056 15056 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468756 468756 0 0.0
.text 7519188 7519604 416 0.0
lighting-app debug+rpc (read only) 2497617 2498073 456 0.0
(read/write) 163384 163416 32 0.0
.bss 84288 84288 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71128 71176 48 0.1
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 207176 207176 0 0.0
.text 2122322 2122706 384 0.0
lock-app debug (read only) 2443617 2444073 456 0.0
(read/write) 158456 158488 32 0.0
.bss 82944 82944 0 0.0
.data 1552 1552 0 0.0
.data.rel.ro 68088 68120 32 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 221256 221256 0 0.0
.text 2059234 2059618 384 0.0
ota-provider-app debug (read only) 2281881 2282321 440 0.0
(read/write) 152656 152688 32 0.0
.bss 82624 82624 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 62424 62456 32 0.1
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 197400 197400 0 0.0
.text 1923362 1923730 368 0.0
ota-requestor-app debug (read only) 2329409 2329849 440 0.0
(read/write) 155440 155504 64 0.0
.bss 83328 83328 0 0.0
.data 1976 1976 0 0.0
.data.rel.ro 64344 64392 48 0.1
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 199552 199552 0 0.0
.text 1964898 1965266 368 0.0
shell debug (read only) 2599753 2600209 456 0.0
(read/write) 219384 219416 32 0.0
.bss 134568 134568 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 77664 77704 40 0.1
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229842 229842 0 0.0
.text 2210690 2211074 384 0.0
thermostat-no-ble arm64 (read only) 2557804 2558364 560 0.0
(read/write) 191329 191409 80 0.0
.bss 99361 99377 16 0.0
.data 1560 1560 0 0.0
.data.rel.ro 82336 82376 40 0.0
.dynamic 528 528 0 0.0
.got 5048 5080 32 0.6
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161316 161316 0 0.0
.text 2158976 2159376 400 0.0
tv-app debug (read only) 3051249 3051705 456 0.0
(read/write) 289800 289864 64 0.0
.bss 200200 200200 0 0.0
.data 4688 4688 0 0.0
.data.rel.ro 78472 78528 56 0.1
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 242784 242784 0 0.0
.text 2622754 2623138 384 0.0
tv-casting-app debug (read only) 5350353 5350793 440 0.0
(read/write) 232248 232312 64 0.0
.bss 88072 88072 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 135472 135528 56 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 342432 342432 0 0.0
.text 4656722 4657090 368 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2433320 2432808 -512 -0.0
.bss 208980 208988 8 0.0
.data 5896 5888 -8 -0.1
.text 1395964 1395452 -512 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1195719 1195803 84 0.0
bss 141583 141591 8 0.0
rodata 155296 155316 20 0.0
text 819852 819920 68 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143351 1143563 212 0.0
bss 140800 140808 8 0.0
rodata 131808 131828 20 0.0
text 791928 791996 68 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1156919 1157019 100 0.0
bss 144157 144165 8 0.0
rodata 122336 122356 20 0.0
text 811500 811572 72 0.0
nrf52840dk_nrf52840+rpc (read/write) 1124999 1125083 84 0.0
bss 144398 144406 8 0.0
rodata 113928 113948 20 0.0
text 787276 787344 68 0.0
nrf52840dongle_nrf52840 (read/write) 1063955 1064055 100 0.0
bss 151388 151396 8 0.0
rodata 91484 91504 20 0.0
text 740016 740088 72 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1060594 1060678 84 0.0
bss 140528 140536 8 0.0
rodata 114744 114764 20 0.0
text 724232 724300 68 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1108695 1108779 84 0.0
bss 134085 134093 8 0.0
rodata 138936 138956 20 0.0
text 756864 756932 68 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1012622 1012706 84 0.0
bss 130488 130496 8 0.0
rodata 131404 131424 20 0.0
text 669656 669720 64 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1069903 1070003 100 0.0
bss 134068 134076 8 0.0
rodata 115704 115724 20 0.0
text 741244 741312 68 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1062487 1062571 84 0.0
bss 133845 133853 8 0.0
rodata 114576 114596 20 0.0
text 735232 735300 68 0.0
p6 all-clusters-app default (read/write) 2549208 2549376 168 0.0
.bss 143408 143416 8 0.0
.data 2832 2832 0 0.0
.text 1507472 1507640 168 0.0
all-clusters-minimal-app default (read/write) 2494008 2494176 168 0.0
.bss 142616 142624 8 0.0
.data 2776 2776 0 0.0
.text 1452272 1452440 168 0.0
light-app default (read/write) 2425440 2425608 168 0.0
.bss 135728 135736 8 0.0
.data 2624 2624 0 0.0
.text 1383704 1383872 168 0.0
lock-app default (read/write) 2445848 2446016 168 0.0
.bss 135552 135560 8 0.0
.data 2600 2600 0 0.0
.text 1404112 1404280 168 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786648 786756 108 0.0
bss 70860 70876 16 0.0
noinit 40416 40416 0 0.0
text 556600 556672 72 0.0
lighting-app tlsr9518adk80d (read/write) 806668 806768 100 0.0
bss 71120 71128 8 0.0
noinit 40416 40416 0 0.0
text 573320 573386 66 0.0

@bzbarsky-apple bzbarsky-apple merged commit fdab0fd into project-chip:master Jun 11, 2022
@jmartinez-silabs jmartinez-silabs deleted the thread_eventing branch June 11, 2022 22:04
@jmartinez-silabs jmartinez-silabs mentioned this pull request Jun 14, 2022
Merged
jepenven-silabs pushed a commit to jepenven-silabs/connectedhomeip that referenced this pull request Jun 16, 2022
@jmartinez-silabs @restyled-commits @jepenven-silabs
Rework Thread attachement event and unify implementation (project-chi…
2cdc71a 
…p#19474)

* Rework Thread attachement event and unify the event to the genericThreadStackManager

* replace 0 by false

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
@andy31415 andy31415 mentioned this pull request Nov 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@LuDuda LuDuda Awaiting requested review from LuDuda

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
esp32 openthread platform review - approved zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmartinez-silabs @LuDuda @bzbarsky-apple @jepenven-silabs @restyled-commits