Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix detached thread resource leak if Matter stack is stopped and then… (#15167)" #15399

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Revert "Fix detached thread resource leak if Matter stack is stopped and then… (#15167)" #15399

merged 1 commit into from
Feb 22, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

This reverts commit 6107c13.

PR #15167 was merged with a permanent CI failure (Tsan failures on
Linux), so now nothing can pass CI.

Problem

Broken CI

Change overview

Revert PR causing permanent breakage

Testing

Should be able to pass the Linux Tests CI job now.

@bzbarsky-apple
Revert "Fix detached thread resource leak if Matter stack is stopped …
7e273dc 
…and then… (project-chip#15167)"

This reverts commit 6107c13.

PR project-chip#15167 was merged with a permanent CI failure (Tsan failures on
Linux), so now nothing can pass CI.
@bzbarsky-apple bzbarsky-apple added the hotfix urgent fix needed, can bypass review label Feb 21, 2022
@github-actions
Copy link

github-actions bot commented Feb 21, 2022 •
edited
Loading

PR #15399: Size comparison from f8f54e9 to 7e273dc

Decreases (2 builds for linux)
platform target config section f8f54e9 7e273dc change % change
linux chip-tool-ipv6only arm64 (read only) 8864316 8863980 -336 -0.0
(read/write) 434721 434705 -16 -0.0
.bss 59281 59265 -16 -0.0
.rodata 456548 456468 -80 -0.0
.text 7489364 7489188 -176 -0.0
thermostat-no-ble arm64 (read only) 2175180 2174844 -336 -0.0
(read/write) 151297 151265 -32 -0.0
.bss 67601 67585 -16 -0.0
.rodata 133900 133820 -80 -0.1
.text 1821616 1821440 -176 -0.0
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f8f54e9 7e273dc change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599862 599862 0 0.0
.app_xip_area 503540 503540 0 0.0
.bss 79020 79020 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557906 557906 0 0.0
.app_xip_area 463128 463128 0 0.0
.bss 77516 77516 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 579142 579142 0 0.0
.app_xip_area 474940 474940 0 0.0
.bss 86612 86612 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916644 916644 0 0.0
(read/write) 129760 129760 0 0.0
.bss 127720 127720 0 0.0
.data 2040 2040 0 0.0
.text 916636 916636 0 0.0
BRD4161A+rpc (read only) 945352 945352 0 0.0
(read/write) 146680 146680 0 0.0
.bss 144496 144496 0 0.0
.data 2180 2180 0 0.0
.text 945344 945344 0 0.0
window-app BRD4161A (read only) 850480 850480 0 0.0
(read/write) 127680 127680 0 0.0
.bss 125768 125768 0 0.0
.data 1908 1908 0 0.0
.text 850472 850472 0 0.0
esp32 all-clusters-app c3devkit (read only) 951666 951666 0 0.0
(read/write) 1400210 1400210 0 0.0
.dram0.bss 67208 67208 0 0.0
.dram0.data 14156 14156 0 0.0
.flash.rodata 199944 199944 0 0.0
.flash.text 951666 951666 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 1001291 1001291 0 0.0
(read/write) 465496 465496 0 0.0
.dram0.bss 72360 72360 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226944 226944 0 0.0
.flash.text 995907 995907 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 693072 693072 0 0.0
.bss 78648 78648 0 0.0
.data 1916 1916 0 0.0
.text 606708 606708 0 0.0
lock k32w061+release (read/write) 695612 695612 0 0.0
.bss 78856 78856 0 0.0
.data 1956 1956 0 0.0
.text 609000 609000 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8864316 8863980 -336 -0.0
(read/write) 434721 434705 -16 -0.0
.bss 59281 59265 -16 -0.0
.data 1216 1216 0 0.0
.data.rel.ro 319024 319024 0 0.0
.dynamic 560 560 0 0.0
.got 51392 51392 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456548 456468 -80 -0.0
.text 7489364 7489188 -176 -0.0
thermostat-no-ble arm64 (read only) 2175180 2174844 -336 -0.0
(read/write) 151297 151265 -32 -0.0
.bss 67601 67585 -16 -0.0
.data 1032 1032 0 0.0
.data.rel.ro 75408 75408 0 0.0
.dynamic 560 560 0 0.0
.got 4240 4240 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133900 133820 -80 -0.1
.text 1821616 1821440 -176 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2441028 2441028 0 0.0
.bss 195036 195036 0 0.0
.data 5352 5352 0 0.0
.text 1403600 1403600 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2402204 2402204 0 0.0
.bss 189136 189136 0 0.0
.data 5648 5648 0 0.0
.text 1364776 1364776 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2337720 2337720 0 0.0
.bss 188136 188136 0 0.0
.data 5624 5624 0 0.0
.text 1300320 1300320 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2328612 2328612 0 0.0
.bss 186676 186676 0 0.0
.data 5456 5456 0 0.0
.text 1291184 1291184 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1024007 1024007 0 0.0
bss 123784 123784 0 0.0
rodata 120964 120964 0 0.0
text 700232 700232 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 993283 993283 0 0.0
bss 120972 120972 0 0.0
rodata 112472 112472 0 0.0
text 680136 680136 0 0.0
nrf52840dongle_nrf52840 (read/write) 1038747 1038747 0 0.0
bss 125004 125004 0 0.0
rodata 119796 119796 0 0.0
text 704032 704032 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 930618 930618 0 0.0
bss 120344 120344 0 0.0
rodata 114220 114220 0 0.0
text 615260 615260 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 952743 952743 0 0.0
bss 122012 122012 0 0.0
rodata 109804 109804 0 0.0
text 642324 642324 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 860218 860218 0 0.0
bss 118604 118604 0 0.0
rodata 102972 102972 0 0.0
text 558128 558128 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527567 527567 0 0.0
bss 53632 53632 0 0.0
rodata 49948 49948 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 951319 951319 0 0.0
bss 121732 121732 0 0.0
rodata 108756 108756 0 0.0
text 642144 642144 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 947279 947279 0 0.0
bss 121736 121736 0 0.0
rodata 108452 108452 0 0.0
text 638384 638384 0 0.0
shell nrf52840dk_nrf52840 (read/write) 811587 811587 0 0.0
bss 113324 113324 0 0.0
rodata 79752 79752 0 0.0
text 540852 540852 0 0.0
p6 all-clusters-app default (read/write) 2490928 2490928 0 0.0
.bss 122936 122936 0 0.0
.data 2680 2680 0 0.0
.text 1449192 1449192 0 0.0
light-app default (read/write) 2394888 2394888 0 0.0
.bss 114184 114184 0 0.0
.data 2528 2528 0 0.0
.text 1353152 1353152 0 0.0
lock-app default (read/write) 2358464 2358464 0 0.0
.bss 113936 113936 0 0.0
.data 2488 2488 0 0.0
.text 1316728 1316728 0 0.0
qpg lighting-app qpg6105+debug (read only) 600452 600452 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91200 91200 0 0.0
.data 1116 1116 0 0.0
.text 595132 595132 0 0.0
lock-app qpg6105+debug (read only) 566212 566212 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91208 91208 0 0.0
.data 1068 1068 0 0.0
.text 560892 560892 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883034 883034 0 0.0
bss 87532 87532 0 0.0
noinit 37160 37160 0 0.0
text 623066 623066 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 3666c5b into project-chip:master Feb 22, 2022
@bzbarsky-apple bzbarsky-apple deleted the fix-ci branch February 22, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufengwangca yufengwangca yufengwangca approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
hotfix urgent fix needed, can bypass review linux platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzbarsky-apple @yufengwangca