-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix detached thread resource leak if Matter stack is stopped and then… #15167
Merged
woody-apple
merged 3 commits into
project-chip:master
from
yufengwangca:pr/platform/thread
Feb 21, 2022
Merged
Fix detached thread resource leak if Matter stack is stopped and then… #15167
woody-apple
merged 3 commits into
project-chip:master
from
yufengwangca:pr/platform/thread
Feb 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02 and
mlepage-google
February 14, 2022 21:13
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
February 14, 2022 21:13
PR #15167: Size comparison from d1c7e85 to dbe8234 Increases (11 builds for linux)
Decreases (1 build for linux)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Feb 14, 2022
PR #15167: Size comparison from 6ad78e2 to 0a91871 Increases (11 builds for linux)
Decreases (1 build for linux)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
yunhanw-google
approved these changes
Feb 15, 2022
bzbarsky-apple
approved these changes
Feb 15, 2022
PR #15167: Size comparison from 4beca69 to 75e833f Increases (11 builds for linux)
Decreases (1 build for linux)
Full report (41 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
/rebase |
PR #15167: Size comparison from b9536c8 to b484373 Increases above 0.2%:
Increases (11 builds for linux)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #15167: Size comparison from b9536c8 to 7b827a8 Increases above 0.2%:
Increases (11 builds for linux)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #15167: Size comparison from 11a5b14 to 0fc8b12 Increases (11 builds for linux)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Feb 21, 2022
…and then… (project-chip#15167)" This reverts commit 6107c13. PR project-chip#15167 was merged with a permanent CI failure (Tsan failures on Linux), so now nothing can pass CI.
bzbarsky-apple
added a commit
that referenced
this pull request
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… restarted
Problem
What is being fixed? Examples:
Change overview
Linux platform retain a reference to the spawned working threads
The _Shutdown method signal to the the spawned working threads and then join them
Testing
How was this tested? (at least one bullet point required)