Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bridged Device Basic Information cluster #14768

Merged
merged 20 commits into from
Feb 18, 2022
Merged

Bridged Device Basic Information cluster #14768

merged 20 commits into from
Feb 18, 2022

Conversation

lzgrablic02
Copy link
Contributor

@lzgrablic02 lzgrablic02 commented Feb 4, 2022 •
edited
Loading

Problem

  • Spec conformance.
  • ReachableChanged implementation.

Change overview

XML and ZAP updates.
ReachableChanged implementation.

Testing

How was this tested? (at least one bullet point required)

  • By temporarily re-adding in all-clusters-app and making Reachable writeable:
    • Saw ReachableChanged event in log when writing to Reachable.
    • No event when writing to NodeLabel.

@restyled-io restyled-io bot mentioned this pull request Feb 4, 2022
Closed
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

PR #14768: Size comparison from 792167c to 84e97d2

Full report (9 builds for cyw30739, k32w, qpg, telink)
platform target config section 792167c 84e97d2 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587130 587130 0 0.0
.app_xip_area 493728 493728 0 0.0
.bss 76124 76124 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545046 545046 0 0.0
.app_xip_area 453204 453204 0 0.0
.bss 74596 74596 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569418 569418 0 0.0
.app_xip_area 468256 468256 0 0.0
.bss 83588 83588 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 671632 671632 0 0.0
.bss 75828 75828 0 0.0
.data 1884 1884 0 0.0
.text 588120 588120 0 0.0
lock k32w061+release (read/write) 673220 673220 0 0.0
.bss 76148 76148 0 0.0
.data 1924 1924 0 0.0
.text 589348 589348 0 0.0
qpg lighting-app qpg6105+debug (read only) 579900 579900 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88120 88120 0 0.0
.data 1088 1088 0 0.0
.text 574580 574580 0 0.0
lock-app qpg6105+debug (read only) 525972 525972 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87560 87560 0 0.0
.data 1024 1024 0 0.0
.text 520652 520652 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 858826 858826 0 0.0
bss 88476 88476 0 0.0
noinit 37160 37160 0 0.0
text 601994 601994 0 0.0

@lzgrablic02
Copy link
Contributor Author

Not sure why this built locally with the files misnamed...

@github-actions
Copy link

github-actions bot commented Feb 4, 2022 •
edited
Loading

PR #14768: Size comparison from 792167c to 01bd980

Full report (12 builds for cyw30739, efr32, k32w, qpg, telink)
platform target config section 792167c 01bd980 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587130 587130 0 0.0
.app_xip_area 493728 493728 0 0.0
.bss 76124 76124 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545046 545046 0 0.0
.app_xip_area 453204 453204 0 0.0
.bss 74596 74596 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569418 569418 0 0.0
.app_xip_area 468256 468256 0 0.0
.bss 83588 83588 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 856792 856792 0 0.0
(read/write) 125888 125888 0 0.0
.bss 123960 123960 0 0.0
.data 1924 1924 0 0.0
.text 856784 856784 0 0.0
BRD4161A+rpc (read only) 844168 844168 0 0.0
(read/write) 142544 142544 0 0.0
.bss 140520 140520 0 0.0
.data 2024 2024 0 0.0
.text 844160 844160 0 0.0
window-app BRD4161A (read only) 829012 829012 0 0.0
(read/write) 124524 124524 0 0.0
.bss 122644 122644 0 0.0
.data 1880 1880 0 0.0
.text 829004 829004 0 0.0
k32w light k32w061+release (read/write) 671632 671632 0 0.0
.bss 75828 75828 0 0.0
.data 1884 1884 0 0.0
.text 588120 588120 0 0.0
lock k32w061+release (read/write) 673220 673220 0 0.0
.bss 76148 76148 0 0.0
.data 1924 1924 0 0.0
.text 589348 589348 0 0.0
qpg lighting-app qpg6105+debug (read only) 579900 579900 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88120 88120 0 0.0
.data 1088 1088 0 0.0
.text 574580 574580 0 0.0
lock-app qpg6105+debug (read only) 525972 525972 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87560 87560 0 0.0
.data 1024 1024 0 0.0
.text 520652 520652 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 858826 858826 0 0.0
bss 88476 88476 0 0.0
noinit 37160 37160 0 0.0
text 601994 601994 0 0.0

@github-actions
Copy link

github-actions bot commented Feb 4, 2022 •
edited
Loading

PR #14768: Size comparison from 792167c to 632464e

Increases (5 builds for esp32, linux, mbed, p6)
platform target config section 792167c 632464e change % change
esp32 all-clusters-app c3devkit (read only) 935314 936680 1366 0.1
.flash.rodata 197920 198032 112 0.1
.flash.text 935314 936680 1366 0.1
m5stack (read only) 983359 984699 1340 0.1
.flash.rodata 224532 224648 116 0.1
.flash.text 977975 979315 1340 0.1
linux chip-tool-ipv6only arm64 (read only) 7171332 7171668 336 0.0
.rodata 390508 390524 16 0.0
.text 6179092 6179412 320 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2386968 2388160 1192 0.0
.data 5296 5304 8 0.2
.text 1349568 1350760 1192 0.1
p6 all-clusters-app default (read/write) 2448200 2449744 1544 0.1
.text 1406464 1408008 1544 0.1
Decreases (4 builds for esp32, mbed, p6)
platform target config section 792167c 632464e change % change
esp32 all-clusters-app c3devkit (read/write) 1401162 1399962 -1200 -0.1
.dram0.bss 70056 68752 -1304 -1.9
m5stack (read/write) 465516 464320 -1196 -0.3
.dram0.bss 74816 73504 -1312 -1.8
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 188964 187660 -1304 -0.7
p6 all-clusters-app default .bss 117124 115820 -1304 -1.1
Full report (24 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 792167c 632464e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587130 587130 0 0.0
.app_xip_area 493728 493728 0 0.0
.bss 76124 76124 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545046 545046 0 0.0
.app_xip_area 453204 453204 0 0.0
.bss 74596 74596 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569418 569418 0 0.0
.app_xip_area 468256 468256 0 0.0
.bss 83588 83588 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 856792 856792 0 0.0
(read/write) 125888 125888 0 0.0
.bss 123960 123960 0 0.0
.data 1924 1924 0 0.0
.text 856784 856784 0 0.0
BRD4161A+rpc (read only) 844168 844168 0 0.0
(read/write) 142544 142544 0 0.0
.bss 140520 140520 0 0.0
.data 2024 2024 0 0.0
.text 844160 844160 0 0.0
window-app BRD4161A (read only) 829012 829012 0 0.0
(read/write) 124524 124524 0 0.0
.bss 122644 122644 0 0.0
.data 1880 1880 0 0.0
.text 829004 829004 0 0.0
esp32 all-clusters-app c3devkit (read only) 935314 936680 1366 0.1
(read/write) 1401162 1399962 -1200 -0.1
.dram0.bss 70056 68752 -1304 -1.9
.dram0.data 14276 14276 0 0.0
.flash.rodata 197920 198032 112 0.1
.flash.text 935314 936680 1366 0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 983359 984699 1340 0.1
(read/write) 465516 464320 -1196 -0.3
.dram0.bss 74816 73504 -1312 -1.8
.dram0.data 34040 34040 0 0.0
.flash.rodata 224532 224648 116 0.1
.flash.text 977975 979315 1340 0.1
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 671632 671632 0 0.0
.bss 75828 75828 0 0.0
.data 1884 1884 0 0.0
.text 588120 588120 0 0.0
lock k32w061+release (read/write) 673220 673220 0 0.0
.bss 76148 76148 0 0.0
.data 1924 1924 0 0.0
.text 589348 589348 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7171332 7171668 336 0.0
(read/write) 283441 283441 0 0.0
.bss 47457 47457 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 185656 185656 0 0.0
.dynamic 560 560 0 0.0
.got 45424 45424 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 390508 390524 16 0.0
.text 6179092 6179412 320 0.0
thermostat-no-ble arm64 (read only) 2125964 2125964 0 0.0
(read/write) 140785 140785 0 0.0
.bss 57745 57745 0 0.0
.data 976 976 0 0.0
.data.rel.ro 74928 74928 0 0.0
.dynamic 560 560 0 0.0
.got 4160 4160 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 131292 131292 0 0.0
.text 1776528 1776528 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2386968 2388160 1192 0.0
.bss 188964 187660 -1304 -0.7
.data 5296 5304 8 0.2
.text 1349568 1350760 1192 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2347552 2347552 0 0.0
.bss 181072 181072 0 0.0
.data 5600 5600 0 0.0
.text 1310152 1310152 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2311552 2311552 0 0.0
.bss 180960 180960 0 0.0
.data 5584 5584 0 0.0
.text 1274152 1274152 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2301820 2301820 0 0.0
.bss 178244 178244 0 0.0
.data 5400 5400 0 0.0
.text 1264392 1264392 0 0.0
p6 all-clusters-app default (read/write) 2448200 2449744 1544 0.1
.bss 117124 115820 -1304 -1.1
.data 2584 2584 0 0.0
.text 1406464 1408008 1544 0.1
light-app default (read/write) 2353104 2353104 0 0.0
.bss 106268 106268 0 0.0
.data 2432 2432 0 0.0
.text 1311368 1311368 0 0.0
lock-app default (read/write) 2318288 2318288 0 0.0
.bss 105980 105980 0 0.0
.data 2392 2392 0 0.0
.text 1276552 1276552 0 0.0
qpg lighting-app qpg6105+debug (read only) 579900 579900 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88120 88120 0 0.0
.data 1088 1088 0 0.0
.text 574580 574580 0 0.0
lock-app qpg6105+debug (read only) 525972 525972 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87560 87560 0 0.0
.data 1024 1024 0 0.0
.text 520652 520652 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 858826 858826 0 0.0
bss 88476 88476 0 0.0
noinit 37160 37160 0 0.0
text 601994 601994 0 0.0

@pullapprove pullapprove bot requested a review from anush-apple February 7, 2022 22:41
@github-actions
Copy link

github-actions bot commented Feb 7, 2022 •
edited
Loading

PR #14768: Size comparison from a92d1a8 to 6c92cc4

Increases above 0.2%:

platform target config section a92d1a8 6c92cc4 change % change
linux chip-tool-ipv6only arm64 (read only) 7239588 7263604 24016 0.3
.got 45784 45904 120 0.3
.text 6241972 6264580 22608 0.4
thermostat-no-ble arm64 .rodata 131412 131860 448 0.3
nrfconnect lighting-app nrf52840dk_nrf52840 rodata 117760 118072 312 0.3
nrf52840dk_nrf52840+rpc rodata 109220 109532 312 0.3
nrf52840dongle_nrf52840 rodata 116648 116960 312 0.3
nrf5340dk_nrf5340_cpuapp rodata 111016 111332 316 0.3
lock-app nrf52840dk_nrf52840 rodata 106160 106472 312 0.3
nrf5340dk_nrf5340_cpuapp rodata 99332 99644 312 0.3
pump-controller-app nrf52840dk_nrf52840 rodata 105636 105948 312 0.3
Increases (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a92d1a8 6c92cc4 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 593918 594518 600 0.1
.app_xip_area 499772 500372 600 0.1
lock cyw930739m2evb_01 (read/write) 551846 552422 576 0.1
.app_xip_area 459260 459836 576 0.1
ota-requestor cyw930739m2evb_01 (read/write) 576290 576462 172 0.0
.app_xip_area 474384 474556 172 0.0
efr32 lighting-app BRD4161A (read only) 865236 865884 648 0.1
.text 865228 865876 648 0.1
BRD4161A+rpc (read only) 852692 853356 664 0.1
.text 852684 853348 664 0.1
window-app BRD4161A (read only) 837472 838104 632 0.1
.text 837464 838096 632 0.1
esp32 all-clusters-app c3devkit (read only) 937038 937452 414 0.0
.flash.rodata 198000 198064 64 0.0
.flash.text 937038 937452 414 0.0
m5stack (read only) 985011 985271 260 0.0
.flash.rodata 224608 224664 56 0.0
.flash.text 979627 979887 260 0.0
k32w light k32w061+release (read/write) 678480 678648 168 0.0
.text 594228 594396 168 0.0
lock k32w061+release (read/write) 679948 680532 584 0.1
.text 595328 595912 584 0.1
linux chip-tool-ipv6only arm64 (read only) 7239588 7263604 24016 0.3
(read/write) 287921 288385 464 0.2
.data.rel.ro 186528 186872 344 0.2
.got 45784 45904 120 0.3
.rodata 392780 393132 352 0.1
.text 6241972 6264580 22608 0.4
thermostat-no-ble arm64 (read only) 2127748 2129316 1568 0.1
(read/write) 140561 140625 64 0.0
.bss 57601 57665 64 0.1
.rodata 131412 131860 448 0.3
.text 1778384 1779504 1120 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2389200 2389472 272 0.0
.text 1351800 1352072 272 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2348464 2348928 464 0.0
.text 1311064 1311528 464 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2312384 2312848 464 0.0
.text 1274984 1275448 464 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2302836 2302884 48 0.0
.text 1265408 1265456 48 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1004243 1004827 584 0.1
rodata 117760 118072 312 0.3
text 686260 686540 280 0.0
nrf52840dk_nrf52840+rpc (read/write) 975735 976319 584 0.1
rodata 109220 109532 312 0.3
text 670912 671188 276 0.0
nrf52840dongle_nrf52840 (read/write) 1021063 1021647 584 0.1
rodata 116648 116960 312 0.3
text 691832 692112 280 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 910902 911506 604 0.1
rodata 111016 111332 316 0.3
text 601284 601568 284 0.0
lock-app nrf52840dk_nrf52840 (read/write) 936515 937083 568 0.1
rodata 106160 106472 312 0.3
text 632196 632460 264 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 844010 844594 584 0.1
rodata 99332 99644 312 0.3
text 547996 548260 264 0.0
pump-app nrf52840dk_nrf52840 (read/write) 939131 939331 200 0.0
rodata 106632 106656 24 0.0
text 634536 634704 168 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 934087 934671 584 0.1
rodata 105636 105948 312 0.3
text 630476 630740 264 0.0
shell nrf52840dk_nrf52840 (read/write) 803327 803343 16 0.0
text 535988 536004 16 0.0
p6 all-clusters-app default (read/write) 2450352 2450696 344 0.0
.text 1408616 1408960 344 0.0
light-app default (read/write) 2353784 2354432 648 0.0
.text 1312048 1312696 648 0.0
lock-app default (read/write) 2318984 2319616 632 0.0
.text 1277248 1277880 632 0.0
qpg lighting-app qpg6105+debug (read only) 585492 585960 468 0.1
.text 580172 580640 468 0.1
lock-app qpg6105+debug (read only) 531568 532028 460 0.1
.text 526248 526708 460 0.1
telink lighting-app tlsr9518adk80d (read/write) 865726 865822 96 0.0
text 607342 607738 396 0.1
Decreases (5 builds for esp32, mbed, p6, telink)
platform target config section a92d1a8 6c92cc4 change % change
esp32 all-clusters-app c3devkit (read/write) 1401242 1399338 -1904 -0.1
.dram0.bss 70064 68088 -1976 -2.8
m5stack (read/write) 465592 463664 -1928 -0.4
.dram0.bss 74816 72832 -1984 -2.7
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 188972 186996 -1976 -1.0
p6 all-clusters-app default .bss 117128 115152 -1976 -1.7
telink lighting-app tlsr9518adk80d bss 89208 88592 -616 -0.7
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a92d1a8 6c92cc4 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 593918 594518 600 0.1
.app_xip_area 499772 500372 600 0.1
.bss 76868 76868 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 551846 552422 576 0.1
.app_xip_area 459260 459836 576 0.1
.bss 75340 75340 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576290 576462 172 0.0
.app_xip_area 474384 474556 172 0.0
.bss 84332 84332 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 865236 865884 648 0.1
(read/write) 126620 126620 0 0.0
.bss 124696 124696 0 0.0
.data 1924 1924 0 0.0
.text 865228 865876 648 0.1
BRD4161A+rpc (read only) 852692 853356 664 0.1
(read/write) 143280 143280 0 0.0
.bss 141256 141256 0 0.0
.data 2024 2024 0 0.0
.text 852684 853348 664 0.1
window-app BRD4161A (read only) 837472 838104 632 0.1
(read/write) 125264 125264 0 0.0
.bss 123384 123384 0 0.0
.data 1880 1880 0 0.0
.text 837464 838096 632 0.1
esp32 all-clusters-app c3devkit (read only) 937038 937452 414 0.0
(read/write) 1401242 1399338 -1904 -0.1
.dram0.bss 70064 68088 -1976 -2.8
.dram0.data 14276 14276 0 0.0
.flash.rodata 198000 198064 64 0.0
.flash.text 937038 937452 414 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 985011 985271 260 0.0
(read/write) 465592 463664 -1928 -0.4
.dram0.bss 74816 72832 -1984 -2.7
.dram0.data 34040 34040 0 0.0
.flash.rodata 224608 224664 56 0.0
.flash.text 979627 979887 260 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 678480 678648 168 0.0
.bss 76568 76568 0 0.0
.data 1884 1884 0 0.0
.text 594228 594396 168 0.0
lock k32w061+release (read/write) 679948 680532 584 0.1
.bss 76896 76896 0 0.0
.data 1924 1924 0 0.0
.text 595328 595912 584 0.1
linux chip-tool-ipv6only arm64 (read only) 7239588 7263604 24016 0.3
(read/write) 287921 288385 464 0.2
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 186528 186872 344 0.2
.dynamic 560 560 0 0.0
.got 45784 45904 120 0.3
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 392780 393132 352 0.1
.text 6241972 6264580 22608 0.4
thermostat-no-ble arm64 (read only) 2127748 2129316 1568 0.1
(read/write) 140561 140625 64 0.0
.bss 57601 57665 64 0.1
.data 968 968 0 0.0
.data.rel.ro 74872 74872 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131412 131860 448 0.3
.text 1778384 1779504 1120 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389200 2389472 272 0.0
.bss 188972 186996 -1976 -1.0
.data 5296 5296 0 0.0
.text 1351800 1352072 272 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348464 2348928 464 0.0
.bss 180936 180936 0 0.0
.data 5600 5600 0 0.0
.text 1311064 1311528 464 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312384 2312848 464 0.0
.bss 180824 180824 0 0.0
.data 5584 5584 0 0.0
.text 1274984 1275448 464 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302836 2302884 48 0.0
.bss 178100 178100 0 0.0
.data 5400 5400 0 0.0
.text 1265408 1265456 48 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1004243 1004827 584 0.1
bss 121280 121280 0 0.0
rodata 117760 118072 312 0.3
text 686260 686540 280 0.0
nrf52840dk_nrf52840+rpc (read/write) 975735 976319 584 0.1
bss 117136 117136 0 0.0
rodata 109220 109532 312 0.3
text 670912 671188 276 0.0
nrf52840dongle_nrf52840 (read/write) 1021063 1021647 584 0.1
bss 122644 122644 0 0.0
rodata 116648 116960 312 0.3
text 691832 692112 280 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 910902 911506 604 0.1
bss 117840 117840 0 0.0
rodata 111016 111332 316 0.3
text 601284 601568 284 0.0
lock-app nrf52840dk_nrf52840 (read/write) 936515 937083 568 0.1
bss 119616 119616 0 0.0
rodata 106160 106472 312 0.3
text 632196 632460 264 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 844010 844594 584 0.1
bss 116212 116212 0 0.0
rodata 99332 99644 312 0.3
text 547996 548260 264 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 939131 939331 200 0.0
bss 119368 119368 0 0.0
rodata 106632 106656 24 0.0
text 634536 634704 168 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 934087 934671 584 0.1
bss 119372 119372 0 0.0
rodata 105636 105948 312 0.3
text 630476 630740 264 0.0
shell nrf52840dk_nrf52840 (read/write) 803327 803343 16 0.0
bss 111232 111232 0 0.0
rodata 78532 78532 0 0.0
text 535988 536004 16 0.0
p6 all-clusters-app default (read/write) 2450352 2450696 344 0.0
.bss 117128 115152 -1976 -1.7
.data 2584 2584 0 0.0
.text 1408616 1408960 344 0.0
light-app default (read/write) 2353784 2354432 648 0.0
.bss 106128 106128 0 0.0
.data 2432 2432 0 0.0
.text 1312048 1312696 648 0.0
lock-app default (read/write) 2318984 2319616 632 0.0
.bss 105848 105848 0 0.0
.data 2392 2392 0 0.0
.text 1277248 1277880 632 0.0
qpg lighting-app qpg6105+debug (read only) 585492 585960 468 0.1
(read/write) 146940 146940 0 0.0
.bss 88856 88856 0 0.0
.data 1088 1088 0 0.0
.text 580172 580640 468 0.1
lock-app qpg6105+debug (read only) 531568 532028 460 0.1
(read/write) 146940 146940 0 0.0
.bss 88304 88304 0 0.0
.data 1024 1024 0 0.0
.text 526248 526708 460 0.1
persistent-storage-app qpg6105+debug (read only) 99548 99548 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94228 94228 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 865726 865822 96 0.0
bss 89208 88592 -616 -0.7
noinit 37160 37160 0 0.0
text 607342 607738 396 0.1

@pullapprove pullapprove bot requested a review from lazarkov February 10, 2022 05:19
bzbarsky-apple
bzbarsky-apple approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this got rescoped from the last time I looked at it... it's ok as far as it goes, though I am not sure the indirect "write the attribute that you actually implement yourself" thing is really the right API here....

examples/all-clusters-app/mbed/CMakeLists.txt Outdated Show resolved Hide resolved
...clusters/bridged-device-basic-information-server/bridged-device-basic-information-server.cpp Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Feb 16, 2022 •
edited
Loading

PR #14768: Size comparison from 72896fc to 4fe74c9

Decreases (4 builds for esp32, mbed, p6)
platform target config section 72896fc 4fe74c9 change % change
esp32 all-clusters-app c3devkit (read only) 947660 947632 -28 -0.0
(read/write) 1401170 1399506 -1664 -0.1
.dram0.bss 68296 66928 -1368 -2.0
.flash.rodata 199704 199416 -288 -0.1
.flash.text 947660 947632 -28 -0.0
m5stack (read only) 997411 997375 -36 -0.0
(read/write) 466412 464764 -1648 -0.4
.dram0.bss 73432 72072 -1360 -1.9
.flash.rodata 226788 226500 -288 -0.1
.flash.text 992027 991991 -36 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2428444 2428156 -288 -0.0
.bss 195916 194556 -1360 -0.7
.text 1391016 1390728 -288 -0.0
p6 all-clusters-app default (read/write) 2485928 2485624 -304 -0.0
.bss 124232 122864 -1368 -1.1
.text 1444192 1443888 -304 -0.0
Full report (24 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 72896fc 4fe74c9 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 597326 597326 0 0.0
.app_xip_area 501244 501244 0 0.0
.bss 78780 78780 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 555266 555266 0 0.0
.app_xip_area 460752 460752 0 0.0
.bss 77252 77252 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576378 576378 0 0.0
.app_xip_area 472432 472432 0 0.0
.bss 86356 86356 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914204 914204 0 0.0
(read/write) 129524 129524 0 0.0
.bss 127488 127488 0 0.0
.data 2036 2036 0 0.0
.text 914196 914196 0 0.0
BRD4161A+rpc (read only) 942896 942896 0 0.0
(read/write) 146440 146440 0 0.0
.bss 144264 144264 0 0.0
.data 2176 2176 0 0.0
.text 942888 942888 0 0.0
window-app BRD4161A (read only) 848064 848064 0 0.0
(read/write) 127416 127416 0 0.0
.bss 125512 125512 0 0.0
.data 1904 1904 0 0.0
.text 848056 848056 0 0.0
esp32 all-clusters-app c3devkit (read only) 947660 947632 -28 -0.0
(read/write) 1401170 1399506 -1664 -0.1
.dram0.bss 68296 66928 -1368 -2.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 199704 199416 -288 -0.1
.flash.text 947660 947632 -28 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 997411 997375 -36 -0.0
(read/write) 466412 464764 -1648 -0.4
.dram0.bss 73432 72072 -1360 -1.9
.dram0.data 34064 34064 0 0.0
.flash.rodata 226788 226500 -288 -0.1
.flash.text 992027 991991 -36 -0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 691332 691332 0 0.0
.bss 78384 78384 0 0.0
.data 1912 1912 0 0.0
.text 605236 605236 0 0.0
lock k32w061+release (read/write) 693964 693964 0 0.0
.bss 78600 78600 0 0.0
.data 1952 1952 0 0.0
.text 607612 607612 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8332420 8332420 0 0.0
(read/write) 362609 362609 0 0.0
.bss 58961 58961 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 249368 249368 0 0.0
.dynamic 560 560 0 0.0
.got 49272 49272 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 435804 435804 0 0.0
.text 7133924 7133924 0 0.0
thermostat-no-ble arm64 (read only) 2162268 2162268 0 0.0
(read/write) 150737 150737 0 0.0
.bss 67489 67489 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75024 75024 0 0.0
.dynamic 560 560 0 0.0
.got 4208 4208 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 133580 133580 0 0.0
.text 1810064 1810064 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2428444 2428156 -288 -0.0
.bss 195916 194556 -1360 -0.7
.data 5328 5328 0 0.0
.text 1391016 1390728 -288 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2391644 2391644 0 0.0
.bss 188448 188448 0 0.0
.data 5632 5632 0 0.0
.text 1354216 1354216 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2327080 2327080 0 0.0
.bss 187424 187424 0 0.0
.data 5608 5608 0 0.0
.text 1289680 1289680 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317916 2317916 0 0.0
.bss 185972 185972 0 0.0
.data 5440 5440 0 0.0
.text 1280488 1280488 0 0.0
p6 all-clusters-app default (read/write) 2485928 2485624 -304 -0.0
.bss 124232 122864 -1368 -1.1
.data 2672 2672 0 0.0
.text 1444192 1443888 -304 -0.0
light-app default (read/write) 2392816 2392816 0 0.0
.bss 113912 113912 0 0.0
.data 2528 2528 0 0.0
.text 1351080 1351080 0 0.0
lock-app default (read/write) 2356280 2356280 0 0.0
.bss 113640 113640 0 0.0
.data 2488 2488 0 0.0
.text 1314544 1314544 0 0.0
qpg lighting-app qpg6105+debug (read only) 598816 598816 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90744 90744 0 0.0
.data 1112 1112 0 0.0
.text 593496 593496 0 0.0
lock-app qpg6105+debug (read only) 564440 564440 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90728 90728 0 0.0
.data 1064 1064 0 0.0
.text 559120 559120 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 877618 877618 0 0.0
bss 87520 87520 0 0.0
noinit 37160 37160 0 0.0
text 618038 618038 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit a8cdb57 into project-chip:master Feb 18, 2022
@lzgrablic02 lzgrablic02 deleted the bridged-basic branch February 24, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@harsha-rajendran harsha-rajendran harsha-rajendran approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@lazarkov lazarkov Awaiting requested review from lazarkov

Assignees
No one assigned
Labels
app controller darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lzgrablic02 @harsha-rajendran @yufengwangca @bzbarsky-apple