Skip to content

Commit

Permalink
Set SYSTEM_VERSION_COMPAT=0 to fix mac whl install (#30424)
Browse files Browse the repository at this point in the history
Co-authored-by: Andrei Litvin <[email protected]>
  • Loading branch information
2 people authored and pull[bot] committed Nov 16, 2023
1 parent 2863215 commit 1350760
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions scripts/build_python.sh
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,20 @@ echo "Input values: chip_detail_logging = $chip_detail_logging , chip_mdns = \"$
# Ensure we have a compilation environment
source "$CHIP_ROOT/scripts/activate.sh"

# This is to prevent python compiled for previous versions reporting 10.16 as a version
# which breaks the ability to install python wheels.
#
# See https://eclecticlight.co/2020/08/13/macos-version-numbering-isnt-so-simple/ for
# some explanation
#
# TLDR:
#
# > import platform
# > print(platform.mac_ver()[0])
# 11.7.3 // (example) if SYSTEM_VERSION_COMPAT is 0
# 10.16 // SYSTEM_VERSION_COMPAT is unset or 1
export SYSTEM_VERSION_COMPAT=0

# Generates ninja files
[[ -n "$chip_mdns" ]] && chip_mdns_arg="chip_mdns=\"$chip_mdns\"" || chip_mdns_arg=""
[[ -n "$chip_case_retry_delta" ]] && chip_case_retry_arg="chip_case_retry_delta=$chip_case_retry_delta" || chip_case_retry_arg=""
Expand Down

0 comments on commit 1350760

Please sign in to comment.