Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[shell] Add 'server' command to shell app. (#13060)" #13368

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Revert "[shell] Add 'server' command to shell app. (#13060)" #13368

merged 1 commit into from
Jan 7, 2022

Conversation

andy31415
Copy link
Contributor

This reverts commit 6bfde31.

Problem

It seems like the darwin build is broken on ToT, likely due to failing to clean all resources during some tests.

Change overview

Reverts #13060

Testing

CI will validate

@github-actions
Copy link

github-actions bot commented Jan 7, 2022 •
edited
Loading

PR #13368: Size comparison from b81facc to ebc272a

Increases above 0.2%:

platform target config section b81facc ebc272a change % change
esp32 all-clusters-app m5stack (read only) 946699 951095 4396 0.5
(read/write) 440928 445768 4840 1.1
.dram0.bss 72232 74048 1816 2.5
.flash.rodata 203624 206648 3024 1.5
.flash.text 941315 945711 4396 0.5
Increases (1 build for esp32)
platform target config section b81facc ebc272a change % change
esp32 all-clusters-app m5stack (read only) 946699 951095 4396 0.5
(read/write) 440928 445768 4840 1.1
.dram0.bss 72232 74048 1816 2.5
.flash.rodata 203624 206648 3024 1.5
.flash.text 941315 945711 4396 0.5
Decreases (24 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b81facc ebc272a change % change
efr32 lighting-app BRD4161A (read only) 830576 830528 -48 -0.0
(read/write) 127096 127088 -8 -0.0
.bss 125216 125208 -8 -0.0
.text 830568 830520 -48 -0.0
BRD4161A+rpc (read only) 817772 817692 -80 -0.0
(read/write) 143752 143744 -8 -0.0
.bss 141776 141768 -8 -0.0
.text 817764 817684 -80 -0.0
window-app BRD4161A (read only) 804024 803960 -64 -0.0
(read/write) 126032 126024 -8 -0.0
.bss 124200 124192 -8 -0.0
.text 804016 803952 -64 -0.0
esp32 all-clusters-app c3devkit (read only) 891298 891278 -20 -0.0
.flash.text 891298 891278 -20 -0.0
k32w light k32w061+release (read/write) 649288 649248 -40 -0.0
.bss 76240 76232 -8 -0.0
.text 565344 565312 -32 -0.0
lock k32w061+release (read/write) 634104 634064 -40 -0.0
.bss 75944 75936 -8 -0.0
.text 550500 550468 -32 -0.0
linux thermostat-no-ble arm64 (read only) 2026956 2026876 -80 -0.0
.text 1685200 1685120 -80 -0.0
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2330160 2330088 -72 -0.0
.text 1292760 1292688 -72 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2303312 2303248 -64 -0.0
.text 1265912 1265848 -64 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2054200 2053888 -312 -0.0
.text 1016800 1016488 -312 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 936687 936671 -16 -0.0
bss 118208 118200 -8 -0.0
text 632700 632696 -4 -0.0
nrf52840dk_nrf52840+rpc (read/write) 922147 922131 -16 -0.0
bss 115252 115244 -8 -0.0
text 628052 628048 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 847666 847634 -32 -0.0
bss 116100 116092 -8 -0.0
text 549640 549636 -4 -0.0
lock-app nrf52840dk_nrf52840 bss 117396 117388 -8 -0.0
text 610576 610568 -8 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820006 819986 -20 -0.0
bss 115316 115308 -8 -0.0
rodata 96720 96716 -4 -0.0
text 527552 527544 -8 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 910111 910063 -48 -0.0
bss 117156 117148 -8 -0.0
text 611788 611780 -8 -0.0
pump-controller-app nrf52840dk_nrf52840 bss 117184 117176 -8 -0.0
text 609324 609316 -8 -0.0
shell nrf52840dk_nrf52840 (read/write) 797543 796843 -700 -0.1
bss 109680 109536 -144 -0.1
text 533180 532664 -516 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 710362 709670 -692 -0.1
bss 107568 107424 -144 -0.1
text 450860 450340 -520 -0.1
p6 light-app default (read/write) 2325656 2325640 -16 -0.0
.text 1283920 1283904 -16 -0.0
lock-app default (read/write) 2297856 2297840 -16 -0.0
.text 1256120 1256104 -16 -0.0
qpg lighting-app qpg6105+debug (read only) 532452 532424 -28 -0.0
.bss 86696 86688 -8 -0.0
.text 527132 527104 -28 -0.0
lock-app qpg6105+debug (read only) 504232 504204 -28 -0.0
.bss 85832 85824 -8 -0.0
.text 498912 498884 -28 -0.0
telink lighting-app tlsr9518adk80d (read/write) 834110 833298 -812 -0.1
bss 87020 86864 -156 -0.2
text 582188 581554 -634 -0.1
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b81facc ebc272a change % change
efr32 lighting-app BRD4161A (read only) 830576 830528 -48 -0.0
(read/write) 127096 127088 -8 -0.0
.bss 125216 125208 -8 -0.0
.data 1876 1876 0 0.0
.text 830568 830520 -48 -0.0
BRD4161A+rpc (read only) 817772 817692 -80 -0.0
(read/write) 143752 143744 -8 -0.0
.bss 141776 141768 -8 -0.0
.data 1976 1976 0 0.0
.text 817764 817684 -80 -0.0
window-app BRD4161A (read only) 804024 803960 -64 -0.0
(read/write) 126032 126024 -8 -0.0
.bss 124200 124192 -8 -0.0
.data 1832 1832 0 0.0
.text 804016 803952 -64 -0.0
esp32 all-clusters-app c3devkit (read only) 891298 891278 -20 -0.0
(read/write) 1314178 1314178 0 0.0
.dram0.bss 69552 69552 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 177336 177336 0 0.0
.flash.text 891298 891278 -20 -0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 946699 951095 4396 0.5
(read/write) 440928 445768 4840 1.1
.dram0.bss 72232 74048 1816 2.5
.dram0.data 34064 34064 0 0.0
.flash.rodata 203624 206648 3024 1.5
.flash.text 941315 945711 4396 0.5
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 649288 649248 -40 -0.0
.bss 76240 76232 -8 -0.0
.data 1904 1904 0 0.0
.text 565344 565312 -32 -0.0
lock k32w061+release (read/write) 634104 634064 -40 -0.0
.bss 75944 75936 -8 -0.0
.data 1860 1860 0 0.0
.text 550500 550468 -32 -0.0
linux chip-tool-ipv6only arm64 (read only) 7033996 7033996 0 0.0
(read/write) 325073 325073 0 0.0
.bss 54241 54241 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209064 209064 0 0.0
.dynamic 560 560 0 0.0
.got 56992 56992 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 384292 384292 0 0.0
.text 5956932 5956932 0 0.0
thermostat-no-ble arm64 (read only) 2026956 2026876 -80 -0.0
(read/write) 144193 144193 0 0.0
.bss 64033 64033 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72392 72392 0 0.0
.dynamic 560 560 0 0.0
.got 3952 3952 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128844 128844 0 0.0
.text 1685200 1685120 -80 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348264 2348264 0 0.0
.bss 188812 188812 0 0.0
.data 5312 5312 0 0.0
.text 1310840 1310840 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330160 2330088 -72 -0.0
.bss 180632 180632 0 0.0
.data 5552 5552 0 0.0
.text 1292760 1292688 -72 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303312 2303248 -64 -0.0
.bss 179680 179680 0 0.0
.data 5544 5544 0 0.0
.text 1265912 1265848 -64 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054200 2053888 -312 -0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016800 1016488 -312 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 936687 936671 -16 -0.0
bss 118208 118200 -8 -0.0
rodata 108220 108220 0 0.0
text 632700 632696 -4 -0.0
nrf52840dk_nrf52840+rpc (read/write) 922147 922131 -16 -0.0
bss 115252 115244 -8 -0.0
rodata 100664 100664 0 0.0
text 628052 628048 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 847666 847634 -32 -0.0
bss 116100 116092 -8 -0.0
rodata 101396 101396 0 0.0
text 549640 549636 -4 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 908831 908831 0 0.0
bss 117396 117388 -8 -0.0
rodata 103492 103492 0 0.0
text 610576 610568 -8 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820006 819986 -20 -0.0
bss 115316 115308 -8 -0.0
rodata 96720 96716 -4 -0.0
text 527552 527544 -8 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 910111 910063 -48 -0.0
bss 117156 117148 -8 -0.0
rodata 103708 103708 0 0.0
text 611788 611780 -8 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 906911 906911 0 0.0
bss 117184 117176 -8 -0.0
rodata 102964 102964 0 0.0
text 609324 609316 -8 -0.0
shell nrf52840dk_nrf52840 (read/write) 797543 796843 -700 -0.1
bss 109680 109536 -144 -0.1
rodata 78188 78188 0 0.0
text 533180 532664 -516 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 710362 709670 -692 -0.1
bss 107568 107424 -144 -0.1
rodata 72492 72492 0 0.0
text 450860 450340 -520 -0.1
p6 all-clusters-app default (read/write) 2403672 2403672 0 0.0
.bss 117020 117020 0 0.0
.data 2592 2592 0 0.0
.text 1361936 1361936 0 0.0
light-app default (read/write) 2325656 2325640 -16 -0.0
.bss 105888 105888 0 0.0
.data 2384 2384 0 0.0
.text 1283920 1283904 -16 -0.0
lock-app default (read/write) 2297856 2297840 -16 -0.0
.bss 104768 104768 0 0.0
.data 2336 2336 0 0.0
.text 1256120 1256104 -16 -0.0
qpg lighting-app qpg6105+debug (read only) 532452 532424 -28 -0.0
(read/write) 146936 146936 0 0.0
.bss 86696 86688 -8 -0.0
.data 1004 1004 0 0.0
.text 527132 527104 -28 -0.0
lock-app qpg6105+debug (read only) 504232 504204 -28 -0.0
(read/write) 146940 146940 0 0.0
.bss 85832 85824 -8 -0.0
.data 952 952 0 0.0
.text 498912 498884 -28 -0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 834110 833298 -812 -0.1
bss 87020 86864 -156 -0.2
noinit 37160 37160 0 0.0
text 582188 581554 -634 -0.1

@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Jan 7, 2022
@andy31415 andy31415 mentioned this pull request Jan 7, 2022
Merged
@andy31415 andy31415 merged commit 16bdace into project-chip:master Jan 7, 2022
@andy31415 andy31415 mentioned this pull request Jan 7, 2022
Merged
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@andy31415 @step0035
Revert "[shell] Add 'server' command to shell app. (project-chip#13060)…
680519f 
…" (project-chip#13368)

This reverts commit 6bfde31.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app examples github hotfix urgent fix needed, can bypass review lib review - pending transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andy31415