[shell] Add 'server' command to shell app. #13060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turon
changed the title
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt and
jelderton
|
This stale pull request has been automatically closed. Thank you for your contributions. |
|
This has been ready-to-go. Hopefully we can muster enough reviewers to approve and merge it. |
|
PR #13060: Size comparison from b006321 to 372a86d Increases (25 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (1 build for esp32)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
PR #13060: Size comparison from c7d9ec9 to fa00f57 Increases (25 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (1 build for esp32)
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
LuDuda
approved these changes
Jan 5, 2022
saurabhst
approved these changes
Jan 5, 2022
- Add 'server port' and 'server udcport' commands. - Add 'server sessions' command. - Add 'server endpoints' and 'server clusters' commands. - Add docs for the new 'server' command subcommands (README_SERVER.md). - Add 'server' command to build of linux and mac platforms only initially. - Improve clean exit paths for 'server' command. - Update 'ForEachSessionHandle' to use new Loop construct. - Fix build failure in ota-provider (warning when logs disabled).
Co-authored-by: Łukasz Duda <[email protected]>
|
PR #13060: Size comparison from 89b87f1 to 74f1607 Increases (19 builds for efr32, k32w, linux, nrfconnect, qpg, telink)
Full report (24 builds for efr32, k32w, linux, nrfconnect, p6, qpg, telink)
|
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
Jan 7, 2022
This reverts commit 6bfde31.
andy31415
added a commit
that referenced
this pull request
Jan 7, 2022
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
* [shell] Add command to start/stop zcl app server. - Add 'server port' and 'server udcport' commands. - Add 'server sessions' command. - Add 'server endpoints' and 'server clusters' commands. - Add docs for the new 'server' command subcommands (README_SERVER.md). - Add 'server' command to build of linux and mac platforms only initially. - Improve clean exit paths for 'server' command. - Update 'ForEachSessionHandle' to use new Loop construct. - Fix build failure in ota-provider (warning when logs disabled). * [shell] Correct order of atexit and shutdown handling. * [shell] Add OTA stubs. * Apply suggestions from code review Co-authored-by: Łukasz Duda <[email protected]> * [session] Update ForEachSessionHandle to new API. Co-authored-by: Łukasz Duda <[email protected]>
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
…" (project-chip#13368) This reverts commit 6bfde31.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The shell app has limited functionality. It doesn't provide access to core device functionality such as pairing or IM/ZCL command handling.
Change overview
Adds the server command to provide the ability to
server startorserver stopthe equivalent of the all-clusters-app peripheral. Once the server is started, one can pair the device with chip-tool and send commands to it.One can examine what sessions are active with the
server sessionscommand. The ZCL structure can be inspected with theserver endpointsandserver clusterscommands.This work is an incremental step towards instrumenting early multi-device topology testing, such as using a
chip-toolorchip-replcontroller to manage two server nodes where each server is on a different port. This model could provide a flexible basis for scripted functional tests where each node ischip-shellrunning in a process to serve as a simulated server node, and a collection of such nodes can form a topology for more advanced N-node tests.The work is also a step toward making the chip-shell capable of being either a client or a server (or potentially both with enough rework of the core).
Testing
Local testing on linux and darwin.
CI for other embedded builds.