Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(*): bump to rust toolchain 1.73 #679

Merged
merged 2 commits into from
Nov 16, 2023
Merged

chore(*): bump to rust toolchain 1.73 #679

merged 2 commits into from
Nov 16, 2023

Conversation

kate-goldenring
Copy link
Contributor

What this PR does / why we need it:

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

@kate-goldenring kate-goldenring mentioned this pull request Nov 16, 2023
Merged
@kate-goldenring
Copy link
Contributor Author

/version patch

@github-actions github-actions bot added the version/patch Patch version change is needed label Nov 16, 2023
@bindsi
Copy link

bindsi commented Nov 16, 2023

@kate-goldenring updated the akri-docs PR to use 1.73.0 as well: project-akri/akri-docs#104

@kate-goldenring kate-goldenring removed the version/patch Patch version change is needed label Nov 16, 2023
@kate-goldenring
Copy link
Contributor Author

/version patch

@github-actions github-actions bot added the version/patch Patch version change is needed label Nov 16, 2023
@github-actions
Update patch version
59a0bb0 
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kate-goldenring kate-goldenring merged commit a0a173c into project-akri:main Nov 16, 2023
3 checks passed
@kate-goldenring kate-goldenring deleted the bump-rust-version branch November 16, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsonshih johnsonshih johnsonshih approved these changes

@bfjelds bfjelds Awaiting requested review from bfjelds bfjelds is a code owner

@jiria jiria Awaiting requested review from jiria jiria is a code owner

@Britel Britel Awaiting requested review from Britel Britel is a code owner

@romoh romoh Awaiting requested review from romoh romoh is a code owner

@adithyaj adithyaj Awaiting requested review from adithyaj adithyaj is a code owner

@diconico07 diconico07 Awaiting requested review from diconico07 diconico07 is a code owner

Assignees
No one assigned
Labels
version/patch Patch version change is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kate-goldenring @bindsi @johnsonshih