Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing dependency and updated cargo version #104

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

bindsi
Copy link
Contributor

@bindsi bindsi commented Nov 6, 2023

  • updated cargo version in the toolchain install instruction to version 1.70 as it is required by cargo-generate which is used to create a discovery-handler project from a template
  • added "html" package import to the Go module for the http server because it is required as dependency in the build step (docker build)

@bindsi
Copy link
Contributor Author

bindsi commented Nov 13, 2023

@diconico07 thanks for your approval. Who is gonna merge this?

@diconico07
Copy link
Contributor

@bindsi , I will in a few days, or some other maintainers if they take a look before that. We tend to let a bit of time for other reviewers to have another look before merging after an approval.

Copy link
Contributor

@johnsonshih johnsonshih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the akri repo setup.sh still use 1.68.1, do we need to update rust version in code repo, too?

@bindsi
Copy link
Contributor Author

bindsi commented Nov 14, 2023

the akri repo setup.sh still use 1.68.1, do we need to update rust version in code repo, too?

@johnsonshih: yeah, you are right...but I see that it is not compiling with 1.70 because dependencies require 1.68.1 and are tightly coupled to that version by the cargo.lock checked in in codebase...mmh, wondering if I should create an issue for that and trying to resolve it...wdyt?

@johnsonshih
Copy link
Contributor

johnsonshih commented Nov 14, 2023

the akri repo setup.sh still use 1.68.1, do we need to update rust version in code repo, too?

@johnsonshih: yeah, you are right...but I see that it is not compiling with 1.70 because dependencies require 1.68.1 and are tightly coupled to that version by the cargo.lock checked in in codebase...mmh, wondering if I should create an issue for that and trying to resolve it...wdyt?

please create an issue to keep track of the problem, thanks!
BTW, for the Cargo.lock issue, remove the Cargo.lock file or run 'cargo update' should help.

@kate-goldenring
Copy link
Collaborator

created a pr to bump to latest rust version for Akri: project-akri/akri#679

@kate-goldenring kate-goldenring merged commit 210bbf2 into project-akri:main Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants