Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Onvif discovery handler authenticated discovery #638

Merged

Conversation

johnsonshih
Copy link
Contributor

@johnsonshih johnsonshih commented Jul 29, 2023

What this PR does / why we need it:
refs #250
This PR enable Onvif DH to discover devices that require authentication. The schema of secret data is described in the doc PR
project-akri/akri-docs#78

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

Signed-off-by: Johnson Shih <[email protected]>
Signed-off-by: Johnson Shih <[email protected]>
@johnsonshih johnsonshih merged commit 4b60822 into project-akri:main Aug 9, 2023
50 checks passed
@johnsonshih johnsonshih deleted the user/jshih/onvif-auth-discovery-pr branch August 9, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants