-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal for onvif secret data schema #78
proposal for onvif secret data schema #78
Conversation
Signed-off-by: Johnson Shih <[email protected]>
Signed-off-by: Johnson Shih <[email protected]>
I'd add a way to add some default value to this, the rationale is while a default/unique password kind of defeat the purpose of authentication, it can make sense for device onboarding where they all come with a default factory set password. I'd also add a device property indicating from where the authentication information comes from (the device property key ? and if it is default credentials), it would allow a workload to know where to find the right credentials. |
Signed-off-by: Johnson Shih <[email protected]>
Add default credential support. |
The main idea is, with your proposal a broker have to implement the exact same precedence between all sources, adding that property allows a broker to directly use the right source and it may ease debugging as well, as the credential source is shown. I agree that it's mostly a convenience property. I won't block the proposal for this, it can be added later if we want to. |
Propose a schema of secret information in discoveryProperties passed to Onvif DiscoveryHandler
related to project-akri/akri#250