Refactorings from issue 174 #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build kepka 1.0.257-uegmubpe completed (commit d02176919b by @leha-bot) |
leha-bot
force-pushed
the
refactorings-from-issue-174
branch
from
61952e8
to
07567ad
Compare
Inspired by upstream commit telegramdesktop/tdesktop@ffc20e4 Related to #174
Related to #174. Partially inspired by telegramdesktop/tdesktop@ffc20e4
Also add missing headers to the lots of files (they were in structs.h, but we reduce dependencies). Related to #174.
Related to #174.
It should reduce compile times. Related to #174.
See https://doc.qt.io/QT-5/qregularexpression.html#PatternOption-enum about deprecated QRegularExpression enum values.
leha-bot
force-pushed
the
refactorings-from-issue-174
branch
from
07567ad
to
05ce42e
Compare
|
✅ Build kepka 1.0.257-belfuaic completed (commit f5ba2ece04 by @leha-bot) |
crackedmind
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially closes one subtask from issue 174 (cherry-pick commit ffc20e4 )
The remaining things are:
It would be transferred to separate issue #240