Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt upstream code reorganisings #174

Open
3 tasks
leha-bot opened this issue Aug 3, 2018 · 1 comment
Open
3 tasks

Adopt upstream code reorganisings #174

leha-bot opened this issue Aug 3, 2018 · 1 comment
Assignees
@leha-bot
Labels
category:Infrastructure Related to build tools, automation category:Refactoring Related to code refactoring category:Sync Reduce disparity with upstream code category:To do Need to finish/follow up category:Upstream Add feature from upstream

Comments

@leha-bot
Copy link
Member

leha-bot commented Aug 3, 2018 •
edited
Loading

For better backporting I suggest to adopt the good (as I think) code refactorings from upstream.
NB: We should not blindly cherry-pick these commits, because some upstream commits are ambigious and contain more than one logical change:

This list will be updating soon.
@leha-bot leha-bot self-assigned this Aug 3, 2018
@leha-bot leha-bot added category:Infrastructure Related to build tools, automation category:Refactoring Related to code refactoring category:Upstream Add feature from upstream category:Sync Reduce disparity with upstream code labels Aug 3, 2018
@Randl
Copy link
Contributor

Randl commented Aug 3, 2018

@leha-bot имхо есть серьезная проблема с бекпортингом сейчас

@leha-bot leha-bot added the category:To do Need to finish/follow up label Aug 4, 2018
@leha-bot leha-bot pinned this issue Mar 2, 2019
leha-bot added a commit that referenced this issue Apr 4, 2019
@leha-bot
Extract PhotoData to new file
94682f3 
Inspired by upstream commit telegramdesktop/tdesktop@ffc20e4
Related to #174
leha-bot added a commit that referenced this issue Apr 26, 2019
@leha-bot
Extract PhotoData to new file
966c7ff 
Inspired by upstream commit telegramdesktop/tdesktop@ffc20e4
Related to #174
leha-bot added a commit that referenced this issue Jun 28, 2019
@leha-bot
Extract PhotoData to new file
f2baf84 
Inspired by upstream commit telegramdesktop/tdesktop@ffc20e4
Related to #174
leha-bot added a commit that referenced this issue Jul 23, 2019
@leha-bot
Extract PhotoData to new file
038c1dc 
Inspired by upstream commit telegramdesktop/tdesktop@ffc20e4
Related to #174
leha-bot added a commit that referenced this issue Jul 23, 2019
@leha-bot
Extract some basic data definitions to data/data_types
02e4480 
Related to #174.
Partially inspired by telegramdesktop/tdesktop@ffc20e4
leha-bot added a commit that referenced this issue Jul 24, 2019
@leha-bot
layerwidget: drop #include "structs.h"
7eba66a 
Also add missing headers to the lots of files (they were in structs.h,
but we reduce dependencies).
Related to #174.
leha-bot added a commit that referenced this issue Jul 24, 2019
@leha-bot
Extract GameData
95210a8 
Related to #174.
leha-bot added a commit that referenced this issue Jul 24, 2019
@leha-bot
Extract DocumentData and some related types to data/data_document.h
d09b984 
Related to #174.
leha-bot added a commit that referenced this issue Jul 24, 2019
@leha-bot
Extract GameData
d2494d8 
Related to #174.
leha-bot added a commit that referenced this issue Jul 24, 2019
@leha-bot
Extract DocumentData and some related types to data/data_document.h
ed447e9 
Related to #174.
leha-bot added a commit that referenced this issue Jul 24, 2019
@leha-bot
Drop some cyclic #include's of structs.h
a2ec3a2 
It should reduce compile times.
Related to #174.
leha-bot added a commit that referenced this issue Jul 24, 2019
@leha-bot
Extract PhotoData to new file
55312d5 
Inspired by upstream commit telegramdesktop/tdesktop@ffc20e4
Related to #174
leha-bot added a commit that referenced this issue Jul 24, 2019
@leha-bot
Extract some basic data definitions to data/data_types
7c8a343 
Related to #174.
Partially inspired by telegramdesktop/tdesktop@ffc20e4
leha-bot added a commit that referenced this issue Jul 24, 2019
@leha-bot
layerwidget: drop #include "structs.h"
bc37645 
Also add missing headers to the lots of files (they were in structs.h,
but we reduce dependencies).
Related to #174.
leha-bot added a commit that referenced this issue Jul 24, 2019
@leha-bot
Extract GameData
dbd82c0 
Related to #174.
leha-bot added a commit that referenced this issue Jul 24, 2019
@leha-bot
Extract DocumentData and some related types to data/data_document.h
204f936 
Related to #174.
leha-bot added a commit that referenced this issue Jul 24, 2019
@leha-bot
Drop some cyclic #include's of structs.h
c8c142c 
It should reduce compile times.
Related to #174.
leha-bot added a commit that referenced this issue Jul 24, 2019
@leha-bot
Extract PhotoData to new file
90e334d 
Inspired by upstream commit telegramdesktop/tdesktop@ffc20e4
Related to #174
leha-bot added a commit that referenced this issue Jul 24, 2019
@leha-bot
Extract some basic data definitions to data/data_types
8b03593 
Related to #174.
Partially inspired by telegramdesktop/tdesktop@ffc20e4
leha-bot added a commit that referenced this issue Jul 24, 2019
@leha-bot
layerwidget: drop #include "structs.h"
e28af6e 
Also add missing headers to the lots of files (they were in structs.h,
but we reduce dependencies).
Related to #174.
leha-bot added a commit that referenced this issue Jul 24, 2019
@leha-bot
Extract GameData
eb0ae95 
Related to #174.
leha-bot added a commit that referenced this issue Jul 24, 2019
@leha-bot
Extract DocumentData and some related types to data/data_document.h
493d9ac 
Related to #174.
leha-bot added a commit that referenced this issue Jul 24, 2019
@leha-bot
Drop some cyclic #include's of structs.h
10972f6 
It should reduce compile times.
Related to #174.
@leha-bot leha-bot mentioned this issue Jul 24, 2019
Open
4 tasks
@leha-bot leha-bot unpinned this issue Aug 5, 2019
leha-bot added a commit that referenced this issue Aug 7, 2019
@leha-bot
Extract PhotoData to new file
cd008f2 
Inspired by upstream commit telegramdesktop/tdesktop@ffc20e4
Related to #174
leha-bot added a commit that referenced this issue Aug 7, 2019
@leha-bot
Extract some basic data definitions to data/data_types
620d463 
Related to #174.
Partially inspired by telegramdesktop/tdesktop@ffc20e4
leha-bot added a commit that referenced this issue Aug 7, 2019
@leha-bot
layerwidget: drop #include "structs.h"
0e1f7d1 
Also add missing headers to the lots of files (they were in structs.h,
but we reduce dependencies).
Related to #174.
leha-bot added a commit that referenced this issue Aug 7, 2019
@leha-bot
Extract GameData
5e0724a 
Related to #174.
leha-bot added a commit that referenced this issue Aug 7, 2019
@leha-bot
Extract DocumentData and some related types to data/data_document.h
94d2d07 
Related to #174.
leha-bot added a commit that referenced this issue Aug 7, 2019
@leha-bot
Drop some cyclic #include's of structs.h
7a88eed 
It should reduce compile times.
Related to #174.
leha-bot added a commit that referenced this issue Aug 18, 2019
@leha-bot
structs.h: move rest of chat/peer related structs to data_peer.h
6336901 
Related to #174 and #240.
Partially inspired by upstream commit telegramdesktop/tdesktop@ffc20e4
leha-bot added a commit that referenced this issue Aug 18, 2019
@leha-bot
structs.h: move rest of chat/peer related structs to data_peer.h
559a584 
Related to #174 and #240.
Partially inspired by upstream commit telegramdesktop/tdesktop@ffc20e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leha-bot leha-bot

Labels
category:Infrastructure Related to build tools, automation category:Refactoring Related to code refactoring category:Sync Reduce disparity with upstream code category:To do Need to finish/follow up category:Upstream Add feature from upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Randl @leha-bot