Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

Specs and tests for SLT and SGT opcodes#95

Merged
ed255 merged 7 commits into
privacy-ethereum:masterfrom
scroll-tech:feat/signed-comparator
Jan 20, 2022
Merged

Specs and tests for SLT and SGT opcodes#95
ed255 merged 7 commits into
privacy-ethereum:masterfrom
scroll-tech:feat/signed-comparator

Conversation

@scroll-dev
Copy link
Copy Markdown
Contributor

This PR adds specs for the Signed Comparator Gadget (opcodes SLT and SGT)

Copy link
Copy Markdown
Contributor

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread specs/opcode/12SLT_13SGT.md Outdated
Comment thread src/zkevm_specs/evm/execution/slt_sgt.py Outdated
@roynalnaruto roynalnaruto force-pushed the feat/signed-comparator branch from fcd226f to e166308 Compare January 20, 2022 03:03
Copy link
Copy Markdown
Contributor

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the great work!

@ed255 ed255 merged commit 13a0e07 into privacy-ethereum:master Jan 20, 2022
@roynalnaruto roynalnaruto deleted the feat/signed-comparator branch August 22, 2022 13:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants