This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Signed comparator gadget: SLT, SGT#280
Merged
ed255 merged 13 commits intoJan 20, 2022
Merged
Conversation
…-circuits into feat/signed-comparator
CPerezz
reviewed
Jan 14, 2022
Contributor
CPerezz
left a comment
CPerezz
left a comment
There was a problem hiding this comment.
Amazing job. Brilliant PR with really really nice documentation!
Just two questions. But overall LGTM! 👍
Contributor
Let me take a look at privacy-ethereum/zkevm-specs#95 first and then I'll review this :) |
Contributor
|
Although this has 2 approvals, I'd prefer to wait until the spec privacy-ethereum/zkevm-specs#95 is merged to merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the circuit for SLT / SGT. The spec PR is at privacy-ethereum/zkevm-specs#95