This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Fix opcode EXTCODEHASH to use non-existing proof for account existence#305
Merged
roynalnaruto merged 4 commits intoNov 12, 2022
Conversation
Contributor
Author
11 tasks
ed255
approved these changes
Nov 9, 2022
Contributor
ed255
left a comment
ed255
left a comment
There was a problem hiding this comment.
LGTM! I've added two minor notes.
…te `rw_counter_end_of_reversion`.
…ehash-non-existing-account-tag
Contributor
|
@silathdiir could you request someone from scroll to do a second review for this PR before we merge it? |
Contributor
Author
Yes. I asked @roynalnaruto to help review that PR later. He implemented this |
roynalnaruto
deleted the
fix/update-extcodehash-non-existing-account-tag
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to previous
BALANCEPR #248, fix this opcode to use non-existing proof for account existence check.